From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=016297cd77=abner.chang@hpe.com) Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by groups.io with SMTP; Sun, 15 Sep 2019 22:15:12 -0700 Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8G5Bio1023129; Mon, 16 Sep 2019 05:15:11 GMT Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 2v0sdehrpw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Sep 2019 05:15:10 +0000 Received: from G1W8108.americas.hpqcorp.net (g1w8108.austin.hp.com [16.193.72.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 4376F53; Mon, 16 Sep 2019 05:15:10 +0000 (UTC) Received: from G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) by G1W8108.americas.hpqcorp.net (2002:10c1:483c::10c1:483c) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 16 Sep 2019 05:15:10 +0000 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8454.americas.hpqcorp.net (16.216.161.4) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 16 Sep 2019 05:15:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AZv6wfVRIgWxbjQ9+R1YQLCpl6lwG0DPWVIpzctf3UWYze88/Mac++tc8qFhOKkDdBCsq+9RJ2keY2Q/MRjL7XEQx3rK9NZaoXiFmvdOI7NKclgERj3qV1n4KYJNUiR5w0VUeyvGoIVUi7oAxTB2GMZxlWqlVtSmSZDZmC5LgBjx/HhS2rCGWp6kFjGGYeRaZv6cqi4HISOuff4ZnQIrFvEWN/4fiKzlY+UmUmbjprkIcPbt2gxKkU7DLpATyR1DgkzQdLTkYi1viwimWCAqnWJ1IJW7Fq+C+kcMUd5CcnLMJAjgiMVyXJX4VuoObvKqa0ncvGoRya6mnqTXTQbzNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kIW5tvlQxOAxIb9W0JBsy+dI05CQzmxqWKjTctKlm5k=; b=CaEkHRhjgnzmoscMA3zsC4DBM7EUvQMrsiRQ7ADsShJkMTL+pHF6WRiPsOPceuXsMsjau5O4VaYfzXB9qdcSyPYxIIkIn3xlrISuQcmGEhsxtS3hdD/fRhjzbKiE+UakpFUTi+VMwBAcO6ZDuDO9hFM+CPcPvCDTKijta68//7bQt9d4W/hrn+drxauXxPKZVJve7NKaPeTuO6QpGuF5QzhM3upyzN9wy6pUSQcm5zpAX/ix9Tv9ii3AlLAiNvU1Wx2S1dGn4sF8rMkenhfWnJiVPkSDvmutX8kTRkHrJPlZxGlGb1vPCeuQr0ZVLRWhvCVaLqpOIoVcsqEjxNy5jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB1286.NAMPRD84.PROD.OUTLOOK.COM (10.169.97.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.13; Mon, 16 Sep 2019 05:15:08 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2263.023; Mon, 16 Sep 2019 05:15:08 +0000 From: "Abner Chang" To: Leif Lindholm , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Index: AQHVYxHRPOsRAX9Yik6qFJwlOsfqcqcbzJ6AgBIHuvA= Date: Mon, 16 Sep 2019 05:15:08 +0000 Message-ID: References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> <20190904175129.GO29255@bivouac.eciton.net> In-Reply-To: <20190904175129.GO29255@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 77ced0cb-314f-4c2b-f8a8-08d73a64d7ac x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:CS1PR8401MB1286; x-ms-traffictypediagnostic: CS1PR8401MB1286: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:404; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(346002)(39860400002)(376002)(366004)(396003)(199004)(189003)(13464003)(6436002)(229853002)(6506007)(86362001)(76176011)(256004)(7696005)(53546011)(55016002)(52536014)(99286004)(102836004)(3846002)(14454004)(66066001)(6116002)(7736002)(316002)(74316002)(110136005)(2906002)(5660300002)(305945005)(478600001)(8936002)(26005)(476003)(71190400001)(966005)(11346002)(2501003)(81166006)(81156014)(64756008)(71200400001)(66946007)(8676002)(66446008)(66556008)(66476007)(186003)(486006)(76116006)(25786009)(6306002)(9686003)(19627235002)(446003)(53936002)(16799955002)(33656002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB1286;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IEElAiw7V1bRpnPFgSFDk71xowfO0RAfW/B7DCeZyztpzQXTanRO4x2H1692uZiXJDD4iLEaG0Cp1ekqJ0FF9RbQPMknJ/agP1ubDSro4GppwtT52l7tHEZnHb6uOIXEaqtccg2aNIoOllXfTz+W9n8nj9lEaAYOb4dKs/AX3g3coieerqY/k/M8QAgcgQ3vXMdcMPbo7/dY5d9vHJcui31WpdVTrOG2i7Nx8v/XCwdkA3Ixn5ZT8Mx+zHrfOVz5saTxBMxLgduGKFj+eQbZ4xHUUXgYleUH06dqOiZ0lQCHmvKuuvqhbsNkiZ9U3sx0XzAYYVLfhbgM5PS44mo8j4u68pJlsfUPkF5nHqZXk1vowsgSL3FvQNkMvBzaII9tRu6oWnbwknT2zFE9ZfKU+FsnKnpuldS2rGVJ5rCsTOE= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 77ced0cb-314f-4c2b-f8a8-08d73a64d7ac X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2019 05:15:08.4303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EAQ2Iz8rOngfNsWyqW7ykutioNd1B9FEM0JprxuJ9w8FR73TvWZQItxtm+YP+2STsAX8V6ZvFDstbR6baYvE1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1286 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-16_03:2019-09-11,2019-09-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909160056 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, September 5, 2019 1:51 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > RiscVPkg: RISC-V processor package. >=20 > Hi Abner, >=20 > On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote: > > - Add RiscVPkg package which provides RISC-V processor related drivers > and libraries. > > - Support RISC-V OpenSBI and RISC-V platforms > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Abner Chang > > --- > > RiscVPkg/RiscVPkg.dec | 57 > +++++++++++++++++++++++++++++++++++++++++++++ > > RiscVPkg/RiscVPkg.uni | Bin 0 -> 1718 bytes > > RiscVPkg/RiscVPkgExtra.uni | Bin 0 -> 1374 bytes > > 3 files changed, 57 insertions(+) > > create mode 100644 RiscVPkg/RiscVPkg.dec create mode 100644 > > RiscVPkg/RiscVPkg.uni create mode 100644 RiscVPkg/RiscVPkgExtra.uni > > > > diff --git a/RiscVPkg/RiscVPkg.dec b/RiscVPkg/RiscVPkg.dec new file > > mode 100644 index 0000000..acf71fe > > --- /dev/null > > +++ b/RiscVPkg/RiscVPkg.dec > > @@ -0,0 +1,57 @@ > > +## @file RiscVPkg.dec > > +# This Package provides UEFI RISC-V modules and libraries. > > +# > > +# Copyright (c) 2016 - 2019, Hewlett Packard Enterprise Development > > +LP. All rights reserved.
# # This program and the accompanying > > +materials are licensed and made available under # the terms and > > +conditions of the BSD License which accompanies this distribution. > > +# The full text of the license may be found at # > > +INVALID URI REMOVED > 3A__opensource.org_li > > +censes_bsd- > 2Dlicense.php&d=3DDwIBAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN > > > +4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3D1PSVwg69_Y8lpR9wdv1TN7 > kg2brsZYR > > +sj5F_hpyPrv4&s=3DUSJlvms7O9ZDAsM0U- > FGng8i0uJkAMNbDEp1S_C4p0A&e=3D > > +# > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > +BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > EITHER EXPRESS OR IMPLIED. > > +# > > +## > > + > > +[Defines] > > + DEC_SPECIFICATION =3D 0x00010005 > > + PACKAGE_NAME =3D RiscVPkg > > + PACKAGE_UNI_FILE =3D RiscVPkg.uni > > + PACKAGE_GUID =3D 993C7CAC-C87C-4F08-A2CF-AD3AABA8= 59D1 > > + PACKAGE_VERSION =3D 0.1 > > + > > +[Includes] > > + Include > > + opensbi/include > > + opensbi/lib/utils/libfdt >=20 > This one is something we need to sort out (together). Having multiple co= pies > of libfdt in the tree is not on. >=20 > I personally think we need a longer-term encapsulation of libfdt that do= esn't > mess up the coding style. But until then, I would be much happier if you= used > the half measure we have in EmbeddedPkg: > EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. We may not go this way due to everything is from OpenSBI and we don't want= to maintain the difference to open source OpenSBI. Just take what OpenSBI = provides. >=20 > > + > > +[LibraryClasses] > > + > > +[LibraryClasses.RISCV32, LibraryClasses.RISCV64] > > + > > +[Guids] > > + gUefiRiscVPkgTokenSpaceGuid =3D { 0x4261e9c8, 0x52c0, 0x4b34, { > > +0x85, 0x3d, 0x48, 0x46, 0xea, 0xd3, 0xb7, 0x2c}} > > + gUefiRiscVMachineContextGuid =3D { 0xdad19cd5, 0x9d1f, 0x4f38, { > > +0xbc, 0xba, 0x10, 0x81, 0xe4, 0xcd, 0xb7, 0x3f}} > > + > > +[PcdsFixedAtBuild] > > + # Processor Specific Data GUID HOB GUID > > + > > > +gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSpecificDataGuidHobGuid|{0x > 20 > > +, 0x72, 0xD5, 0x2F, 0xCF, 0x3C, 0x4C, 0xBC, 0xB1, 0x65, 0x94, 0x90, > > +0xDC, 0xF2, 0xFA, 0x93}|VOID*|0x00001000 > > + gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosGuidHobGuid|{0x0F, > > +0x34, 0x00, 0x92, 0x04, 0x12, 0x45, 0x4A, 0x9C, 0x11, 0xB8, 0x8B, > > +0xDF, 0xC6, 0xFA, 0x6F}|VOID*|0x00001001 > > + > > > +gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosType4GuidHobGuid|{0 > x5B, > > +0x36, 0xEA, 0x23, 0x79, 0x6D, 0x4F, 0xCF, 0x9C, 0x22, 0x25, 0xC0, > > +0x89, 0x8C, 0x25, 0xB9}|VOID*|0x00001002 > > + > > > +gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosType7GuidHobGuid|{0 > xBF, > > +0xB4, 0x6D, 0x1B, 0x7E, 0x10, 0x47, 0x44, 0xB8, 0xBD, 0xFF, 0x1E, > > +0xDD, 0xDF, 0x71, 0x65}|VOID*|0x00001003 > > + > > + > > + # > > + # 1000000000 > > + # PcdRiscVMachineTimerTickInNanoSecond =3D ------------------------= --------- > ------ > > + # PcdRiscVMachineTimerFreq= uencyInHerz > > + # > > + > > + > gUefiRiscVPkgTokenSpaceGuid.PcdRiscVMachineTimerTickInNanoSecond|10 > 0 > > + |UINT64|0x00001010 > > + > > + > gUefiRiscVPkgTokenSpaceGuid.PcdRiscVMachineTimerFrequencyInHerz|100 > 0 > > + 0000|UINT64|0x00001011 >=20 > My personal preference would be for these Pcds to be included with the > specific commits that add use of them. >=20 > > + > > +[PcdsPatchableInModule] > > + > > +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > > + > > +[UserExtensions.TianoCore."ExtraFiles"] > > + RiscVPkgExtra.uni > > diff --git a/RiscVPkg/RiscVPkg.uni b/RiscVPkg/RiscVPkg.uni new file > > mode 100644 index > > > 0000000000000000000000000000000000000000..550e30d5c9e5db4091e4ba509 > 0e3 > > 8413a5c69393 > > GIT binary patch >=20 > I think we're happy taking .uni files as UTF-8 these days - this greatly > simplifies documentation review. >=20 > Regards, >=20 > Leif >=20 > > literal 1718 > > > zcmchXNpBND5QXcE#D8cx7eI*(95^6^h~r7H5@O2>fm1ZL6K8}SqqZ@a9}j%5 > dloy1 > > > z1Sd3_UTb;vs;YngYFNV@|1&;k@9f$#o7t5;wnv=3Dmu4irQ+mRjEM|NFHZERl{r$ > {+F > > zvjzJUoy>l6GU2RmEA#Acky)}&S?T- > ;*<0?e!dNeTRK6tf)iyzUYB$I_dxHI^%rEV^ > > zy|7od&- > y(!z6YGEAXB08!Bdj^@mLd*Wx(2ET=3DUO@mpLn;Q4C$HGaqs@W0pqrF7zHb > > > z>HDBNLGq0?Vdd=3Du_y=3DH?Hy8Xau;Ph+&c5Jag@kw$i(_!ik<{HL=3DgV=3DD29AV6y > ha9v > > z!m-QH5^f<9r-fZ)a?*2- > dPBSz_cLqoT|#O&}9ktiP?uiKdtGHGN;Wnrz`1=3DUgM > > zHOX^}{n- > vCM_$CinDKs;8NOsmz9Ucav1G4kN8l{{Rn_54tSX9Y?qi08`3JIhG41jb > > > zx!fQ%%JmmH6GFDy;zE_SA``De&8r3@$CCGf@jB6a^4YkPgC!>;BAC!0yWZ x#6#> > > zyIKvX-~?P<>ZoHUjEDAty*kaos^&rHyrvCVC4uRooiit#i<4- > f%0ip|N|5LW%N > zXpJ>y*_G8Ab2IF<+uuTW!M&_@f=3D6c;Nc94;bI#jXm5omD- > eV{1I+M=3D > > zynkjsINMv>U3(oSW)4HsSNN <_`Af; > > zA- > tS2o?z{gS&ZpU=3DK~}k{`SbGdTUAr6mOks;sADpw1#C*O{}R~b=3DH!zAs&uF?Y25 > w > > z^;~q}?n^pHdlD)-Y8RcXDjH!s<&XVRD nTv*oc{X6AmRe~(hV7dy3jW8=3D%O > > Pm-YX|Ux)1?&zk=3DL?rRDP > > > > literal 0 > > HcmV?d00001 > > > > diff --git a/RiscVPkg/RiscVPkgExtra.uni b/RiscVPkg/RiscVPkgExtra.uni > > new file mode 100644 index > > > 0000000000000000000000000000000000000000..64235949b742be811c22776aa > a6b > > 76741e8e68d6 > > GIT binary patch > > literal 1374 > > > zcmZvcNpBND5QXcE#D8d+3!uaX4jd3d*zu593Gv8wSWc0bEF &k_e@ > > > zxvQ(Xme;SU=3Dg;qsbu93I&M(+|yR^)fc43e05mudzY+z$MuzmZ4mfF 5#( > > zMxPRs*)J>$Y- > 1}dN58>mgFa;^`vJZ;oL%_Zu4^>4 > zYujUgM2;Vhvv8jVRqmCNvQADmA=3Dx rB_+86B^wiwKlTL$r7oESY7CI{1l&i > > > z>;liX)`OLI|G_^2v#JHJyCzG{?N{g(2L&GDO)SpAvBFbl+mf$ nK6 > > zh!Sog5~o#OMJ>wAckI>0sm)jwcT0p$^BQxYMns~1 iDIrrthF9i$ovxXVCay=3DH > > z`{*Y-m;!wf2XoecZ<$d`nN&OSq#7G^- > F61fs$Mf4!NjU=3Damjh?kTCzm_aUZTej=3DA! > > zyk=3D$mx@1DgihEpW(h559#%EqL7&(@I?u@s&eNI0+4|=3De{GUEmd- > p6kBHd(IuSJPcd > > z- > RH;>P^C=3DK&<C@6YNcfrUwIFSAxgbGY{Em > p0&1+ > > > z%B!p`WY2YJdo{LTpE(z > > z5puoTq^uHek=3DU0yPm_HB7b#Pvntfhd#aktVf2%rfm+eVCKlm%;YOLk > MTjOrW6 > > > y+J&iO)3ijhIWXMtN?L@e8L(*oPG%luwI%n%TL35A}MR?_sM(CC|Utz > |=3D+n > > > > literal 0 > > HcmV?d00001 > > > > -- > > 2.7.4 > > > > > >=20 > >