Palmer removed.

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Friday, November 22, 2019 1:15 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>; Palmer Dabbelt <palmer@sifive.com>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-
> staging: Revise Readme.md
> 
> Well, there's no 0/39 for me to give a generic comment on (please use a
> cover-letter).
There is a cover letter sent with this set of patches, you probably missed it. attached here in case you would like to give comments there.

> 
> Anything in this set I have not commented on I would consider good to go
> into -staging (and pretty close to be able to go into edk2 master).
Got it.

> 
> I have given a few comments that should be trivial to respin.
> 
> I have given one comment that will not be, but it needs to happen - the
> include wrappers. Clearly that will have impact on other patches as well, but
> as long as include statements are all that changes, that does not need further
> review.
> 
> *But*, it will mean we have compartmentalised the opensbi import, and can
> improve its importability upstream without having to do this work at the
> same time.

I didn't look into this in detail yet. Let me see if any better solutions out there.

> 
> /
>     Leif
> 
> On Mon, Oct 28, 2019 at 09:59:17 +0800, Abner Chang wrote:
> > Add opensbi submodule.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Gilbert Chen <gilbert.chen@hpe.com>
> > ---
> >  Readme.md | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Readme.md b/Readme.md
> > index 27e4ce0..4b3d2a5 100644
> > --- a/Readme.md
> > +++ b/Readme.md
> > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains
> > two submodules
> >
> >  - CryptoPkg/Library/OpensslLib/openssl
> >  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi
> >
> >  The latter one is actually required by previous one. It's inevitable
> > in openssl-1.1.1 (since stable201905) for floating point parameter
> > --
> > 2.7.4
> >
> >
> > 
> >