From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=01793483dc=abner.chang@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Thu, 03 Oct 2019 04:34:18 -0700 Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x93BWESa027948; Thu, 3 Oct 2019 11:34:14 GMT Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 2vck9m3171-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Oct 2019 11:34:14 +0000 Received: from G9W8456.americas.hpqcorp.net (g9w8456.houston.hp.com [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 20481A9; Thu, 3 Oct 2019 11:34:13 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 3 Oct 2019 11:34:13 +0000 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 3 Oct 2019 11:34:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbVTwvl9pq5WWw4wYNxfc1Jn7UCAig6fm8oUdGJWf+f3AMuRns+lQ8suHHtSFqyDp+EX8RvLKsrncNLvf9lanHDIl2NAIQGmByh0vxtah83dR52n7LcUCvUBskyGlvaUnopyLWOD7VpifwyLPkXFYkITsJN9uq16D2lgl2flS2Yk/Y7PHhfPhJbEAMc8bAYkg9vWKN+Ot+tGRKsm2gntlQaJ9FrhsqGeCitXJqpnTXz5cKfzziZQmCXIv1N8jPUq8F2kGddTmwSAFknEX/S1sTGbTwp+/dZe6liC9/NMk7/J5u0iUbpVLgt0ebVWqRqoRjoaP0cO+JF6i4hDKVOKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rrjH3VskajH8hjRjZX1bJv4RnokuJ8FqPEGxefIIeXo=; b=ep7MH0iyjBNUw/3MN248Dpe55J1FyppTICLGnYrHxa91gGf9sbHhFZSOw2oSabpgsOaaF5SccJCPf0TgxXmO8GRIKvStGeS6b0XFGHPe5JTdpLltPBnBteQecd7D99NgSMOF/22HvXo9TT2aguecx2jLM3gw3HsbrcsGZfPMIQ/ZiOBzx23758fyD50WWLOttutLTwOLmgEtysNk8+ibgx/QrUo0j38bOfwFMVtnkhTxCsetm6udDFOEz/xdhphFD2U7MKNEwFg9Tc6Ed/SeyP3vTavxOhFFFkF88ghddG/YagQpvlSDsNsxw6IPSdZZM+u7a3oaEuCIx5m2Gx++Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0679.NAMPRD84.PROD.OUTLOOK.COM (10.169.16.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 11:34:11 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 11:34:11 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: "afish@apple.com" , =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Mike Kinney , Liming Gao , "Palmer Dabbelt" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Index: AQHVcaqiBkSqxWRnL0+yEAnqc2QjJac+o/AAgAbjCwCAAAThAIABC+JggACILYCAAHF8wIAAB8UAgAACNQCAAImkUIAAg2kAgAAwuZA= Date: Thu, 3 Oct 2019 11:34:11 +0000 Message-ID: References: <1569198715-31552-11-git-send-email-abner.chang@hpe.com> <20190926233928.GL25504@bivouac.eciton.net> <90c04adf-79b1-2d89-1683-c916444126c7@redhat.com> <20191001090705.GQ25504@bivouac.eciton.net> <20191002091317.GZ25504@bivouac.eciton.net> <22170513-D99D-43E1-8086-B322DAC50857@apple.com> <20191002163510.GB25504@bivouac.eciton.net> <20191003083808.GJ25504@bivouac.eciton.net> In-Reply-To: <20191003083808.GJ25504@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28e24a5e-a1ee-4dbf-bbb4-08d747f59c86 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: CS1PR8401MB0679: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:411; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(376002)(366004)(39860400002)(396003)(136003)(346002)(199004)(189003)(13464003)(9686003)(25786009)(2906002)(33656002)(2501003)(5660300002)(6246003)(8676002)(4326008)(3846002)(6116002)(64756008)(66556008)(66476007)(66446008)(76116006)(66946007)(81166006)(81156014)(8936002)(53546011)(6506007)(102836004)(186003)(86362001)(305945005)(26005)(6436002)(99286004)(229853002)(76176011)(7696005)(7736002)(256004)(19627235002)(14454004)(71200400001)(74316002)(71190400001)(966005)(54906003)(316002)(110136005)(66066001)(11346002)(446003)(476003)(478600001)(486006)(52536014)(55016002)(6306002)(299355004);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0679;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aLB8CFeYoWiwgiLvEdDLHTmsJjITFBrnzzy/tAtmDbciB2B2iJBbXmp0yYTufRPWJcQ2Vqaziz2jjTIhk+YgSPxYqDHXcwD8EANIMnP+wqBqwJqVL29ENjgqRu86DzEq/oWUZamV3DPnWB8YSpWFrLyECCxHFlCe6ktQedj0Ac091ZOcDB49yg3L4KHEznPwrYTusfMQUGrTMrqkjze8k80E5gnFGR6Fi9Ctq1+xjJHrQLG80DMChwVWqF9QIy4WYp1kA68FkqrieEIaUvGUE/4Vcf+xYQiCPr0NRlung4ch36d0ua72w68UA5W4utkuEqPOS626q91OE9gUJzaxKw4jqH1pq4lp83ynXGaLQoel/aq9QZLooe9K8jE37DQVOgmfVA1xrUIznFJ2bhYfWzd817Bpfkjebce1rp4jG0UWdPQYWvPf41Pxu218sIouh5reJAZLLZPJJ/JWEGSLaA== x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 28e24a5e-a1ee-4dbf-bbb4-08d747f59c86 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 11:34:11.3400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6/Mnd+1IsbEaRwbKTvDoTf4/dN0t46CrTBlMjgzrnZlJenlaZPzfO+nC92Np+rdLBMx45vkC6XZ7aw7FD7zmPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0679 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-03_05:2019-10-03,2019-10-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910030108 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 4:38 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: afish@apple.com; Philippe Mathieu-Daud=E9 ; Mike > Kinney ; Liming Gao ; > Palmer Dabbelt > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] > MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. >=20 > On Thu, Oct 03, 2019 at 12:52:57AM +0000, Abner Chang wrote: > > > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > > > > agree with Leif that having two copies of the same thing does not > > > > make sense. I do see your point about naming, but maybe the issue > > > > the IoLibArm.c name. I don't see anything ARM specific in > > > > IoLibArm.c it seems to me it is generic C code for a platform that > > > > does not have IO Ports. So I guess we could just change the file > > > > name of IoLibArm.c to IoLibNoIo.c and have ARM and RISC-V point at > the common file? > > > > Yes, naming is my concern. No technical issues here. > > Thanks for this suggestion. > > > > > Works for me. > > > We can untangle the remaining mess unrelated from the Risc-V > upstreaming. > > > > Leif, I will rename IoLibRiscV.c to IoLibNoIo.c in the next version of > > patches. You can adopt the new file in ARM side later. >=20 > The suggestion was to rename IoLibArm.c. If you're insisting on keeping = your > duplicated version, you're back to looking for another maintainer to con= vince > that this is the better solution. Ah, yes. Rename IoLibArm.c to IoLibNoIo.h. I am good with this. >=20 > Best Regards, >=20 > Leif >=20 >=20