From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.385.1574438711128889632 for ; Fri, 22 Nov 2019 08:05:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0229d066a2=abner.chang@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAMG5Avx013127; Fri, 22 Nov 2019 16:05:10 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2wejvvg01q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Nov 2019 16:05:10 +0000 Received: from G4W9121.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 4ACAD72; Fri, 22 Nov 2019 16:05:09 +0000 (UTC) Received: from G2W6309.americas.hpqcorp.net (2002:10c5:4033::10c5:4033) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 22 Nov 2019 16:05:08 +0000 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (15.241.52.13) by G2W6309.americas.hpqcorp.net (16.197.64.51) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 22 Nov 2019 16:05:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DkwsFPdmIHeUCBqba9xtae+SBwW6iQjygEhPipjKTREQgF9q3jpV1chnzbpHv3jW7ee2as7RfxVDlGClcAJaSnYJLJSQygDBGq0F2sGLw/MFPRyA/dBrhc5hwVprpaId6yj6Y2xV4ynuVp9j5Oe9vvxbdD6J0fzfx510SOX+J8sqcR/TSXYw6fSA3PraDbAKcYkXMNv5v57Uc79c9RZD5mnNlLl9y2O/j0OgcweSumsE25myiTBcjRd7bLuGHivhVegGKV68tWkN3B7Sz7EYNLYxcGfotelt8ua8b74ROy2fx+JIGCUMQ887TQ7mP1GbCPqTybsi/nT4gTZON06w2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9XYu36Aqt3Ql4xLFyh/xSOpgdUUYjWJl+aGaTzmn1c=; b=g1J4IrZ0TFzHCzZMLH3MjxxYkZjcGxvosmfCp9vMIR2VTR50YVDQPImJXrYbKkQgsYOIGSL93eMzoP8qLL5Vz8YHG/ROz1NbZJ3JHnfeUf9aZIzDu5zRpAUZKMunCyien7McAA5kBqXTxj79b4iRzeg3pGnxT5zaKpKzF9dU7plVh2oZhoqBTTPh+3yXyNJ/Gy8i94NjuYrL4W9qQvOHbHPHTFw6H0ZE8WtqsCQ5eAN93SpEEpbMHw2C1Y8fslIUHAD77yDDPQ1vS/xHSslSOJOq04z3M1q5VhkfUcOhxCCfihKPkSIEPRFZxFAll7wqyIo88EuyIGMuaCGeCywmVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0966.NAMPRD84.PROD.OUTLOOK.COM (10.169.24.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Fri, 22 Nov 2019 16:05:07 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac%7]) with mapi id 15.20.2474.018; Fri, 22 Nov 2019 16:05:07 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: "Chen, Gilbert" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Thread-Index: AQHVoI2PH/hWeyRqeUy47mnpjpmXpKeXHqGAgAAc7ICAAAJtwIAACsOAgAAP4KA= Date: Fri, 22 Nov 2019 16:05:07 +0000 Message-ID: References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-30-git-send-email-abner.chang@hpe.com> <20191121170254.GP7359@bivouac.eciton.net> <20191122140835.GF7359@bivouac.eciton.net> <20191122145547.GH7359@bivouac.eciton.net> In-Reply-To: <20191122145547.GH7359@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b360b1b0-0b91-4059-4bfb-08d76f65be9f x-ms-traffictypediagnostic: CS1PR8401MB0966: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(366004)(136003)(39860400002)(346002)(13464003)(199004)(189003)(14454004)(53546011)(11346002)(5660300002)(102836004)(76176011)(71200400001)(74316002)(71190400001)(19627235002)(25786009)(4326008)(6506007)(186003)(26005)(7696005)(446003)(8936002)(256004)(6246003)(14444005)(66946007)(86362001)(66556008)(64756008)(2906002)(76116006)(305945005)(81156014)(81166006)(478600001)(66066001)(6306002)(9686003)(7736002)(2501003)(110136005)(6436002)(52536014)(316002)(229853002)(8676002)(966005)(3846002)(55016002)(66446008)(66476007)(6116002)(33656002)(99286004)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0966;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U3dyh9AuK+OVSaGKqyRhC5zJOPdyFBO8hQm0e6RfDRXnw8sdOwwDoldxdnh51/nfyhT9wssEUbDelWXg5mIoxfHz/1LNPYgRHR5yhECxWd4NheOTPOsdQO10+p/eDcnli2QYI9msbcAlLQrec8DQyMFZHmns+SoUclHKEzS6SJ+g6VH5z2ZHrLbBWWAuXmChaOaeqWy+4r61twMENkRmsRGaKuZxeI95Q6fvyjN4qg83/PZyFtXpCfzi7AVyV0TAjb7BQk4/19Bu18AchvTS9MqtizN+dylyfels21OWyOH7lVMOncaoICJEqk3RExXa1ex19MDxfGxCtc6DzwNLBXiLulYWESQR7mkZ0f5H5BaR2mjasLCtxTwvgdBPfksvZp1YW/XJfyigE0oJABQgmvHhUdAZj6+9X/ptaxPkAHlMXsaZQRJ1SY+hPbkvlXNhXZCYnC1LoRI1hhNpWvsPi3dF8TNE2Z2xBfwYfcsULNA= X-MS-Exchange-CrossTenant-Network-Message-Id: b360b1b0-0b91-4059-4bfb-08d76f65be9f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 16:05:07.4476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bMElbscxhyLwVz6WFak7qxagnGeSru12QS4NSrTX8mISlokWb4SsKGXEVrvlueDA5lo3Rea4khkAutFVgPcsHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0966 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-22_03:2019-11-21,2019-11-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911220137 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Friday, November 22, 2019 10:56 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] > RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. >=20 > On Fri, Nov 22, 2019 at 14:19:55 +0000, Chang, Abner (HPS SW/FW > Technologist) wrote: > > > > > On Mon, Oct 28, 2019 at 09:59:07 +0800, Abner Chang wrote: > > > > > > Null instance of Real Time Clock lib for RISC-V platform. > > > > > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > > > > > Cc: Leif Lindholm > > > > > > Cc: Gilbert Chen > > > > > > > > > > Can you drop this one in favour of > > > > > EmbeddedPkg/Library/VirtualRealTimeClockLib/ > > > > > > > > Both U500.dsc and U540.dsc use > > > > EmbeddedPkg/Library/VirtualRealTimeClockLib, you can see this in > > > > edk2-platform patches. > > > > > > > > The NULL one is only used in RiscVplatformPkg for build. I don't > > > > think we have to use VirtualRealTimeClockLib in this > > > > RiscVplatformPkg package. > > > > > > Sure, but we also don't *need* to add a new implementation for this > > > - RiscVPkg can still use the EmbeddedPkg one. > > > > > > (And if we did, it should probably be in MdeModulePkg.) > > > > I think we had similar discussion about this before. My comment was > > RiscVPkg as a processor package should not have dependence with > > EmbeddedPkg. >=20 > This is not RiscVPkg though, this is RiscVPlatformPkg. > And also, it does not appear to be used there anyway? Same comments from me for RiscVPlatformPkg. I don't see any reasons to ha= ve dependence with EmbeddedPkg in RiscVPlatformPkg as RiscVPlatformPkg is a= generic RISC-V platform modules . Platform such as U540 could choice which= RTC instance it needs. >=20 > Certainly I can still build RiscVPlatformPkg.dsc if I delete that librar= y mapping. We can remove this one and create a null one in MdePkg which is akin to th= e null instance of TimerLib. >=20 > / > Leif >=20 >=20