From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.4525.1574494736954745137 for ; Fri, 22 Nov 2019 23:38:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0230dd3417=abner.chang@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAN7aMH5029325; Sat, 23 Nov 2019 07:38:56 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2wevykryhp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Nov 2019 07:38:55 +0000 Received: from G4W10204.americas.hpqcorp.net (g4w10204.houston.hpecorp.net [16.207.82.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id EC0F35C; Sat, 23 Nov 2019 07:38:54 +0000 (UTC) Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 23 Nov 2019 07:38:54 +0000 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 23 Nov 2019 07:38:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJ9zoSHDwAE6osbXvrytT/Z2mURAsgwgqUtZIx9istGXIsMY8FyvhXu4/DMpQbTs621wab15+1ufuIv+xllU3LwI8Si04EgpxMjb+4VsFxoUKP7qfQtI7Xj3N9qDLmu+kZtdc9uM+haSB1h754lKwxVh6nPRwTV/030RWT4cD+4unPrwXSGXIqdOvSzlbCTe9D/XcejJEnsulNw1VNg9GwUoto4IwqiEkj3euiL9pc741MT9WJHJhi8kRreGIlOZtM97YiHh4ehxO84A+5dQ20all+e4qC4fVS/FMzfr2uQxJak9sr+3qMF/MuqnYOhVs1BvmKzE4k0dmcaB1d+okw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rcbW7F26RpAoFd10lGuYMKJCF1mceymuBMH4pRv7kQ=; b=g4EbvyTutii0CbpYALvf3CoO/zV5WImBFuMDXPPIlXZLFd1IKZbXEoVPXdW5maDiI14r0Z7a5xuTnZQqzTYYM9YxDG9LyRonKvctMG6z+D7RGOuNXQC294QIHnTO4RXiOlLviw1CnuvZDst8UmeAXmWHjS/VGeNY26apm5gNH9bl3UdG8VLdFOKV43JnH7UJ/n55LerLVjd/j2O4bYwA6/ZCFBtyoT78O2K/Gb2X1+QX85PRKKvyfWTt0JhKDQ/Avcu5p8YfRYOqZfC63KdwXvOEtS5e9/zLPLMyAOxSOvV0W7MhXwgUf8IqYBBIBWckEhetQFW537ixaVtkQClJTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0440.NAMPRD84.PROD.OUTLOOK.COM (10.169.13.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16; Sat, 23 Nov 2019 07:38:53 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac%7]) with mapi id 15.20.2474.022; Sat, 23 Nov 2019 07:38:53 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: "Chen, Gilbert" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. Thread-Index: AQHVoI2PH/hWeyRqeUy47mnpjpmXpKeXHqGAgAAc7ICAAAJtwIAACsOAgAAP4KCAAAsPgIAA6CEQ Date: Sat, 23 Nov 2019 07:38:53 +0000 Message-ID: References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-30-git-send-email-abner.chang@hpe.com> <20191121170254.GP7359@bivouac.eciton.net> <20191122140835.GF7359@bivouac.eciton.net> <20191122145547.GH7359@bivouac.eciton.net> <20191122163210.GI7359@bivouac.eciton.net> In-Reply-To: <20191122163210.GI7359@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4b5083ef-d730-4064-4142-08d76fe83075 x-ms-traffictypediagnostic: CS1PR8401MB0440: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 0230B09AC4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(376002)(39860400002)(366004)(346002)(189003)(199004)(13464003)(256004)(5660300002)(86362001)(14444005)(33656002)(52536014)(25786009)(478600001)(186003)(966005)(14454004)(26005)(6506007)(6246003)(71200400001)(53546011)(71190400001)(66066001)(99286004)(102836004)(2906002)(6306002)(446003)(11346002)(6436002)(55016002)(110136005)(316002)(74316002)(7696005)(6116002)(76116006)(3846002)(7736002)(81156014)(81166006)(8676002)(19627235002)(305945005)(8936002)(4326008)(9686003)(66556008)(66476007)(76176011)(2501003)(66446008)(64756008)(66946007)(229853002)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0440;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?us-ascii?Q?2x7XZSN8D7LW2QqT+Nsm/LWNxUWjv/xz2XJyTshvIwstoBPNGPsJhuCEObh7?= =?us-ascii?Q?5L4yrxYa0LriNYLo3nMEsMMjSDBJqXFwsoLieBN7XGASBlavr23tr6v/6iHM?= =?us-ascii?Q?QSLeN45TEB2kFO7zf8HYRPRJtxIM1PsE5WjnRTiQEMCPCLa+TZAA9K0R3n29?= =?us-ascii?Q?rtzWEPoklXIPhyrqmP6E54shyOLXCumh/+bUNmkyuRLrfczaDZu0zCiuZOLD?= =?us-ascii?Q?lNuOyCRlHMUFnHM82hQnKTmoS7QKYb8Jdl8lcBhy0U+59FCr74hDFiUTcoIt?= =?us-ascii?Q?m3c/7bdMT987E9SJPucp6KQRYTQY4J1bUVdVXRucY+VIfWien84ayAW+DOa0?= =?us-ascii?Q?vwVawhfWrXXlCJfP9ic+cFbkb/g4kkd7Bu/iQATbFAXpNTo2d6+WSdho7VlX?= =?us-ascii?Q?ASD1PBqQDHOErHLBAin93R7E9b1EpgB/tk//51JzytCGH5SZgCQXACcl+TzK?= =?us-ascii?Q?hWWQLqM/623YS/kOMHBduv5CsJsafk7Y5qHM9XFEvfOIc0+K5AAxjdWazzTO?= =?us-ascii?Q?BPosGEZVMbuvhSOS5l+oMTECsB+hqzmXtAegY8DAwwp1NCQWf4egXNLdPNfg?= =?us-ascii?Q?CSW+16hmA1xwPA4whCq6Z8zPUB2ruJH65v1Wef9vAk5ld39x6fK+JmoF2R2V?= =?us-ascii?Q?BnH8oLY99zAUPydv5/tO0NHGBySMO8+GXPNee2cwYlPdstvjGtNmCPtixCBr?= =?us-ascii?Q?7maTR5HCdKnB0gjqoC2AKQIyeOjWJWfFsypUtGFs1d1GsxQ3Yzcmb0FCUdsK?= =?us-ascii?Q?GsjjQ2mWlmqmpSytgB3z8ULokjxDiSPTsx/PWfffcZPQ+sZPBWZ7x553SqxV?= =?us-ascii?Q?3RYypxuXOcZ/LtfY7YC+RVIHPOSfc+iw5GnrAbAjHyzLa0o45ECRdn30iXJq?= =?us-ascii?Q?yTc2Gv3UY8SpyRTlX89XOP4WdxOPSnWebrWW84fn/GCQ24Vc1oeYaEVPe+Fw?= =?us-ascii?Q?GdLd6zZHd3XGX7AJHs+J1sA3RVafNaDEqJ79wHvcNXQIFc68vmLcbtZRHceV?= =?us-ascii?Q?ed3zqGp4oEaPfDeCo4v2zak9CMQFA2HsTdEPAiflKqaMCZFAmDvL0jCJl7W4?= =?us-ascii?Q?9P7nKzDKezOkeKkwHz4AXSMqgdj4jCegC2+SHnSHBchrQkxToMSnA+JG7JP5?= =?us-ascii?Q?gc7gRwcbI7aW8VslsgeviLimEIeCVZSzeV0JoqBcaJxBm8xiULItZq/cRhLs?= =?us-ascii?Q?ATKkV/qauJoHEQ4yYbRpKLbJ/OeSQMH0QMRtZTRJdkZsl56t5xZ4VLLeyC3W?= =?us-ascii?Q?wX3lTKT0JWTx96wnb0jvDkIZHlMJDCiZzmX9Ss7Hn+K3ry7/M5mNyGlaaSwS?= =?us-ascii?Q?VFXR3mfb39i2xNeyJWcJrX36XR+FS66gGxLa2aeV/6f32sIIiQk2QNeu44Ih?= =?us-ascii?Q?Q1jfqkFkRKjps0UbVX71Q158Jwl7BHAbyzBOKyu3ZXvq+lW9Xe4MIcIF98tU?= =?us-ascii?Q?9l1PMbKO3AFHVWxYIY3PzWiIENwbCu1P3DWHmVKCeuStQ/OiAMUrf3ycnbdR?= =?us-ascii?Q?TELNTTv7AdqcM1v5lTn+LMtT+16blO1fForVSP0HgA0Ex+eVg2neQjoQwGVe?= =?us-ascii?Q?mOXYT7Qt83aLbPs7QmJEgRVQsm76uI/gLxCfqYzsgFDGP8tKKv4jNQ5EOp1c?= =?us-ascii?Q?YcDsXDOeLbCzpZWxtcjYZHjCw0g6Ke0qDHunYgsI9Z8qOpisio33/nxP5a9i?= =?us-ascii?Q?avC79+s74Le8XcRwHE5sdKwjADsJblSI7KqHh/JlH/PWlGCapaILAz3uhHE1?= =?us-ascii?Q?FlMf8w7kz5Gua7Qf9fSycP27mMNgOq1WwkEfzslUJiwGLvtZflDrV5Gap6mh?= =?us-ascii?Q?N++o04O6AlOC3Sk2litrXfeO26oFD9fTjZj9rLkDQ7VtCTxCgDncX6J/JWx6?= =?us-ascii?Q?qjR7inU0UTYDe+3+L7Ac22XZHf6fLj1myuOPDJs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5083ef-d730-4064-4142-08d76fe83075 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2019 07:38:53.1751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y1DoQsEVrilUcEYyxYcDXatH54J16zlJWehkw/NAi9LZitoNJiFJmJhbHqXbsNgDvqlwz0bhNK5lN7Dc5iQICg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0440 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-23_01:2019-11-21,2019-11-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911230055 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Saturday, November 23, 2019 12:32 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] > RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib. >=20 > On Fri, Nov 22, 2019 at 16:05:07 +0000, Abner Chang wrote: > > > > > Sure, but we also don't *need* to add a new implementation for > > > > > this > > > > > - RiscVPkg can still use the EmbeddedPkg one. > > > > > > > > > > (And if we did, it should probably be in MdeModulePkg.) > > > > > > > > I think we had similar discussion about this before. My comment > > > > was RiscVPkg as a processor package should not have dependence > > > > with EmbeddedPkg. > > > > > > This is not RiscVPkg though, this is RiscVPlatformPkg. > > > And also, it does not appear to be used there anyway? > > > > Same comments from me for RiscVPlatformPkg. I don't see any reasons to > > have dependence with EmbeddedPkg in RiscVPlatformPkg as > > RiscVPlatformPkg is a generic RISC-V platform modules . Platform such > > as U540 could choice which RTC instance it needs. >=20 > I don't think there is any particular inherent aspect about EmbeddedPkg > being more evil or unreliable than MdeModulePkg. If anything, it suffers > from poor naming. (Basically, it was the staging area for bringing a bun= ch > of !x86 stuff into the tree, and the first platform port was to an embed= ded > board...) >=20 > But more importantly, RealTimeClockLib is only used by > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf, so > it's a bit difficult to argue that EmbeddedPkg is an unsuitable source f= or the > library. >=20 > We will at some point do an overhaul of the directory tree, so getting h= ung > up on current package names isn't a worthwhile investment. >=20 > The only real exceptions to this are MdePkg and MdeModulePkg, which > should not depend on any other packages. And I tend to argue even about > that. >=20 > > > Certainly I can still build RiscVPlatformPkg.dsc if I delete that > > > library mapping. > > > > We can remove this one and create a null one in MdePkg which is akin > > to the null instance of TimerLib. >=20 > I have no issue with that as such. > I also don't see a value. >=20 > A RealTimeClockLibNull is only useful for enabling compilation of incomp= lete > platforms (and as such, if it was included in MdeModulePkg, it should > probably have unconditional ASSERTs added to all functions). >=20 > Whereas VirtualRealTimeClockLib can ameliorate the situation of not havi= ng a > persistent RTC in the system. >=20 > But for the purpose of this set, please just drop this patch and any > references to this module. no problem, I am fine with removing this lib. Thanks! >=20 > / > Leif >=20 >=20