From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0167a02ea5=abner.chang@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Sat, 21 Sep 2019 00:14:51 -0700 Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8L75V2P031638; Sat, 21 Sep 2019 07:14:49 GMT Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0b-002e3701.pphosted.com with ESMTP id 2v5d8j29jp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Sep 2019 07:14:49 +0000 Received: from G9W8456.americas.hpqcorp.net (g9w8456.houston.hp.com [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id B19D183; Sat, 21 Sep 2019 07:14:48 +0000 (UTC) Received: from G2W6309.americas.hpqcorp.net (2002:10c5:4033::10c5:4033) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 21 Sep 2019 07:14:48 +0000 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6309.americas.hpqcorp.net (16.197.64.51) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 21 Sep 2019 07:14:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxFV041RSEVgHzE8d11Vuwouk57qF+ABgbs/W9BpYXN0VxMsQZ7bAF25cMVuxgSNu9nWyCpNymx78Nvau3CTyRkFU55/HYNuT+CcN0TyWjxpT39VSepxRkS/W2ezu/NR9gns/tMRVyfbW/KGXjTSrujLHbUXlpQCYANeCPZhWdB7ymbJzxcjHupWQZxM2eEcjUJ/Z3muIr0p0D2aQZUcwx9npURm1xz5bq7miuOa4xvHXB3JDN+R/1X+sXJESxeHkyTeTBAj0NH8WeJJ/OFHnmjH5oRb3X9iNND9QVl9ILiMcyx1f2LHCilPSqQYqnMpqAnAJ5vJT6/n7e7mtCkeRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziCpWriXT8qQu2sqLoOBAwPlx2QhtxXFE9GTzzi5iVA=; b=bDkiJ7NSuCCaLzxYI/xu2RoRbJietNxMl8VfmcWwnjs2hagrtGtGe/7x3s4blWjGqJsdA4Ls27D5yQQ/Wh5uyD7wsIOHJ6qVy9CG3/3iMIW1iGtKk2Sbz+dE7OcNFrpzgmcZJiBT/nNg+l6pk9Pbc0ovMQjD6DUrBOwhORkhJfDd2xxeF6E8Mn+BwlyPFgn23fPemCYeusBzkqlyKRppJKWoLHLZA68F684EcHrtUsEFGKa6nMF6yyhtE1c5IeJWf5L0gqqqSFSwg6HhcTZqNQaZFcJ5uxCJEoV4qJ1IQidj0NruEgKzzuAm5OPdmvCFpHrwAihiYp3J49mC+hu9hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB1125.NAMPRD84.PROD.OUTLOOK.COM (10.169.16.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.22; Sat, 21 Sep 2019 07:14:46 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2284.023; Sat, 21 Sep 2019 07:14:46 +0000 From: "Abner Chang" To: Leif Lindholm CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Index: AQHVYxHRPOsRAX9Yik6qFJwlOsfqcqcbzJ6AgBIHuvCAAibUAIACruFggAI6v4CAANjcIA== Date: Sat, 21 Sep 2019 07:14:46 +0000 Message-ID: References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> <20190904175129.GO29255@bivouac.eciton.net> <20190917140318.GF28454@bivouac.eciton.net> <20190920170431.GK28454@bivouac.eciton.net> In-Reply-To: <20190920170431.GK28454@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 445141ef-37c2-4499-bfb4-08d73e636229 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:CS1PR8401MB1125; x-ms-traffictypediagnostic: CS1PR8401MB1125: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0167DB5752 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(136003)(396003)(346002)(366004)(376002)(52314003)(189003)(199004)(13464003)(3846002)(14454004)(8936002)(71200400001)(6116002)(76176011)(446003)(476003)(11346002)(7696005)(76116006)(74316002)(66946007)(316002)(305945005)(7736002)(229853002)(2906002)(66556008)(81156014)(81166006)(66446008)(55016002)(9686003)(71190400001)(64756008)(8676002)(66476007)(99286004)(52536014)(6436002)(14444005)(4326008)(6246003)(33656002)(186003)(86362001)(26005)(478600001)(256004)(486006)(5660300002)(25786009)(66066001)(102836004)(6506007)(53546011)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB1125;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DXzF1Mll4qxZN3bK6KQ1jEVCSTJJw6/dM64BffhakJ6/Y+FaxDdwgL2xpnb+rhEUVA0ElZLk2wVmVJd88QXIvP4Q67FLKPrX9Q6HEiyOV9F84+ES56xXUlTP1GxVLSHsg2a9l9+ynPLDex0IubwlzPQmHyt1oX3jthtpow1ZWtT7yn1rZ3n9BnDcKMuftld6fjBXjEa1YgidMYcMKjT1D2etIACkSlBRoDbXaM2vsE5mVpcQulXQoTdkjtfY+QZsXOFtT95R1EetOthO2WH93VQSV8Br9v3l25nCPYYVrFe6wasTnouIH5iZbyzV0KkJHWTOA8/JvB0NM1s8ht07oy9fHGxmPunZQsTZgVAuOsjw5Z4nsMzeG42Nr15TKmaKVnEgFeXO5INVPAW5ISaalADHRptrX17RE8wJJopdlbM= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 445141ef-37c2-4499-bfb4-08d73e636229 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2019 07:14:46.4012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j5NHd28Bfdy3gb4uR4dqbltWcNLh3W4IPRsTpfU1Wk4FB9rWB5kKCgN4wvMdt/u/GQwsa8vnCySXx53JuzJH4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1125 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-21_02:2019-09-20,2019-09-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 mlxscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909210078 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Saturday, September 21, 2019 1:05 AM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > RiscVPkg: RISC-V processor package. >=20 > On Thu, Sep 19, 2019 at 07:10:16AM +0000, Chang, Abner (HPS SW/FW > Technologist) wrote: > > > -----Original Message----- > > > > > I personally think we need a longer-term encapsulation of libfdt > > > > > that doesn't mess up the coding style. But until then, I would > > > > > be much happier if you used the half measure we have in > EmbeddedPkg: > > > > > EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. > > > > > > > > We may not go this way due to everything is from OpenSBI and we > > > > don't want to maintain the difference to open source OpenSBI. Just > > > > take what OpenSBI provides. > > > > > > If libfdt was a very quickly changing project, I might agree with you. > > > But it is not. It is a very simple piece of code that performs a > > > small set of operations on a very well defined structured encapsulati= on > format. > > > > > > So please use the one from EmbeddedPkg. On the very unlikely > > > occurrence that you require functionality not provided by the > > > version in there, we can update it. > > > > I am not sure how's compatibility between these two libraries. However > > I can't agree to use EmbbedPkg one now, maybe later once this port is > > got on edk2 repo. Currently we just simply create an INF file and in > > which pull everything OpenSBI provides, that is easy for us to > > integrate OpenSbi. We don't want to increase complexities now. I am > > not saying to not adopting EmbbedPkg one, just not for now. >=20 > If the libfdt is simply what comes along with opensbi, then I can live wi= th that > for now, once opensbi becomes a submodule. Yes. It comes with opensbi. >=20 > The conversion to use the current EmbeddedPkg FdtLib should however be > completely trivial. Yes. actually it is easy to convert it to use EmbeddedPkg. We just don't wa= nt to see edk2 opensbi port refers to the modules outside OpenSbi itself.=20 >So I would still like to see the following > *attempted* before we start considering this being included in edk2 > master: I will say yes to any ideas which could make the better code structure, but= just don't make more efforts to maintainers while integrating OpenSbi to = edk2 when the new version is released. >=20 > - add FdtLib to RiscVOpensbiLib.inf [LibraryClasses] > - delete all of the libfdt/* files from RiscVOpensbiLib.inf [Sources] > - add EmbeddedPkg/EmbeddedPkg.dec to RiscVOpensbiLib.inf [Packages] Anyway, that's no problem to remove OpenSbi fdtlib from edk2 opensbi build = as edk2 opensbi is just an wrapper. But we don't refer EmbeddedPkg/EmbeddedPkg.dec in RiscVOpensbiLib.inf beca= use RiscVOpensbiLib is part of RiscVPkg which is the processor architectur= e package. EmbeddedPkg version fdtlib is referred in RISC-V platform (edk2-= platform) but not from RiscVPkg, same as to use EmbeddedPkg /RealTimeClockD= xe for RISC-V embedded platforms. RiscVOpensbiLib is now without fdtlib instance. However the code is still t= here because it is part of openSbi. Gilbert had sent out the PATCH v2 for R= ISC-V platform code. You will see platform PATHC v3 from me which involve a= bove changes. Thanks Abner >=20 > / > Leif