From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.2567.1570605654128448974 for ; Wed, 09 Oct 2019 00:20:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0185433736=abner.chang@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x997Glwe025174; Wed, 9 Oct 2019 07:20:51 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2vh1pefvby-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Oct 2019 07:20:50 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 13E985B; Wed, 9 Oct 2019 07:20:50 +0000 (UTC) Received: from G4W9325.americas.hpqcorp.net (16.208.32.94) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 9 Oct 2019 07:20:49 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W9325.americas.hpqcorp.net (2002:10d0:205e::10d0:205e) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 9 Oct 2019 07:20:49 +0000 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 9 Oct 2019 07:20:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQJyRsg0Mxk1WDI7K4A2V6hfF/6w9Prs3GlEIpLGHO31lm/vjXlbGgJ6MDEBTHoX5RzT3cxhuckxM25XBO/ZzQXJGwGc4d4n+kS5zqHAbpyH5+vjKIJRqCngo4zBteDAmy20ussI4ciMJ0WiqGCVV9SaCTtnyiTyq04j0fz/V/MsMI8AaeV9ajJ3U2NS81zv6z+nv7YFoh7C5LjHEZund2kBiQhvm9Q/cXgJhwH6PwKY19EWieQxIWd/m8/5+18TqBtO0uSF/e980UWol+OZKQK87ITf/GBjzL/jFDXa8hx+VeBXncaKMVim6XWzEsULatP09qVwe0JtU4a+P0TszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kgb0sV/4k8WKwtt6+YDVMEdxqRAIW065XLuty7V39OU=; b=Bguo8sdvYJUe1roj/gzSMpiACcm2W4uymrF/uDrI8WemA7YbdExaV+n0u92bIVfxBVLwLZoVnMqMHUgRGVRikz4Cp/eLpy6Sxd68pvt0FpYHTMiT3rmU+DFjXr6jXM7AFtxsaVPJbM3nB9IBzj8r56d1RrD25lkgmfwrnHfGA++EcURy7OCtiJ4Fcwurf6rwZr7F777sQdZSzRZFmO3UTdx0orY5OOnqj+jtjKITFXUh4zBVFZZbVA2QBp9FrDHmNcjjzCrAuoQZx7H6lpgJNAoztYJfj98rTxr3+0khY0qLDVZpd0ywm2t2T8M6zGzHEe4STAjx5PesVf3sdyK7fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0950.NAMPRD84.PROD.OUTLOOK.COM (10.169.14.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 9 Oct 2019 07:20:47 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2327.026; Wed, 9 Oct 2019 07:20:47 +0000 From: "Abner Chang" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , Leif Lindholm , "Chen, Gilbert" Subject: Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 Thread-Topic: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 Thread-Index: AQHVfk1ZkP20h4HDGkeKpU5rbtDLEadR5yPA Date: Wed, 9 Oct 2019 07:20:47 +0000 Message-ID: References: <1570521848-5465-1-git-send-email-abner.chang@hpe.com> <1570521848-5465-4-git-send-email-abner.chang@hpe.com> <3CE959C139B4C44DBEA1810E3AA6F9000B850A2C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B850A2C@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.139] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52a53137-8176-4e53-8321-08d74c8934c6 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: CS1PR8401MB0950: x-ms-exchange-purlcount: 2 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1186; x-forefront-prvs: 018577E36E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(39860400002)(376002)(346002)(136003)(396003)(366004)(13464003)(199004)(189003)(316002)(55016002)(102836004)(229853002)(33656002)(6306002)(71190400001)(71200400001)(25786009)(7696005)(305945005)(74316002)(76176011)(8936002)(86362001)(15650500001)(5660300002)(53546011)(6506007)(66066001)(6246003)(14454004)(966005)(30864003)(4326008)(6436002)(66946007)(26005)(7736002)(2906002)(64756008)(66446008)(66556008)(76116006)(8676002)(54906003)(3846002)(6116002)(66476007)(9686003)(11346002)(478600001)(476003)(446003)(486006)(99286004)(2501003)(14444005)(186003)(81166006)(19627235002)(110136005)(256004)(81156014)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0950;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nTkX1Rb/2AkRLC4jpm8YiqkdRMzul4FXW8xYRNx2HL3SBS1mdaVS38HVriPcqGdK0CF+AIpO6RmFvXLRc1RVcXQojmzzYhqbeEGBi6oV2vfbMzKufqXIg9PPjl6TNteuESO08x+NLEoucFtrCYrYH8mxX1nM9ypH9lXrSA02b4KVkcitJyHxK03t/SCOLBhRMBTA0VEWjhusCmwwCjUgJ3AG0BaFGGSKbmMHwza3gmCsRyzMfhlrtHOmP/m24DGMrwhmM08s+DoVR5a73K+j8TgoX702GcjQ2nzwiICa6LrCCn3RqzjnGI6lU6BhLnu8wBuNX+7kb1wbokg7YZu7rSRSPieonbVGzHsoVDPCjaF373pUkYqyov/aF+tBnN7qa3Dd4BKrQyE6b2QicbW5YN6K1QXFpAwukmhAQ+22o9tZr6EA6maXaTaq+YpX069u5uEf9vJ6H9aFHa7bkBZrmQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 52a53137-8176-4e53-8321-08d74c8934c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2019 07:20:47.4470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gjwMLCuEHoDYsoC4rdtnAJq3eDlm5DhyxGRXmKMqYDlA4kPYOxPwSQsFBlXWQWgPw8UGoPIer46NKBKLEBvBCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0950 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-09_03:2019-10-08,2019-10-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910090068 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Zhichao, I revise it as your suggestion. [PATCH v6] for the third patch (rebased) w= as just sent. Thanks Abner > -----Original Message----- > From: Gao, Zhichao [mailto:zhichao.gao@intel.com] > Sent: Wednesday, October 9, 2019 10:58 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Carsey, Jaben ; Ni, Ray ; > Leif Lindholm ; Chen, Gilbert > > Subject: RE: [edk2-devel] [PATCH v5 3/3] > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 >=20 > How about change the function name from ProcessorArchitectureType to > DisplayProcessorArchitectureType? >=20 > And why separate the processor arch type display into two section: > i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thr= u > PRINT_STRUCT_VALUE_H, second display the value's meaning thru > ProcessorArchitectureType, such as " 128-bit RISC-V (RV128)". > I suggest to put them into one function DisplayProcessorArchitectureType > like other functions did. Such as the blowing format: > VOID > DisplayMCHostInterfaceType ( > IN UINT8 Key, > IN UINT8 Option > ) > { > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), > gShellDebug1HiiHandle); > PRINT_INFO_OPTION (Key, Option); > PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Tuesday, October 8, 2019 4:04 PM > > To: devel@edk2.groups.io > > Cc: abner.chang@hpe.com; Carsey, Jaben ; Ni, > > Ray ; Gao, Zhichao ; Leif > > Lindholm ; Gilbert Chen > > > > Subject: [edk2-devel] [PATCH v5 3/3] > > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > > > Bugzilla link, > > INVALID URI REMOVED > > e.org_show-5Fbug.cgi-3Fid- > 3D2202&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_ > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DiZPRGBE2YqYcm2VO > KgWvwrtGD > > P3Gn- > 0WwIs5VAkpqao&s=3DSidItX73peVBmSm4Ws1A5kr8hOtp2MBpWKg4zdb4Jeg& > e=3D > > > > Signed-off-by: Abner Chang > > > > Cc: Jaben Carsey > > Cc: Ray Ni > > Cc: Zhichao Gao > > Cc: Leif Lindholm > > Cc: Gilbert Chen > > --- > > .../SmbiosView/PrintInfo.c | 23 +++++++- > > .../SmbiosView/PrintInfo.h | 13 ++++- > > .../SmbiosView/QueryTable.c | 63 +++++++++++++= ++++++++- > > .../UefiShellDebug1CommandsLib.uni | 3 +- > > 4 files changed, 98 insertions(+), 4 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > index cfd7a2b..ff0c1db 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > @@ -3,7 +3,7 @@ > > > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<= BR> > > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > > LP
> > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development > > + LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > > break; > > > > // > > + // Processor Additional Information (Type 44) // case 44: > > + PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > > + PRINT_STRUCT_VALUE_H (Struct, Type44, > > ProcessorSpecificBlock.ProcessorArchType); > > + ProcessorArchitectureType (Struct->Type44- > > >ProcessorSpecificBlock.ProcessorArchType, Option); > > + break; > > + > > + // > > // Inactive (Type 126) > > // > > case 126: > > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > > Print (L"Video Processor\n"); > > break; > > > > + case 0x200: > > + Print (L"RISC-V RV32\n"); > > + break; > > + > > + case 0x201: > > + Print (L"RISC-V RV64\n"); > > + break; > > + > > + case 0x202: > > + Print (L"RISC-V RV128\n"); > > + break; > > + > > default: > > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > > gShellDebug1HiiHandle); > > } > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > index a8c32ab..22f59d6 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > @@ -2,7 +2,7 @@ > > Module to clarify the element info of the smbios structure. > > > > Copyright (c) 2005 - 2015, Intel Corporation. All rights > > reserved.
> > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development > > + LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( > > IN UINT8 Option > > ); > > > > +/** > > + Display Processor Architecture Type (Type 44). > > + > > + @param[in] Type The key of the structure. > > + @param[in] Option The optional information. > > +**/ > > +VOID > > +ProcessorArchitectureType ( > > + IN UINT8 Type, > > + IN UINT8 Option > > + ); > > #endif > > diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > index bfb7c3b..54e9a52 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > +++ c > > @@ -3,7 +3,7 @@ > > And give a interface of query a string out of a table. > > > > Copyright (c) 2005 - 2018, Intel Corporation. All rights > > reserved.
> > - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development > > LP
> > + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development > > + LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] =3D { > > { > > 7, > > L" Power/Performance Control" > > + }, > > + { > > + 8, > > + L" 128-bit Capable" > > } > > }; > > > > @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] =3D { > > }, > > }; > > > > +TABLE_ITEM ProcessorArchitectureTypesTable[] =3D { > > + { > > + 0, > > + L" Reserved " > > + }, > > + { > > + 1, > > + L" IA32 (x86) " > > + }, > > + { > > + 2, > > + L" x64 (x86-64, intel64, AMD64, EM64T) " > > + }, > > + { > > + 3, > > + L" Intel Itanium architecture " > > + }, > > + { > > + 4, > > + L" 32-bit ARM (Aarch32) " > > + }, > > + { > > + 5, > > + L" 64-bit ARM (Aarch64) " > > + }, > > + { > > + 6, > > + L" 32-bit RISC-V (RV32) " > > + }, > > + { > > + 7, > > + L" 64-bit RISC-V (RV64) " > > + }, > > + { > > + 8, > > + L" 128-bit RISC-V (RV128) " > > + } > > +}; > > > > TABLE_ITEM StructureTypeInfoTable[] =3D { > > { > > @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] =3D { > > L" TPM Device" > > }, > > { > > + 44, > > + L" Processor Additional Information" > > + }, > > + { > > 0x7E, > > L" Inactive" > > }, > > @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } > > > > /** > > + Display Processor Architecture Type (Type 44). > > + > > + @param[in] Type The key of the structure. > > + @param[in] Option The optional information. > > +**/ > > +VOID > > +ProcessorArchitectureType ( > > + IN UINT8 Type, > > + IN UINT8 Option > > + ) > > +{ > > + PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); } > > + > > +/** > > Display the structure type information. > > > > @param[in] Key The key of the structure. > > diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > index 42a9295..6693be2 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > d > > +++ sLib.uni > > @@ -2,7 +2,7 @@ > > // > > // Copyright (c) 2010 - 2018, Intel Corporation. All rights > > reserved.
// (C) Copyright 2013-2015 Hewlett-Packard Development > > Company, L.P.
-// > > (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> > +// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development > > +LP
> > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > @@ -976,6 +976,7 @@ > > " 41 - Onboard Devices Extended Information\r\n" > > " 42 - Management Controller Host Interface\r\n" > > " 43 - TPM Device\r\n" > > +" 44 - Processor Additional Information\r\n" > > " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" > > " Do not use the '0x' prefix format for hexadecimal values.\r\n" > > " 3. Internal commands:\r\n" > > -- > > 2.7.4 > > > > > >=20