Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h

["Abner Chang" <abner.chang@hpe.com>]

Hi Liming, any other concerns of this patch? If no , could we have this fix in edk2 master?

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Tuesday, November 12, 2019 1:36 PM
> To: devel@edk2.groups.io; liming.gao@intel.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing
> definitions of SMBIOS type 42h in SmBios.h
> 
> This definitions was defined in SMBIOS 3.2a and we miss to have the
> corresponding definition for this in SmBios.h.
> 
> Abner
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Liming Gao
> > Sent: Tuesday, November 12, 2019 12:43 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing
> > definitions of SMBIOS type 42h in SmBios.h
> >
> > Hi, is this a new definition in SmBios 3.3? Or is this a missing
> > definition in previous SmBios version?
> >
> > >-----Original Message-----
> > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > >Abner Chang
> > >Sent: Tuesday, November 12, 2019 10:56 AM
> > >To: devel@edk2.groups.io
> > >Cc: abner.chang@hpe.com; Kinney, Michael D
> > ><michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> > >Subject: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing
> > >definitions of SMBIOS type 42h in SmBios.h
> > >
> > >Add host interface Protocol Type Data Format structure in SmBios.h
> > >
> > >BZ link,
> > >INVALID URI REMOVED
> > >.org_show-5Fbug.cgi-3Fid-
> > 3D2328&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN
> >
> >6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=nqCVIRL9hVAaMUSX
> > QUQXjFwJWv39
> > >I6U90eR54obtRSM&s=p7ENdrSPY3KJNnhX8zR5S1D8ZkjtYzhhhe-ki9-
> > 2mTQ&e=
> > >
> > >Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >
> > >Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >Cc: Liming Gao <liming.gao@intel.com>
> > >Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >---
> > > MdePkg/Include/IndustryStandard/SmBios.h | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > >diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > >b/MdePkg/Include/IndustryStandard/SmBios.h
> > >index f504cc84e7..c0144c9c8f 100644
> > >--- a/MdePkg/Include/IndustryStandard/SmBios.h
> > >+++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > >@@ -2483,6 +2483,15 @@ typedef struct {
> > >   UINT8                             DevFuncNum;
> > > } SMBIOS_TABLE_TYPE41;
> > >
> > >+///
> > >+///  Management Controller Host Interface - Protocol Record Data
> Format.
> > >+///
> > >+typedef struct {
> > >+  UINT8                        ProtocolType;
> > >+  UINT8                        ProtocolTypeDataLen;
> > >+  UINT8                        ProtocolTypeData[1];
> > >+} MC_HOST_INTERFACE_PROTOCOL_RECORD;
> > >+
> > > ///
> > > /// Management Controller Host Interface - Interface Types.
> > > /// 00h - 3Fh: MCTP Host Interfaces
> > >--
> > >2.21.0.windows.1
> > >
> > >
> > >
> >
> >
> >
> 
> 
>