From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.6422.1574090193470767449 for ; Mon, 18 Nov 2019 07:16:33 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0225d594f7=abner.chang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAIFGOi0025426 for ; Mon, 18 Nov 2019 15:16:32 GMT Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0b-002e3701.pphosted.com with ESMTP id 2wbvhb0nqw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Nov 2019 15:16:32 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id A225710E for ; Mon, 18 Nov 2019 15:16:02 +0000 (UTC) Received: from G9W8669.americas.hpqcorp.net (16.220.49.28) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 18 Nov 2019 15:15:53 +0000 Received: from G4W10205.americas.hpqcorp.net (2002:10cf:520f::10cf:520f) by G9W8669.americas.hpqcorp.net (2002:10dc:311c::10dc:311c) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 18 Nov 2019 15:15:53 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (15.241.52.10) by G4W10205.americas.hpqcorp.net (16.207.82.15) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 18 Nov 2019 15:15:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZg1QuXQvSlg2ZhAZjxfMn5TjTPSe/bwXsyUxSx1WTznCwQZH0tMknE9M06EJ7EatWAq12c7+u7/em82lvuk5fOqKacC5Wb5tfX6g2KyjejRbxy1iQt/7i5VXrg2by8qxycWOURGBI+qnvSJ5jZ5xR2nYNMKcGjSW2sqzxOau4vOEKREEmvJ4KXuor6nWhQKLY9eW2a3G8rqp6kllHTYsbcNRQzqpinC4YmDxdKHO5/r//6JIC13A+oCCN9jG+DOnZUTpeyniOuW4fM8Az1e5jY3k2dqYNvBbfZy//dx95X3nBSAOZ6OckoSidpmlQlQ3ADQU8hQi1NT79ZqmTLAHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vDkIZpFaRgaThgGloi/s0XTzOSFmq6jw3LC5Xc27/6o=; b=j0YGN6bITmCbNLaQI+A2T9AihmuR49BnC3RL/TgQCwqFpmYgS6u/nBAExKDgcgNhjY9nB8KKFdFAi+vS3QAg9GyTmZ5eYnNR4wkDrPSYMepbB+SdQPJ1mkbIb8vzHRMSKLijyI3B8tfNP7H1EEhP55alF1A6RkoUVwBlJn0IoqXmA4i61i3pwGCyh6GFyntPLnDm25h4WwV5PIpCnMJcFg6R7tDBERk+oXYp4Ja8R35BaS7AiosGLPmky8sznd99IaU19QaUAVE5+qARQ/whzHo1UFvx7VSUbyrRpdnmxvPeT1hNEwRbMlkIWIuYltuM47eBKhq59g3xqJxF/sri/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0998.NAMPRD84.PROD.OUTLOOK.COM (10.169.96.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Mon, 18 Nov 2019 15:15:51 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b49a:cecb:54b0:29ac%7]) with mapi id 15.20.2451.029; Mon, 18 Nov 2019 15:15:51 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" , "liming.gao@intel.com" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h Thread-Topic: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h Thread-Index: AQHVmROkhFwgLd3RvkCr5JRAQ6u5eKeHATuAgAoSYGA= Date: Mon, 18 Nov 2019 15:15:51 +0000 Message-ID: References: <20191112025548.23632-1-abner.chang@hpe.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E53D0E9@SHSMSX104.ccr.corp.intel.com> <15D6538392FBC3E1.27853@groups.io> In-Reply-To: <15D6538392FBC3E1.27853@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e4e029ef-c13c-4e37-15df-08d76c3a331a x-ms-traffictypediagnostic: CS1PR8401MB0998: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-forefront-prvs: 0225B0D5BC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(136003)(39860400002)(366004)(396003)(346002)(376002)(189003)(199004)(13464003)(5660300002)(6436002)(7736002)(305945005)(86362001)(2501003)(102836004)(19627235002)(110136005)(26005)(316002)(6306002)(229853002)(55016002)(186003)(76116006)(74316002)(9686003)(81156014)(81166006)(6506007)(256004)(53546011)(6116002)(11346002)(446003)(3846002)(52536014)(45954011)(2906002)(25786009)(33656002)(99286004)(8936002)(8676002)(7696005)(66066001)(486006)(478600001)(966005)(71200400001)(6246003)(14454004)(476003)(76176011)(66946007)(64756008)(66556008)(66476007)(71190400001)(66446008)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0998;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TeCcqERyKjJ7Hu9cqMNURxqWVIjzKq0mewXviT8GNW4svunAOosj2n6+rntd+IQEMyTKDFehclq0BjOSzzr8+w34cE4Utst/RUv8wwL2nOLOixNMCB1pMArei843n23Vtz3SV2Xv8mp+EBw/lJPZ4dgwkHFk93GU+8BFIb1Z5iyqFHIONSO/ytTHuYSGchIWOwQ00IUDrNfE+5Znq5KC8A7kOkSixG3GOzKMKLaK9M22sYzd6fnu56Z2WSeFFvXV+Fh9GcVy8XZ/ALoF7+0HB/rTow12DPtbul5hWuQMgMss8KWIdgkHTsBHjMA6xxpcUprR4bSOr+E4xdSEH5mwoVaXn4/FUd/pmyuBCfqjsab7S58dQ1HjPqi77p/UiYTdgCLbhPlE7wAu4wAU+M13E9UBPK0b4KgSU8MDesvwhGo8g+Dl7Gnt/7LurYzaBIuD X-MS-Exchange-CrossTenant-Network-Message-Id: e4e029ef-c13c-4e37-15df-08d76c3a331a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2019 15:15:51.6325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sKp8hbBdJsTXg6eZ9PGXbp3MIjtewSgAAy9lIMYexSn8rF+IPii8JUU2QLChtjZbsaIGXf/LspUhKHQzENqxrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0998 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-18_03:2019-11-15,2019-11-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=854 suspectscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911180139 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, any other concerns of this patch? If no , could we have this fix= in edk2 master? Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Tuesday, November 12, 2019 1:36 PM > To: devel@edk2.groups.io; liming.gao@intel.com > Cc: Kinney, Michael D > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > definitions of SMBIOS type 42h in SmBios.h >=20 > This definitions was defined in SMBIOS 3.2a and we miss to have the > corresponding definition for this in SmBios.h. >=20 > Abner >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Liming Gao > > Sent: Tuesday, November 12, 2019 12:43 PM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Cc: Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > > definitions of SMBIOS type 42h in SmBios.h > > > > Hi, is this a new definition in SmBios 3.3? Or is this a missing > > definition in previous SmBios version? > > > > >-----Original Message----- > > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > >Abner Chang > > >Sent: Tuesday, November 12, 2019 10:56 AM > > >To: devel@edk2.groups.io > > >Cc: abner.chang@hpe.com; Kinney, Michael D > > >; Gao, Liming > > >Subject: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > > >definitions of SMBIOS type 42h in SmBios.h > > > > > >Add host interface Protocol Type Data Format structure in SmBios.h > > > > > >BZ link, > > >INVALID URI REMOVED > > >.org_show-5Fbug.cgi-3Fid- > > 3D2328&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN > > > >6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DnqCVIRL9hVAaMUSX > > QUQXjFwJWv39 > > >I6U90eR54obtRSM&s=3Dp7ENdrSPY3KJNnhX8zR5S1D8ZkjtYzhhhe-ki9- > > 2mTQ&e=3D > > > > > >Signed-off-by: Abner Chang > > > > > >Cc: Michael D Kinney > > >Cc: Liming Gao > > >Signed-off-by: Abner Chang > > >--- > > > MdePkg/Include/IndustryStandard/SmBios.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > >diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > > >b/MdePkg/Include/IndustryStandard/SmBios.h > > >index f504cc84e7..c0144c9c8f 100644 > > >--- a/MdePkg/Include/IndustryStandard/SmBios.h > > >+++ b/MdePkg/Include/IndustryStandard/SmBios.h > > >@@ -2483,6 +2483,15 @@ typedef struct { > > > UINT8 DevFuncNum; > > > } SMBIOS_TABLE_TYPE41; > > > > > >+/// > > >+/// Management Controller Host Interface - Protocol Record Data > Format. > > >+/// > > >+typedef struct { > > >+ UINT8 ProtocolType; > > >+ UINT8 ProtocolTypeDataLen; > > >+ UINT8 ProtocolTypeData[1]; > > >+} MC_HOST_INTERFACE_PROTOCOL_RECORD; > > >+ > > > /// > > > /// Management Controller Host Interface - Interface Types. > > > /// 00h - 3Fh: MCTP Host Interfaces > > >-- > > >2.21.0.windows.1 > > > > > > > > > > > > > > > >=20 >=20 >=20