From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=01658f8fdc=abner.chang@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Thu, 19 Sep 2019 00:14:43 -0700 Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8J7BXvo023394; Thu, 19 Sep 2019 07:14:42 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2v3vaqrq9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2019 07:14:42 +0000 Received: from G4W9119.americas.hpqcorp.net (g4w9119.houston.hp.com [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 59EBB66; Thu, 19 Sep 2019 07:14:41 +0000 (UTC) Received: from G2W6309.americas.hpqcorp.net (2002:10c5:4033::10c5:4033) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 19 Sep 2019 07:14:41 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6309.americas.hpqcorp.net (16.197.64.51) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 19 Sep 2019 07:14:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kflg7LtrFEL2U+14EP1rm2k4EVwUEQY5D/k5g4wdMbtWxs0sSrXLptYAT/7rVHYxZA0R1hoRIBVaXlN0RfovG/P10RAwLHUbls7C6AKDGc8ylKrgxLnTsG9tHbH9fvtVRzzCbI9P6j6oDmRtXWInKUZo+KhyTYF2093/vqsjujUL0N4A7VV62q3Hd4/4OKlblk3Csp/UK4j36qtDHePX1IbFJO84Q9/7/UKcZs7fZ63XhoiqAwR3oT6wd8qfqf9z77Pzd0yFtGKvbVfjYq1378IydshLBSc+2yx4htFC+fim3MkgT51Vzc2FM2JXNyc5zLQpBwsLQOUhRbhR1REypg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hcGV+3sVRQiA0pxmRSLkzDsDdIslvFaXQtnHkISCYGc=; b=BF1Xr3KhLEl/Q0/GmCCQoGQ5BmLqo8kW+IfHhYD4BwNLvVFJ2PYgzSrfqqASw3OFlL7sid3nu04pgkVfcurZD5hwWi/aOZ6WBoLQy1v02gSCbOnrmJALKQtn8uuSGrzM7+HSgUkKJLaA4sF5C7xgV2ezY0K9A+I4+DbskqZiGJEwuTPIZsgnjz/t3PIKC9NTTqMfiNEuOPVetsVhybVfKLMxZVPHeQZNUNcfczoMPbF7OEXFtFWArR1ZiAeQQmYDcreGtOsqUO5956ICcmDd4XSzjuJ+iYa6FIlIShnxTbTBMI1nr/DLv28aXdXOWAVHCmBnnc3JJn1NsNE0aYdN6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB1285.NAMPRD84.PROD.OUTLOOK.COM (10.169.14.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Thu, 19 Sep 2019 07:10:16 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2263.023; Thu, 19 Sep 2019 07:10:16 +0000 From: "Abner Chang" To: Leif Lindholm CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Thread-Index: AQHVYxHRPOsRAX9Yik6qFJwlOsfqcqcbzJ6AgBIHuvCAAibUAIACruFg Date: Thu, 19 Sep 2019 07:10:16 +0000 Message-ID: References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> <20190904175129.GO29255@bivouac.eciton.net> <20190917140318.GF28454@bivouac.eciton.net> In-Reply-To: <20190917140318.GF28454@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17f29c18-2969-4058-b641-08d73cd06c9b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:CS1PR8401MB1285; x-ms-traffictypediagnostic: CS1PR8401MB1285: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 016572D96D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(13464003)(189003)(199004)(498600001)(71200400001)(71190400001)(33656002)(2906002)(19627235002)(256004)(25786009)(14454004)(66476007)(76116006)(66946007)(8936002)(64756008)(66556008)(66446008)(86362001)(9686003)(14444005)(55016002)(81166006)(6436002)(16799955002)(6246003)(4326008)(66066001)(81156014)(8676002)(229853002)(6116002)(26005)(3846002)(102836004)(53546011)(6506007)(446003)(6916009)(5660300002)(11346002)(186003)(7736002)(486006)(305945005)(52536014)(99286004)(7696005)(76176011)(74316002)(476003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB1285;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ECkvgWoPLYftmZxWpNaVBjmmnAPvKwEx9og4+QWU1UC0tKeTTQvLTZgCLlrKbT21rCmtQeS7ms+lfgzvJipp3EiN/7AaLTHqtrHdW3nHaUGqvG7ag2KuQ+h+sW66k6T+9BJUyNEYFEel81AaJxX95RlXMmzfOwFwVEvIwccOgrxNJ3RaNLdVeD6zypeVMpA3Dcp2C84ql8NIKmRTlWSFcib/7JznftGiSWwIO4kL/rfPDLaueRrdVMCVrsfbbEBnTyw6FE7K+kJ9vhSDskQRJL7clg90Sp9upNX6s2N0jsAUzBTi3BbE17Qkxz6SzZ1aj4KnfQH/Pgmd0JaM3upsm4FSNmDIKWNXlX8WcxqwTaW90t3F5CilwUtgudCApq4M8li39MhjihPN5o/g/wWzAHNtRG/laZtHuqm9vBUlgrU= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 17f29c18-2969-4058-b641-08d73cd06c9b X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 07:10:16.8243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b/ua9J/VuV37hAiP5NxkSS18ctac3xESvJV4UcmPIDWAcwo14FAu2XRO3yz2JzrM6X/vxtvEAScp1SPV+9348w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1285 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-19_02:2019-09-18,2019-09-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909190067 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Tuesday, September 17, 2019 10:03 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > RiscVPkg: RISC-V processor package. >=20 > On Mon, Sep 16, 2019 at 05:15:08AM +0000, Chang, Abner (HPS SW/FW > Technologist) wrote: > > > -----Original Message----- > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > Sent: Thursday, September 5, 2019 1:51 AM > > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > > > RiscVPkg: RISC-V processor package. > > > > > > Hi Abner, > > > > > > On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote: > > > > - Add RiscVPkg package which provides RISC-V processor related > > > > drivers > > > and libraries. > > > > - Support RISC-V OpenSBI and RISC-V platforms > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: Abner Chang > > > > --- > > > > RiscVPkg/RiscVPkg.dec | 57 > > > +++++++++++++++++++++++++++++++++++++++++++++ > > > > RiscVPkg/RiscVPkg.uni | Bin 0 -> 1718 bytes > > > > RiscVPkg/RiscVPkgExtra.uni | Bin 0 -> 1374 bytes > > > > 3 files changed, 57 insertions(+) create mode 100644 > > > > RiscVPkg/RiscVPkg.dec create mode 100644 RiscVPkg/RiscVPkg.uni > > > > create mode 100644 RiscVPkg/RiscVPkgExtra.uni > > > > > > > > diff --git a/RiscVPkg/RiscVPkg.dec b/RiscVPkg/RiscVPkg.dec new > > > > file mode 100644 index 0000000..acf71fe > > > > --- /dev/null > > > > +++ b/RiscVPkg/RiscVPkg.dec > > > > @@ -0,0 +1,57 @@ > > > > +## @file RiscVPkg.dec > > > > +# This Package provides UEFI RISC-V modules and libraries. > > > > +# > > > > +# Copyright (c) 2016 - 2019, Hewlett Packard Enterprise > > > > +Development LP. All rights reserved.
# # This program and the > > > > +accompanying materials are licensed and made available under # > > > > +the terms and conditions of the BSD License which accompanies this > distribution. > > > > +# The full text of the license may be found at # INVALID URI > > > > +REMOVED > > > 3A__opensource.org_li > > > > +censes_bsd- > > > > 2Dlicense.php&d=3DDwIBAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN > > > > > > > > +4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3D1PSVwg69_Y8lpR9wdv1TN7 > > > kg2brsZYR > > > > +sj5F_hpyPrv4&s=3DUSJlvms7O9ZDAsM0U- > > > FGng8i0uJkAMNbDEp1S_C4p0A&e=3D > > > > +# > > > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS > IS" > > > > +BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > > > EITHER EXPRESS OR IMPLIED. > > > > +# > > > > +## > > > > + > > > > +[Defines] > > > > + DEC_SPECIFICATION =3D 0x00010005 > > > > + PACKAGE_NAME =3D RiscVPkg > > > > + PACKAGE_UNI_FILE =3D RiscVPkg.uni > > > > + PACKAGE_GUID =3D 993C7CAC-C87C-4F08-A2CF- > AD3AABA859D1 > > > > + PACKAGE_VERSION =3D 0.1 > > > > + > > > > +[Includes] > > > > + Include > > > > + opensbi/include > > > > + opensbi/lib/utils/libfdt > > > > > > This one is something we need to sort out (together). Having > > > multiple copies of libfdt in the tree is not on. > > > > > > I personally think we need a longer-term encapsulation of libfdt > > > that doesn't mess up the coding style. But until then, I would be > > > much happier if you used the half measure we have in EmbeddedPkg: > > > EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. > > > > We may not go this way due to everything is from OpenSBI and we don't > > want to maintain the difference to open source OpenSBI. Just take what > > OpenSBI provides. >=20 > If libfdt was a very quickly changing project, I might agree with you. > But it is not. It is a very simple piece of code that performs a small se= t of > operations on a very well defined structured encapsulation format. >=20 > So please use the one from EmbeddedPkg. On the very unlikely occurrence > that you require functionality not provided by the version in there, we c= an > update it. I am not sure how's compatibility between these two libraries. However I ca= n't agree to use EmbbedPkg one now, maybe later once this port is got on ed= k2 repo. Currently we just simply create an INF file and in which pull eve= rything OpenSBI provides, that is easy for us to integrate OpenSbi. We don'= t want to increase complexities now. I am not saying to not adopting Embbed= Pkg one, just not for now. >=20 > / > Leif