From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=01784fa02f=abner.chang@hpe.com) Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by groups.io with SMTP; Wed, 02 Oct 2019 09:14:13 -0700 Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x92G6V0S013303; Wed, 2 Oct 2019 16:14:11 GMT Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 2vck9km44f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Oct 2019 16:14:11 +0000 Received: from G4W9119.americas.hpqcorp.net (g4w9119.houston.hp.com [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 7E8449B; Wed, 2 Oct 2019 16:14:10 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 2 Oct 2019 16:14:10 +0000 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (15.241.52.11) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 2 Oct 2019 16:14:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M3pBFzohQjOat6KkMG5yztuTZgBdItHMaiWnTm0qvbg+iU8O/eb3DsY7DmjDqsfauqYsaScyG80FOT+xWI4ic07jXGs5L94TtOgJAzuS8/7b2wKuN0cZNGrDbmMhnznhomx0P6/dHepeqWVogZZbU210z+pMeUz7Oa3cNfuM2c+6ljb7Z/Z+Hef1m7KLpG19bqL3u21zG20Q/YrdrWCc9PEsZnOhqAdBQFusA6wYCSYEXJTUnDpG/FKW23VGvFFi2wROGP77BcPGifG9/xkWm8ajEwZjXZIg5ijlKbb04Ev10Az9T7WgywOD96efwwCGeOS0ZKjmWjasB/YeoYNsiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ABIInlhJuar+E87fjWGp3CMdghISlVkRXBOjDWUfqWk=; b=RkHrUq3anud7d2Sncn3+aQ9/2jnJejeuDk2JQQIALoa52+1YEdfq18PvraDLc63VNeFrmWuZO9JYy0EnY8SsDKrmsVYxtUHyrh7lNiCTvC/Gg+faYoxICUBnC+78q2YmXRzPDq6IB+vnBxmZdZxNOANpbyqAQfPAmRbx4sNFTlGb8x5giRGQwDFaCWjumJqNMhBJ72d6vo4qO5beaWbX4UaGNQ7NFmMr7G998k8TovhULcKrUTE0+yEyMeb2xas00IG2FtSN154q3E7hPRf8QsUcp07lr8b0Awr5UZe70I1Vsc3uH9PnzGdv6+NAiLJ702+1qRJhiLFFXdHHcAlzFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0469.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.18; Wed, 2 Oct 2019 16:14:09 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2305.023; Wed, 2 Oct 2019 16:14:08 +0000 From: "Abner Chang" To: Leif Lindholm CC: "devel@edk2.groups.io" , =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "Michael D Kinney" , Liming Gao Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Topic: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Thread-Index: AQHVcaqiBkSqxWRnL0+yEAnqc2QjJac+o/AAgAbjCwCAAAThAIABC+JggACILYCAAHF8wA== Date: Wed, 2 Oct 2019 16:14:08 +0000 Message-ID: References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com> <1569198715-31552-11-git-send-email-abner.chang@hpe.com> <20190926233928.GL25504@bivouac.eciton.net> <90c04adf-79b1-2d89-1683-c916444126c7@redhat.com> <20191001090705.GQ25504@bivouac.eciton.net> <20191002091317.GZ25504@bivouac.eciton.net> In-Reply-To: <20191002091317.GZ25504@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6fe9efb-6c8b-41db-6eaf-08d747538e32 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: CS1PR8401MB0469: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0178184651 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(396003)(136003)(346002)(39860400002)(366004)(376002)(199004)(189003)(13464003)(6506007)(99286004)(6246003)(33656002)(81166006)(7696005)(256004)(54906003)(71190400001)(8676002)(76176011)(81156014)(71200400001)(66946007)(74316002)(4326008)(305945005)(8936002)(7736002)(66446008)(6116002)(64756008)(446003)(11346002)(26005)(186003)(102836004)(3846002)(76116006)(476003)(486006)(66066001)(52536014)(229853002)(66476007)(53546011)(66556008)(14454004)(9686003)(2906002)(6916009)(55016002)(6436002)(316002)(25786009)(478600001)(5660300002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0469;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yKRL2ewpFDrBZQpwBmgQhUxbPeEem7Do0HMd6ZXuCJroZmR4loTXUrxUSehKXorVQFhwtKiyjeH8FAJ8ruIJt2wXDrqcWdeDu//2s/hde3Tq46W/sKg7M+kg2gBs0kIk9d5kkHVeFtIENKty3WGB+gvWyIznd+NtIgy1Ram8yb5FDURrn0eMQ3rUAKw3cKw/NYEHIXxz2c/KoBLcMldBolJSlea6Tmq3o109G+yByAkZq3mkVpCkyda+snRHPgyweUZNanLnl6RaB35eYHQ+X7zkiAMQVrilM0FP6EpJJmlFFuQ8biLnntbPdFJCy3noJfA2vOyKPkVMFRGoEKx4dNEBrywoptgVFtx9w55xSdtMCqQy2J0qnx4EGgtDF/g5/mxeWO3NIE6fcaf80r3FH8SgVS8vh6S2yhnm4OleEuo= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: d6fe9efb-6c8b-41db-6eaf-08d747538e32 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2019 16:14:08.8202 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kAI0JY5CYlXw8kWQzGOZZ0A9hQI1Ku4SGrWxkW6t/vcpHw/fNtLQIevIx4HffG2Z7cZLwhhmsnxA/NV9A8265A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0469 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-02_07:2019-10-01,2019-10-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 mlxlogscore=871 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910020142 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Thanks Leif, let me check with maintainers. Hi Mike and Liming, How do you think about to use IoLibArm as the I/O lib instance for RISC-V a= rch? I personally don't like to use IoLibArm.c in [Source.RISCV64] section,= instead I would like to use IoLibRiscV.c which conform with current source= file organization under BaseIoLibIntrinsics. What's your preference? Thanks Abner > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, October 2, 2019 5:13 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Philippe Mathieu-Daud=E9 > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] > MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. >=20 > On Wed, Oct 02, 2019 at 01:30:12AM +0000, Chang, Abner (HPS SW/FW > Technologist) wrote: > > > There should be exactly one variant of IoLib.c. Well, these days we > > > need a separate one for ARM/AARCH64 under hw virtualization. > > > > > > IoLibArm, IoLibEbc and IoLibRiscV have *exactly* the same requirement= s. > > > And now x86 uses NASM regardless of build platform, I think it would > > > make sense to move the contents of IoLibGcc and IoLibMsc into > assembler. > > > > That looks weird and doesn't make sense to use Arm code for RISC-V > > even the functionality is exactly the same to IoLibRiscV. I will still > > keep it as IoLibRiscV.c until there is a generic IoLib for different > > arch. >=20 > This is C code. It is no more weird to use "another architecture's" > code than it is to add another file doing exactly the same thing but > pretending it is "for" another architecture. >=20 > And one of those options does not pile up even more code duplication in t= he > tree. >=20 > But you are welcome to convince some other maintainer of the opposite. >=20 > / > Leif