From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A288321AE30D1 for ; Wed, 7 Jun 2017 08:34:46 -0700 (PDT) Received: from G4W9120.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id EFAC29D for ; Wed, 7 Jun 2017 15:35:53 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 7 Jun 2017 15:35:12 +0000 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Wed, 7 Jun 2017 15:35:11 +0000 Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.142) by CS1PR84MB0021.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Wed, 7 Jun 2017 15:35:09 +0000 Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) by CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) with mapi id 15.01.1157.012; Wed, 7 Jun 2017 15:35:09 +0000 From: "Shah, Tapan" To: "Carsey, Jaben" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion Thread-Index: AQHS3p8FvY0wpi4uv0yFy8KbBoSum6IXhMCAgADVC4CAAAMFAIAABn9wgAEmdbA= Date: Wed, 7 Jun 2017 15:35:09 +0000 Message-ID: References: <20170606082904.195040-1-ruiyu.ni@intel.com>, <734D49CCEBEEF84792F5B80ED585239D5B988FB6@SHSMSX104.ccr.corp.intel.com> <3DAAB008-D40F-48B1-B8AA-0F418CA19FE3@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.203.227.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CS1PR84MB0021; 7:Em0m9uhqOOnjkD0ovlQ07spPSV8bpTWKHbjKSiJqyJT6A53oNY5iof3LGGDw8O8aPngEYMSLuLvA0qzyqIA3PsCghZHbYMcvPpisNonakbS13tIUtKU192U1ypj+qSZWZyo0hyMNHOFJjFsa8y7XYRoJM6n9coazeEvt9xq0wAHaVhIYZz41tMuU6Oyy8wkNiU/HVCexsZtb8dc7dQ5eXULKaAk4iz5rvmFEcnzZkMk1/0TqqMDJPrb0a8oCT2pEbIeDfU6AjVeWTO62r1FFZIK+lnLLBL4s7ilybNv3J6woxrkOkDoUHcgHl4ozwT3Pbu5VTqaTeOPQjXMeXuev7g== x-ms-traffictypediagnostic: CS1PR84MB0021: x-ms-office365-filtering-correlation-id: bac9ffb7-d8fe-42e3-b5e1-08d4adbac7ed x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:CS1PR84MB0021; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CS1PR84MB0021; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CS1PR84MB0021; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39400400002)(39410400002)(39450400003)(39860400002)(13464003)(377454003)(2501003)(33656002)(81166006)(102836003)(6116002)(5660300001)(478600001)(3846002)(305945005)(2906002)(93886004)(86362001)(8936002)(25786009)(53546009)(7736002)(14454004)(7696004)(38730400002)(966005)(9686003)(6246003)(6306002)(55016002)(122556002)(189998001)(76176999)(50986999)(3280700002)(74316002)(229853002)(54356999)(77096006)(6436002)(53936002)(66066001)(6506006)(3660700001)(2900100001); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR84MB0021; H:CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2017 15:35:09.4286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0021 X-OriginatorOrg: hpe.com Subject: Re: [PATCH] ShellPkg/alias: Return status for alias deletion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 15:34:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Ray, I don't see your check-in includes the change I proposed below. =20 Tapan -----Original Message----- From: Shah, Tapan=20 Sent: Tuesday, June 06, 2017 5:03 PM To: 'Carsey, Jaben' ; Ni, Ruiyu ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletio= n Instead of using STR_GEN_ERR_UK here, it would be better to define a new s= tring token as "alias: '' does not exist." > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN=20 > >> + (STR_GEN_ERR_UK), > >> gShellLevel3HiiHandle, L"alias", Status); Reviewed-by: Tapan Shah -----Original Message----- From: Carsey, Jaben [mailto:jaben.carsey@intel.com] Sent: Tuesday, June 06, 2017 4:37 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Shah, Tapan Subject: RE: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletio= n I am good with more clear error information coming to the user. Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Tuesday, June 06, 2017 2:26 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tapan Shah ; Carsey, Jaben=20 > > Subject: Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias=20 > deletion > Importance: High >=20 > Including Jaben for review. >=20 > Send from mobile phone >=20 > > =1B$B:_=1B(B 2017=1B$BG/=1B(B6=1B$B7n=1B(B6=1B$BF|!$2<8a=1B(B4:43=1B$B!= $=1B(BNi, Ruiyu =1B$B > > > Including Tapan. > > > > Thanks/Ray > > > >> -----Original Message----- > >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 > >> Of > Ruiyu > >> Ni > >> Sent: Tuesday, June 6, 2017 4:29 PM > >> To: edk2-devel@lists.01.org > >> Subject: [edk2] [PATCH] ShellPkg/alias: Return status for alias=20 > >> deletion > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Ruiyu Ni > >> Cc: Tapan Shah > >> --- > >> ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c | 11=20 > >> ++++++++++- > >> 1 file changed, 10 insertions(+), 1 deletion(-) > >> > >> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> index 5a3b7e5913..7277bd4b90 100644 > >> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c > >> @@ -2,7 +2,7 @@ > >> Main file for Alias shell level 3 function. > >> > >> (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> >> - Copyright (c) 2009 - 2016, Intel Corporation. All rights=20 > >> reserved.
> >> + Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved. > >> +
> >> This program and the accompanying materials > >> are licensed and made available under the terms and conditions of=20 > >> the > BSD > >> License > >> which accompanies this distribution. The full text of the=20 > >> license may be > found > >> at @@ -151,6 +151,15 @@ ShellCommandRunAlias ( > >> // delete an alias > >> // > >> Status =3D gEfiShellProtocol->SetAlias(Param1, NULL, TRUE,=20 > >> FALSE); > >> + if (EFI_ERROR(Status)) { > >> + if (Status =3D=3D EFI_ACCESS_DENIED) { > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN=20 > >> + (STR_GEN_ERR_AD), > >> gShellLevel3HiiHandle, L"alias"); > >> + ShellStatus =3D SHELL_ACCESS_DENIED; > >> + } else { > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN=20 > >> + (STR_GEN_ERR_UK), > >> gShellLevel3HiiHandle, L"alias", Status); > >> + ShellStatus =3D SHELL_DEVICE_ERROR; > >> + } > >> + } > >> } else if (ShellCommandLineGetCount(Package) =3D=3D 3) { > >> // > >> // must be adding an alias > >> -- > >> 2.12.2.windows.2 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel