From: "Shah, Tapan" <tapandshah@hpe.com>
To: Rebecca Cran <rebecca@bluestop.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg
Date: Thu, 16 Feb 2017 22:59:37 +0000 [thread overview]
Message-ID: <CS1PR84MB0024BE62FFA81148070816A7D45A0@CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org>
UEFI Spec does not have old FMP image descriptor structures V1 and V2 defined.
MdePkg only follows the spec, so it contains the latest version # 3. But there are still drivers using old V1, V2 revisions and Shell 'dh' command needs to support decoding all revisions and needs to remain in ShellPkg.
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Rebecca Cran
Sent: Thursday, February 16, 2017 4:48 PM
To: edk2-devel@lists.01.org
Subject: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg
I'm a bit confused about why Firmware Management Protocol image descriptor structures are split between MdePkg and ShellPkg:
In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition of EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3). But then the
EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 struct definitions are in ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with some seemingly-unrelated stuff - and that file appears to have a ridiculous number of #include's!
Is there a reasoning behind putting the older structures in ShellPkg, or should they be moved to FirmwareInformation.h?
--
Rebecca
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-02-16 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 22:47 EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg Rebecca Cran
2017-02-16 22:58 ` Yao, Jiewen
2017-02-16 22:59 ` Shah, Tapan [this message]
2017-02-16 23:12 ` Yao, Jiewen
2017-02-17 15:42 ` Shah, Tapan
2017-02-17 16:03 ` Carsey, Jaben
2017-02-17 16:46 ` Shah, Tapan
2017-02-16 23:16 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR84MB0024BE62FFA81148070816A7D45A0@CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox