From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0708.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe4a::708]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10977820FE for ; Thu, 16 Feb 2017 14:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HPEnterprise.onmicrosoft.com; s=selector1-hpe-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ikPcATmJG3z+0tX7/LjtZHTVkcrCVvNXe1VkGxkN+58=; b=M9u/Sw67nA+e5KehPO0EmMXBIp7O91grE0CAHOBzT2XKoRF4NZw8JD2zlSjOAr4d5rHyhe7Y5OXzh9zQG833utOrs8TpHQERDkCZQ+QDeOtfMH5BwSFKu2tLhwH1TDRJ2GRcRGW+S7DS0P6F78HQwa/Dis+lQeQTZVVbSrpnmz4= Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.142) by CS1PR84MB0022.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Thu, 16 Feb 2017 22:59:37 +0000 Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) by CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) with mapi id 15.01.0919.013; Thu, 16 Feb 2017 22:59:37 +0000 From: "Shah, Tapan" To: Rebecca Cran , "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg Thread-Index: AQHSiKa2WPCt1iY9LkCol48OgScXA6FsPYpA Date: Thu, 16 Feb 2017 22:59:37 +0000 Message-ID: References: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> In-Reply-To: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tapandshah@hpe.com; x-originating-ip: [15.203.227.12] x-ms-office365-filtering-correlation-id: 7e9ba833-809b-400f-f6e3-08d456bf7b59 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:CS1PR84MB0022; x-microsoft-exchange-diagnostics: 1; CS1PR84MB0022; 7:RbMRub+Cumn6xwpITdGv9Fsesw9Atj05DtAg/A4USRqfPZmMSPvPXUg5VtrJrrSs9MY4WIx17iQwlBqzpoIdJka3nDCke9BLQFE0i/lwG5Z8B++Fe7z5rl5MZGKvVhZZiYYLsn3bO0Y4Fbhf5r6bcG5dFgDvpWiXelxm/L4frrYBtRg07mrXhDu9xbyl0AGLNbdZIeG87KDhr1VOI5QWD7rCTl4ErD88yi+zGkzTgzlYo1uAeUpwmj7Sz0X30RD6XpYmUuGl1RoK26podwJiExemc7BK9g0yjyklND7zaFmckUJDhWB3RJ3id86IZQjN3PLzxjssCWMfNxuJ8VjwwA== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558025)(20161123555025)(20161123560025)(6072148); SRVR:CS1PR84MB0022; BCL:0; PCL:0; RULEID:; SRVR:CS1PR84MB0022; x-forefront-prvs: 0220D4B98D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39850400002)(39840400002)(39410400002)(39860400002)(39450400003)(13464003)(377454003)(189002)(199003)(76176999)(101416001)(54356999)(50986999)(92566002)(68736007)(97736004)(5660300001)(33656002)(305945005)(74316002)(122556002)(7736002)(3846002)(6116002)(8676002)(66066001)(102836003)(81166006)(81156014)(229853002)(8936002)(6246003)(9686003)(106356001)(106116001)(2501003)(77096006)(86362001)(2950100002)(2900100001)(189998001)(2906002)(3660700001)(3280700002)(6306002)(55016002)(105586002)(6436002)(53936002)(38730400002)(6506006)(7696004)(53546006)(389900003); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR84MB0022; H:CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2017 22:59:37.1706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0022 Subject: Re: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 22:59:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable UEFI Spec does not have old FMP image descriptor structures V1 and V2 defin= ed. MdePkg only follows the spec, so it contains the latest version # 3. But th= ere are still drivers using old V1, V2 revisions and Shell 'dh' command nee= ds to support decoding all revisions and needs to remain in ShellPkg. =20 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Rebe= cca Cran Sent: Thursday, February 16, 2017 4:48 PM To: edk2-devel@lists.01.org Subject: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg I'm a bit confused about why Firmware Management Protocol image descriptor = structures are split between MdePkg and ShellPkg: In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition of = EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3). But then the EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 struc= t definitions are in ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsin= gLib.h along with some seemingly-unrelated stuff - and that file appears to= have a ridiculous number of #include's! Is there a reasoning behind putting the older structures in ShellPkg, or sh= ould they be moved to FirmwareInformation.h? --=20 Rebecca _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel