From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on072e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe45::72e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CD4882121 for ; Fri, 17 Feb 2017 08:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HPEnterprise.onmicrosoft.com; s=selector1-hpe-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aVITsTucu7En0xrjAgcMp/5M06cxxEEA2yMsVjyS4W4=; b=Xywrd7HLud7ikk8PPPyKmroMv50MHU6CUtkbf3lIpGQZXFeult4+bf7us117LsJYTxgYOa7zPjOl0cdzm2yO33ZrMviIwysxiyiGhlJRRE/BK9K5KQsgPWZMsZ3US3jz5zF8zEk7y29pN5Y1+t7sShz3Dli6wzJNMb+j7z4jtd0= Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.142) by CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Fri, 17 Feb 2017 16:46:59 +0000 Received: from CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) by CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM ([10.162.189.142]) with mapi id 15.01.0919.013; Fri, 17 Feb 2017 16:46:59 +0000 From: "Shah, Tapan" To: "Carsey, Jaben" , "Yao, Jiewen" , Rebecca Cran , "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg Thread-Index: AQHSiKa2WPCt1iY9LkCol48OgScXA6FsPYpAgAAFhACAARADgIAAClgAgAAL/6A= Date: Fri, 17 Feb 2017 16:46:59 +0000 Message-ID: References: <27f6c46b-aebe-a250-eb17-b93267c12a82@bluestop.org> <74D8A39837DF1E4DA445A8C0B3885C503A8EFF4F@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tapandshah@hpe.com; x-originating-ip: [15.203.227.12] x-ms-office365-filtering-correlation-id: e7676bb8-c373-4369-1390-08d45754977a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:CS1PR84MB0024; x-microsoft-exchange-diagnostics: 1; CS1PR84MB0024; 7:RoMHBa5S/pITA7y7jKK61KWQiUASuvlKVBub+9LWsTBPTGpE+mBC8gT0YFy/9TNgcVNy76x9yoX8ShrSTKH27oVPatZHv2A3i4+nBUI1YhaCTFkUV+0TMGnobdaTePlSKghO+QqA5LClaaGvabnUlyuOFpUTOM3cChEinKhZ8OIMPeUsYrm65dmzwjFSJakl93ivD7yLJDR06V15+FWZS2nQSigUS0qk9i6hdqsQMORy6JdPJ1tN9yYL/kaFwWa+wEDptiaH+WC9fLck53XW4R4+U3yyg36UccxEDJBxHH/7Ok3nTcLIswfUrmVXlSPy4Svw+yXxSZmRWdBlhM9ORA== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(21748063052155)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6042181)(6072148); SRVR:CS1PR84MB0024; BCL:0; PCL:0; RULEID:; SRVR:CS1PR84MB0024; x-forefront-prvs: 02213C82F8 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916002)(189002)(199003)(377454003)(13464003)(606005)(9686003)(8936002)(6436002)(6116002)(102836003)(3846002)(790700001)(81156014)(3660700001)(7696004)(189998001)(53546006)(97736004)(122556002)(2906002)(2501003)(3280700002)(54896002)(236005)(6306002)(86362001)(66066001)(5890100001)(55016002)(81166006)(68736007)(53936002)(76176999)(93886004)(54356999)(6246003)(229853002)(106116001)(77096006)(92566002)(101416001)(106356001)(6506006)(7906003)(8676002)(7736002)(105586002)(5660300001)(2950100002)(2900100001)(50986999)(38730400002)(74316002)(33656002); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR84MB0024; H:CS1PR84MB0024.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2017 16:46:59.4050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0024 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and ShellPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 16:47:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree on the number of includes in that header file. From: Carsey, Jaben [mailto:jaben.carsey@intel.com] Sent: Friday, February 17, 2017 10:03 AM To: Shah, Tapan ; Yao, Jiewen ; R= ebecca Cran ; edk2-devel@lists.01.org; Gao, Liming Cc: Carsey, Jaben Subject: RE: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and Shel= lPkg The reason for the structs is as Tapan said. The Shell must support all du= mps that customers require. The reason for the includes is that it needs to include each protocol that = it may dump. I agree that the number of includes looks insane. -Jaben From: Shah, Tapan [mailto:tapandshah@hpe.com] Sent: Friday, February 17, 2017 7:42 AM To: Yao, Jiewen >; Rebecc= a Cran >; edk2-devel@list= s.01.org; Gao, Liming >; Carsey, Jaben > Subject: RE: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and Shel= lPkg Importance: High There is no rule that says consumer of the code cannot define their own str= uctures (in this case UefiHandleParsingLib in ShellPkg needs to consume V1 = and V2). Having V1, V2 structures make it easy to decode the data in a stru= ctural way instead of hard-coded method to parse the data. Liming and Jaben agreed on this idea of having V1, V2 in UefiHandleParsingL= ib when we decided to add FMP V1,V2,V3 decode support in 'dh' command. See = attached old discussion on this agreement. From: Yao, Jiewen [mailto:jiewen.yao@intel.com] Sent: Thursday, February 16, 2017 5:13 PM To: Shah, Tapan >; Rebecca Cr= an >; edk2-devel@lists.01= .org; Gao, Liming > Subject: RE: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and Shel= lPkg Yes, I agree that SHELL pkg should dump V1 only and V2 only data structure. I just think there is no need to add new data structure there. The shell pkg can just skip LowestSupportedImageVersion in V1 and skip Last= AttemptVersion/ LastAttemptStatus/ HardwareInstance in V2. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sh= ah, > Tapan > Sent: Thursday, February 16, 2017 3:00 PM > To: Rebecca Cran >; edk= 2-devel@lists.01.org; Gao, Liming > > > Subject: Re: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and > ShellPkg > > UEFI Spec does not have old FMP image descriptor structures V1 and V2 def= ined. > > MdePkg only follows the spec, so it contains the latest version # 3. But = there are > still drivers using old V1, V2 revisions and Shell 'dh' command needs to = support > decoding all revisions and needs to remain in ShellPkg. > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Rebecca Cran > Sent: Thursday, February 16, 2017 4:48 PM > To: edk2-devel@lists.01.org > Subject: [edk2] EFI_FIRMWARE_IMAGE_DESCRIPTOR v1/v2/v3: MdePkg and > ShellPkg > > I'm a bit confused about why Firmware Management Protocol image descripto= r > structures are split between MdePkg and ShellPkg: > > In MdePkg/Include/Protocol/FirmwareInformation.h there's the definition o= f > EFI_FIRMWARE_IMAGE_DESCRIPTOR (version 3). But then the > EFI_FIRMWARE_IMAGE_DESCRIPTOR_V1 and > EFI_FIRMWARE_IMAGE_DESCRIPTOR_V2 struct definitions are in > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h along with s= ome > seemingly-unrelated stuff - and that file appears to have a ridiculous nu= mber of > #include's! > > > Is there a reasoning behind putting the older structures in ShellPkg, or = should > they be moved to FirmwareInformation.h? > > > -- > > Rebecca > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel