From: "Shia, Cinnamon" <cinnamon.shia@hpe.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Date: Mon, 14 Aug 2017 16:14:28 +0000 [thread overview]
Message-ID: <CS1PR84MB011988E9144CD118314C30BAF28C0@CS1PR84MB0119.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D77022C@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Cinnamon Shia <cinnamon.shia@hpe.com>
-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Shia, Cinnamon <cinnamon.shia@hpe.com>
Subject: RE: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 1/2] PerformancePkg DP: Init
>CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur
>displayed for custom cumulative data will be always 0, but not the real
>shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> PerformancePkg/Dp_App/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
>index 4cdc39edb42e..484ef2d50b80 100644
>--- a/PerformancePkg/Dp_App/Dp.c
>+++ b/PerformancePkg/Dp_App/Dp.c
>@@ -382,7 +382,7 @@ InitializeDp (
> if (CustomCumulativeToken != NULL) {
> CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
> ASSERT (CustomCumulativeData != NULL);
>- CustomCumulativeData->MinDur = 0;
>+ CustomCumulativeData->MinDur = PERF_MAXDUR;
> CustomCumulativeData->MaxDur = 0;
> CustomCumulativeData->Count = 0;
> CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1
next prev parent reply other threads:[~2017-08-14 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 8:35 [PATCH 0/2] DP: Init CustomCumulativeData.MinDur Star Zeng
2017-08-11 8:35 ` [PATCH 1/2] PerformancePkg " Star Zeng
2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon [this message]
2017-08-11 8:35 ` [PATCH 2/2] ShellPkg UefiDpLib: " Star Zeng
2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR84MB011988E9144CD118314C30BAF28C0@CS1PR84MB0119.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox