* [PATCH 0/2] DP: Init CustomCumulativeData.MinDur
@ 2017-08-11 8:35 Star Zeng
2017-08-11 8:35 ` [PATCH 1/2] PerformancePkg " Star Zeng
2017-08-11 8:35 ` [PATCH 2/2] ShellPkg UefiDpLib: " Star Zeng
0 siblings, 2 replies; 7+ messages in thread
From: Star Zeng @ 2017-08-11 8:35 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Liming Gao, Ruiyu Ni, Cinnamon Shia
Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
MinDur displayed for custom cumulative data will be always 0,
but not the real shortest duration.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Star Zeng (2):
PerformancePkg DP: Init CustomCumulativeData.MinDur
ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
PerformancePkg/Dp_App/Dp.c | 2 +-
ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
2017-08-11 8:35 [PATCH 0/2] DP: Init CustomCumulativeData.MinDur Star Zeng
@ 2017-08-11 8:35 ` Star Zeng
2017-08-14 6:59 ` Gao, Liming
2017-08-11 8:35 ` [PATCH 2/2] ShellPkg UefiDpLib: " Star Zeng
1 sibling, 1 reply; 7+ messages in thread
From: Star Zeng @ 2017-08-11 8:35 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Liming Gao, Cinnamon Shia
Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
MinDur displayed for custom cumulative data will be always 0,
but not the real shortest duration.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
PerformancePkg/Dp_App/Dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
index 4cdc39edb42e..484ef2d50b80 100644
--- a/PerformancePkg/Dp_App/Dp.c
+++ b/PerformancePkg/Dp_App/Dp.c
@@ -382,7 +382,7 @@ InitializeDp (
if (CustomCumulativeToken != NULL) {
CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
ASSERT (CustomCumulativeData != NULL);
- CustomCumulativeData->MinDur = 0;
+ CustomCumulativeData->MinDur = PERF_MAXDUR;
CustomCumulativeData->MaxDur = 0;
CustomCumulativeData->Count = 0;
CustomCumulativeData->Duration = 0;
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
2017-08-11 8:35 [PATCH 0/2] DP: Init CustomCumulativeData.MinDur Star Zeng
2017-08-11 8:35 ` [PATCH 1/2] PerformancePkg " Star Zeng
@ 2017-08-11 8:35 ` Star Zeng
2017-08-14 6:59 ` Gao, Liming
1 sibling, 1 reply; 7+ messages in thread
From: Star Zeng @ 2017-08-11 8:35 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Liming Gao, Ruiyu Ni, Cinnamon Shia
Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
MinDur displayed for custom cumulative data will be always 0,
but not the real shortest duration.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/Library/UefiDpLib/Dp.c
index 35ead751becc..94fa61c7108e 100644
--- a/ShellPkg/Library/UefiDpLib/Dp.c
+++ b/ShellPkg/Library/UefiDpLib/Dp.c
@@ -250,7 +250,7 @@ ShellCommandRunDp (
if (CustomCumulativeData == NULL) {
return SHELL_OUT_OF_RESOURCES;
}
- CustomCumulativeData->MinDur = 0;
+ CustomCumulativeData->MinDur = PERF_MAXDUR;
CustomCumulativeData->MaxDur = 0;
CustomCumulativeData->Count = 0;
CustomCumulativeData->Duration = 0;
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
2017-08-11 8:35 ` [PATCH 1/2] PerformancePkg " Star Zeng
@ 2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon
0 siblings, 1 reply; 7+ messages in thread
From: Gao, Liming @ 2017-08-14 6:59 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
>MinDur displayed for custom cumulative data will be always 0,
>but not the real shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> PerformancePkg/Dp_App/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
>index 4cdc39edb42e..484ef2d50b80 100644
>--- a/PerformancePkg/Dp_App/Dp.c
>+++ b/PerformancePkg/Dp_App/Dp.c
>@@ -382,7 +382,7 @@ InitializeDp (
> if (CustomCumulativeToken != NULL) {
> CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
> ASSERT (CustomCumulativeData != NULL);
>- CustomCumulativeData->MinDur = 0;
>+ CustomCumulativeData->MinDur = PERF_MAXDUR;
> CustomCumulativeData->MaxDur = 0;
> CustomCumulativeData->Count = 0;
> CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
2017-08-11 8:35 ` [PATCH 2/2] ShellPkg UefiDpLib: " Star Zeng
@ 2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon
0 siblings, 1 reply; 7+ messages in thread
From: Gao, Liming @ 2017-08-14 6:59 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Cinnamon Shia
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni,
>Ruiyu <ruiyu.ni@intel.com>; Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
>MinDur displayed for custom cumulative data will be always 0,
>but not the real shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/Library/UefiDpLib/Dp.c
>index 35ead751becc..94fa61c7108e 100644
>--- a/ShellPkg/Library/UefiDpLib/Dp.c
>+++ b/ShellPkg/Library/UefiDpLib/Dp.c
>@@ -250,7 +250,7 @@ ShellCommandRunDp (
> if (CustomCumulativeData == NULL) {
> return SHELL_OUT_OF_RESOURCES;
> }
>- CustomCumulativeData->MinDur = 0;
>+ CustomCumulativeData->MinDur = PERF_MAXDUR;
> CustomCumulativeData->MaxDur = 0;
> CustomCumulativeData->Count = 0;
> CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
2017-08-14 6:59 ` Gao, Liming
@ 2017-08-14 16:14 ` Shia, Cinnamon
0 siblings, 0 replies; 7+ messages in thread
From: Shia, Cinnamon @ 2017-08-14 16:14 UTC (permalink / raw)
To: Gao, Liming, Zeng, Star, edk2-devel@lists.01.org
Reviewed-by: Cinnamon Shia <cinnamon.shia@hpe.com>
-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Shia, Cinnamon <cinnamon.shia@hpe.com>
Subject: RE: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 1/2] PerformancePkg DP: Init
>CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur
>displayed for custom cumulative data will be always 0, but not the real
>shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> PerformancePkg/Dp_App/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
>index 4cdc39edb42e..484ef2d50b80 100644
>--- a/PerformancePkg/Dp_App/Dp.c
>+++ b/PerformancePkg/Dp_App/Dp.c
>@@ -382,7 +382,7 @@ InitializeDp (
> if (CustomCumulativeToken != NULL) {
> CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
> ASSERT (CustomCumulativeData != NULL);
>- CustomCumulativeData->MinDur = 0;
>+ CustomCumulativeData->MinDur = PERF_MAXDUR;
> CustomCumulativeData->MaxDur = 0;
> CustomCumulativeData->Count = 0;
> CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
2017-08-14 6:59 ` Gao, Liming
@ 2017-08-14 16:14 ` Shia, Cinnamon
0 siblings, 0 replies; 7+ messages in thread
From: Shia, Cinnamon @ 2017-08-14 16:14 UTC (permalink / raw)
To: Gao, Liming, Zeng, Star, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Reviewed-by: Cinnamon Shia <cinnamon.shia@hpe.com>
-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Shia, Cinnamon <cinnamon.shia@hpe.com>
Subject: RE: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Cinnamon Shia
><cinnamon.shia@hpe.com>
>Subject: [PATCH 2/2] ShellPkg UefiDpLib: Init
>CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur
>displayed for custom cumulative data will be always 0, but not the real
>shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/Library/UefiDpLib/Dp.c
>b/ShellPkg/Library/UefiDpLib/Dp.c index 35ead751becc..94fa61c7108e
>100644
>--- a/ShellPkg/Library/UefiDpLib/Dp.c
>+++ b/ShellPkg/Library/UefiDpLib/Dp.c
>@@ -250,7 +250,7 @@ ShellCommandRunDp (
> if (CustomCumulativeData == NULL) {
> return SHELL_OUT_OF_RESOURCES;
> }
>- CustomCumulativeData->MinDur = 0;
>+ CustomCumulativeData->MinDur = PERF_MAXDUR;
> CustomCumulativeData->MaxDur = 0;
> CustomCumulativeData->Count = 0;
> CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-14 16:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 8:35 [PATCH 0/2] DP: Init CustomCumulativeData.MinDur Star Zeng
2017-08-11 8:35 ` [PATCH 1/2] PerformancePkg " Star Zeng
2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon
2017-08-11 8:35 ` [PATCH 2/2] ShellPkg UefiDpLib: " Star Zeng
2017-08-14 6:59 ` Gao, Liming
2017-08-14 16:14 ` Shia, Cinnamon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox