* Sync staging/HTTPS-TLS feature into edk2 master!
@ 2016-12-04 6:46 Wu, Jiaxin
2016-12-04 19:36 ` Kinney, Michael D
0 siblings, 1 reply; 4+ messages in thread
From: Wu, Jiaxin @ 2016-12-04 6:46 UTC (permalink / raw)
To: edk2-devel-01, Zimmer, Vincent, Kinney, Michael D, Palmer Thomas,
Li, Ruth, Ye, Ting, Long, Qin, Fu, Siyuan
Cc: Wu, Jiaxin
Hi All,
I propose to sync the edk2-staging/HTTPS-TLS feature into edk2 master. Detailed feature description can be found @ https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS, including feature timeline, support scope and verifications.
If there is no objection, I will check in the patch before 5PM on Dec 16th, (UTC+08:00) Beijing Time. Please let me know if you have any concern about that.
Thanks and Best Regards!
Wu, Jiaxin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Sync staging/HTTPS-TLS feature into edk2 master!
2016-12-04 6:46 Sync staging/HTTPS-TLS feature into edk2 master! Wu, Jiaxin
@ 2016-12-04 19:36 ` Kinney, Michael D
2016-12-05 22:22 ` Palmer, Thomas
0 siblings, 1 reply; 4+ messages in thread
From: Kinney, Michael D @ 2016-12-04 19:36 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel-01, Zimmer, Vincent, Palmer Thomas,
Li, Ruth, Ye, Ting, Long, Qin, Fu, Siyuan, Kinney, Michael D
Wu, Jiaxin,
You still need to go through the standard EDK II patch review process. I know this may be a large feature that may not support the standard email patch review, but please, at a minimum, send a patch review email with a link to the edk2-staging branch and the summary of the changes, so everyone knows what packages/modules are impacted by this new feature. Will the actually commit to edk2/master be a single patch or is it broken up into a patch series? That should be in the summary as well.
Please Cc the developers that are required to do the review and response with Reviewed-by before Dec 16th so the feature can be added to edk2/master.
Thanks,
Mike
From: Wu, Jiaxin
Sent: Saturday, December 3, 2016 10:47 PM
To: edk2-devel-01 <edk2-devel@ml01.01.org>; Zimmer, Vincent <vincent.zimmer@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Palmer Thomas <thomas.palmer@hpe.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
Hi All,
I propose to sync the edk2-staging/HTTPS-TLS feature into edk2 master. Detailed feature description can be found @ https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS, including feature timeline, support scope and verifications.
If there is no objection, I will check in the patch before 5PM on Dec 16th, (UTC+08:00) Beijing Time. Please let me know if you have any concern about that.
Thanks and Best Regards!
Wu, Jiaxin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Sync staging/HTTPS-TLS feature into edk2 master!
2016-12-04 19:36 ` Kinney, Michael D
@ 2016-12-05 22:22 ` Palmer, Thomas
2016-12-06 0:40 ` Wu, Jiaxin
0 siblings, 1 reply; 4+ messages in thread
From: Palmer, Thomas @ 2016-12-05 22:22 UTC (permalink / raw)
To: Kinney, Michael D, Wu, Jiaxin, edk2-devel-01, Zimmer, Vincent,
Li, Ruth, Ye, Ting, Long, Qin, Fu, Siyuan
Besides formal EDK2 process, there are a couple more things to fix up for Linux/GCC compiles:
1) Need to remove no-pqueue from process_files.sh
2) In OpensslTlsLib.inf, GCC:*_*_*_CC_FLAGS = -Wno-unused-but-set-variable
I'm wondering also if the SSL library compilation in general needs more scrutiny ... EDK2 has a couple of files of scripts/patches for libcrypto ...
Regards,
Thomas Palmer
"I have only made this letter longer because I have not had the time to make it shorter" - Blaise Pascal
From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
Sent: Sunday, December 4, 2016 1:36 PM
To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel-01 <edk2-devel@ml01.01.org>; Zimmer, Vincent <vincent.zimmer@intel.com>; Palmer, Thomas <thomas.palmer@hpe.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
Wu, Jiaxin,
You still need to go through the standard EDK II patch review process. I know this may be a large feature that may not support the standard email patch review, but please, at a minimum, send a patch review email with a link to the edk2-staging branch and the summary of the changes, so everyone knows what packages/modules are impacted by this new feature. Will the actually commit to edk2/master be a single patch or is it broken up into a patch series? That should be in the summary as well.
Please Cc the developers that are required to do the review and response with Reviewed-by before Dec 16th so the feature can be added to edk2/master.
Thanks,
Mike
From: Wu, Jiaxin
Sent: Saturday, December 3, 2016 10:47 PM
To: edk2-devel-01 <edk2-devel@ml01.01.org<mailto:edk2-devel@ml01.01.org>>; Zimmer, Vincent <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Palmer Thomas <thomas.palmer@hpe.com<mailto:thomas.palmer@hpe.com>>; Li, Ruth <ruth.li@intel.com<mailto:ruth.li@intel.com>>; Ye, Ting <ting.ye@intel.com<mailto:ting.ye@intel.com>>; Long, Qin <qin.long@intel.com<mailto:qin.long@intel.com>>; Fu, Siyuan <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>
Cc: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
Subject: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
Hi All,
I propose to sync the edk2-staging/HTTPS-TLS feature into edk2 master. Detailed feature description can be found @ https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS, including feature timeline, support scope and verifications.
If there is no objection, I will check in the patch before 5PM on Dec 16th, (UTC+08:00) Beijing Time. Please let me know if you have any concern about that.
Thanks and Best Regards!
Wu, Jiaxin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Sync staging/HTTPS-TLS feature into edk2 master!
2016-12-05 22:22 ` Palmer, Thomas
@ 2016-12-06 0:40 ` Wu, Jiaxin
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Jiaxin @ 2016-12-06 0:40 UTC (permalink / raw)
To: Palmer, Thomas, Kinney, Michael D, edk2-devel-01, Zimmer, Vincent,
Li, Ruth, Ye, Ting, Long, Qin, Fu, Siyuan
Thanks Thomas and Mike,
I will refine the code first according your feedback, then following the EDK2 process by sending the series patches for the whole feature.
Best Regards!
Jiaxin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Palmer, Thomas
> Sent: Tuesday, December 6, 2016 6:23 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; edk2-devel-01 <edk2-devel@ml01.01.org>; Zimmer,
> Vincent <vincent.zimmer@intel.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting
> <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>
> Subject: Re: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
>
>
> Besides formal EDK2 process, there are a couple more things to fix up for
> Linux/GCC compiles:
>
> 1) Need to remove no-pqueue from process_files.sh
>
> 2) In OpensslTlsLib.inf, GCC:*_*_*_CC_FLAGS = -Wno-unused-but-set-
> variable
>
> I'm wondering also if the SSL library compilation in general needs more
> scrutiny ... EDK2 has a couple of files of scripts/patches for libcrypto ...
>
>
> Regards,
>
> Thomas Palmer
>
> "I have only made this letter longer because I have not had the time to make
> it shorter" - Blaise Pascal
>
> From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> Sent: Sunday, December 4, 2016 1:36 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel-01 <edk2-
> devel@ml01.01.org>; Zimmer, Vincent <vincent.zimmer@intel.com>; Palmer,
> Thomas <thomas.palmer@hpe.com>; Li, Ruth <ruth.li@intel.com>; Ye, Ting
> <ting.ye@intel.com>; Long, Qin <qin.long@intel.com>; Fu, Siyuan
> <siyuan.fu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
>
> Wu, Jiaxin,
>
> You still need to go through the standard EDK II patch review process. I know
> this may be a large feature that may not support the standard email patch
> review, but please, at a minimum, send a patch review email with a link to
> the edk2-staging branch and the summary of the changes, so everyone
> knows what packages/modules are impacted by this new feature. Will the
> actually commit to edk2/master be a single patch or is it broken up into a
> patch series? That should be in the summary as well.
>
> Please Cc the developers that are required to do the review and response
> with Reviewed-by before Dec 16th so the feature can be added to
> edk2/master.
>
> Thanks,
>
> Mike
>
> From: Wu, Jiaxin
> Sent: Saturday, December 3, 2016 10:47 PM
> To: edk2-devel-01 <edk2-devel@ml01.01.org<mailto:edk2-
> devel@ml01.01.org>>; Zimmer, Vincent
> <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Kinney,
> Michael D
> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>;
> Palmer Thomas
> <thomas.palmer@hpe.com<mailto:thomas.palmer@hpe.com>>; Li, Ruth
> <ruth.li@intel.com<mailto:ruth.li@intel.com>>; Ye, Ting
> <ting.ye@intel.com<mailto:ting.ye@intel.com>>; Long, Qin
> <qin.long@intel.com<mailto:qin.long@intel.com>>; Fu, Siyuan
> <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
> Subject: [edk2] Sync staging/HTTPS-TLS feature into edk2 master!
>
>
> Hi All,
>
>
>
> I propose to sync the edk2-staging/HTTPS-TLS feature into edk2 master.
> Detailed feature description can be found @
> https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS, including
> feature timeline, support scope and verifications.
>
>
>
> If there is no objection, I will check in the patch before 5PM on Dec 16th,
> (UTC+08:00) Beijing Time. Please let me know if you have any concern about
> that.
>
>
>
> Thanks and Best Regards!
>
> Wu, Jiaxin
>
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-06 0:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-04 6:46 Sync staging/HTTPS-TLS feature into edk2 master! Wu, Jiaxin
2016-12-04 19:36 ` Kinney, Michael D
2016-12-05 22:22 ` Palmer, Thomas
2016-12-06 0:40 ` Wu, Jiaxin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox