From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0705.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe44::705]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C46391A1E3B for ; Wed, 5 Oct 2016 09:02:28 -0700 (PDT) Received: from CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.151) by CS1PR84MB0230.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Wed, 5 Oct 2016 16:02:27 +0000 Received: from CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM ([10.162.190.151]) by CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM ([10.162.190.151]) with mapi id 15.01.0649.024; Wed, 5 Oct 2016 16:02:27 +0000 From: "Shah, Tapan" To: "Carsey, Jaben" , Supreeth Venkatesh , edk2-devel-01 CC: Leif Lindholm Thread-Topic: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform Thread-Index: AdIekL1EjMpAqwOYRWKk8YKyvfLMLgAjbAlwAACkBtA= Date: Wed, 5 Oct 2016 16:02:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tapandshah@hpe.com; x-originating-ip: [15.203.227.10] x-ms-office365-filtering-correlation-id: ab576e00-2b30-41ad-037a-08d3ed3900e8 x-microsoft-exchange-diagnostics: 1; CS1PR84MB0230; 7:YTUxADTKZJxk1OlHLKG2dZ9x9fsDvJylWC1sOT+gcwbJDYGGoQd4nO+7Srg3uKV1PqAvRVL/UWNopSNAevsvqEspzObjMDMFjKgc8G1zSKB2rMDD7l9jdV1tSqlVNp7xrv7Iued9pH4IS1B4ogsFaU7KYniokBcRu4IBVNqehEMrWdfpColXoUWeuVFwdszWX3jW52k2Szo1E0pWkJeHi5gnZqU+48oeXFunEAFiZMlKafWeC3JtjB41bkpilDvTF2N1f1sQygHVFsKKLOWxrUKtc1mfvKxJ+CEvcwYAw+HNl/ZWxU9jr695WCsVHAj4tQr8ZwlNT7wHHA1XOMiDkw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0230; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(180628864354917)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:CS1PR84MB0230; BCL:0; PCL:0; RULEID:; SRVR:CS1PR84MB0230; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(377454003)(189002)(13464003)(99286002)(5890100001)(81156014)(77096005)(5001770100001)(97736004)(106356001)(3660700001)(2900100001)(3280700002)(5660300001)(305945005)(87936001)(8676002)(19580395003)(10400500002)(74316002)(19580405001)(4326007)(105586002)(33656002)(81166006)(15975445007)(66066001)(189998001)(2906002)(7736002)(8936002)(92566002)(2950100002)(5002640100001)(3846002)(6116002)(76176999)(50986999)(54356999)(11100500001)(86362001)(9686002)(7846002)(68736007)(101416001)(7696004)(586003)(102836003)(122556002)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR84MB0230; H:CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2016 16:02:27.1824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0230 Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 16:02:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's possible. But I think gEfiUnicodeCollation2ProtocolGuid protocol is ne= cessary for even other Shell libraries other than UefiShellLib in order to = have Shell parser and other command line processing to work properly. That'= s why I added ASSERT if UefiShellLib fails to locate the protocol. =20 Reference platform should have EnglishDxe module to have this protocol inst= alled properly. MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf -----Original Message----- From: Carsey, Jaben [mailto:jaben.carsey@intel.com]=20 Sent: Wednesday, October 05, 2016 10:41 AM To: Supreeth Venkatesh ; edk2-devel-01 ; Shah, Tapan Cc: Leif Lindholm ; Carsey, Jaben Subject: RE: Assert in ShellPkg with latest tianocore edk2 source on the Re= ference Platform Tapan, Could this be a side effect of your patch? Should we allow the UefiShellLi= b to continue without this protocol and then return an error only when the = OpenFile is called? Also, it looks like we never properly initialize mUnicodeCollationProtocol.= We check for NULL in Constructor, but nothing else... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Supreeth Venkatesh > Sent: Tuesday, October 04, 2016 3:51 PM > To: edk2-devel-01 > Cc: Leif Lindholm > Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source=20 > on the Reference Platform > Importance: High >=20 > All, >=20 > Recently, I updated to latest edk2 master (yesterday's) and I am=20 > actually encountering assert in=20 > ShellPkg/Library/UefiShellLib/UefiShellLib.c >=20 > if (mUnicodeCollationProtocol =3D=3D NULL) { > Status =3D gBS->LocateProtocol (&gEfiUnicodeCollation2ProtocolGuid,=20 > NULL, (VOID**)&mUnicodeCollationProtocol); > ASSERT_EFI_ERROR (Status); > } >=20 > It was working few weeks back and has now stopped working. > It's probably because the platform is unable to locate this protocol=20 > "UnicodeCollationProtocol". > Is Anyone else facing the same issue? > Does the new ShellPkg requires additional packages/infs to be included=20 > in the platform description file to work with latest changes to get=20 > past this error? >=20 > Thanks, > Supreeth > IMPORTANT NOTICE: The contents of this email and any attachments are=20 > confidential and may also be privileged. If you are not the intended=20 > recipient, please notify the sender immediately and do not disclose=20 > the contents to any other person, use it for any purpose, or store or=20 > copy the information in any medium. Thank you. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel