From: "Shah, Tapan" <tapandshah@hpe.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
Subject: Re: [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"
Date: Thu, 8 Sep 2016 17:09:49 +0000 [thread overview]
Message-ID: <CS1PR84MB02297F78270E55CC1EEC4EDCD4FB0@CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: 20160908161414.3143-1-lersek@redhat.com
Typo..... Missing company's copyright message in both changed files*
-----Original Message-----
From: Shah, Tapan
Sent: Thursday, September 08, 2016 12:09 PM
To: 'Laszlo Ersek' <lersek@redhat.com>; edk2-devel@ml01.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>
Subject: RE: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"
Missing company's copyright message in both changed filed. Code works fine on NT32.
Reviewed-by: Tapan Shah <tapandshah@hpe.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Thursday, September 08, 2016 11:14 AM
To: edk2-devel@ml01.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>
Subject: [edk2] [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v"
Tapan reported
<https://tianocore.acgmultimedia.com/show_bug.cgi?id=112>. Since I had encountered the problem myself, and now managed to find a tiny time slot, I looked into it. Patch #2 is the fix; patch #1 cleans up a small wart that I came across while studying the code.
Public branch: <https://github.com/lersek/edk2/commits/childctrl>.
Tapan, can you please test the series, and respond with your Tested-by?
Thanks!
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Tapan Shah <tapandshah@hpe.com>
Cheers,
Laszlo
Laszlo Ersek (2):
ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr
parsing
ShellPkg/UefiHandleParsingLib: fix retval for empty child controller
array
ShellPkg/Include/Library/HandleParsingLib.h | 4 ++--
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 15 +++++++++++----
2 files changed, 13 insertions(+), 6 deletions(-)
--
2.9.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-09-08 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 16:14 [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" Laszlo Ersek
2016-09-08 16:14 ` [PATCH 1/2] ShellPkg/UefiHandleParsingLib: fix IN/OUT notation in child ctrlr parsing Laszlo Ersek
2016-09-08 16:14 ` [PATCH 2/2] ShellPkg/UefiHandleParsingLib: fix retval for empty child controller array Laszlo Ersek
2016-09-08 16:37 ` [PATCH 0/2] ShellPkg: fix assertion failure encountered with "devtree" and "dh -d -v" Carsey, Jaben
2016-09-08 17:08 ` Shah, Tapan
2016-09-08 17:09 ` Shah, Tapan [this message]
2016-09-08 18:35 ` Laszlo Ersek
2016-09-08 18:46 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR84MB02297F78270E55CC1EEC4EDCD4FB0@CS1PR84MB0229.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox