public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wang, Sunny (HPS SW)" <sunnywang@hpe.com>,
	"Haskell, Darrell" <darrell.haskell@hpe.com>
Subject: Re: [PATCH v2 0/9] Defer 3rd party images loading to after EndOfDxe
Date: Thu, 10 Nov 2016 05:56:38 +0000	[thread overview]
Message-ID: <CS1PR84MB029565D1FC60B6B8D3C062B7A8B80@CS1PR84MB0295.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20161108122928.53984-1-ruiyu.ni@intel.com>

Reviewed all BDS related patches including PlatformBds libraries. All look good to me.  
Thanks for offline addressing my PlatformBds related questions.

Reviewed-by: Sunny Wang <sunnywang@hpe.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, November 08, 2016 8:29 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 0/9] Defer 3rd party images loading to after EndOfDxe

The patches change the default image loading policy by deferring 3rd party images loading to after EndOfDxe and add a new BDS API to dispatch the deferred images.

Platform needs to call the new BDS API
EfiBootManagerDispatchDeferredImages after EndOfDxe to ensure that any deferred images are loaded.

v2 puts the deferred images checking in DEBUG_CODE macro, corrects a typo of function name, and puts CpuDeadLoop() after ASSERT(FALSE).
v2 includes all the platform changes.

Ruiyu Ni (9):
  MdeModulePkg/SecurityStubDxe: Defer 3rd party image before EndOfDxe
  MdeModulePkg/UefiBootManager: Add EfiBootManagerDispatchDeferredImages
  MdeModulePkg/BdsDxe: Check deferred images before booting to OS
  MdeModulePkg/SecurityStubDxe: Report failure if image is load earlier
  ArmVirPkg/PlatformBds: Dispatch deferred images after EndOfDxe
  OvmfPkg/PlatformBds: Dispatch deferred images after EndOfDxe
  CorebootPayload/PlatformBds: Dispatch deferred images after EndOfDxe
  QuarkPlatformPkg/PlatformBds: Dispatch deferred images after EndOfDxe
  Nt32Pkg/PlatformBds: Dispatch deferred images after EndOfDxe

 .../Library/PlatformBootManagerLib/PlatformBm.c    |   5 +
 .../PlatformBootManagerLib/PlatformBootManager.c   |   5 +
 MdeModulePkg/Include/Library/UefiBootManagerLib.h  |  13 +
 MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c   | 113 ++++++
 .../Library/UefiBootManagerLib/InternalBm.h        |   1 +
 .../UefiBootManagerLib/UefiBootManagerLib.inf      |   1 +
 MdeModulePkg/Universal/BdsDxe/Bds.h                |   4 +-
 MdeModulePkg/Universal/BdsDxe/BdsDxe.inf           |   2 +
 MdeModulePkg/Universal/BdsDxe/BdsEntry.c           |  90 +++++
 .../SecurityStubDxe/Defer3rdPartyImageLoad.c       | 414 +++++++++++++++++++++
 .../SecurityStubDxe/Defer3rdPartyImageLoad.h       |  95 +++++
 .../Universal/SecurityStubDxe/SecurityStub.c       |  14 +-
 .../Universal/SecurityStubDxe/SecurityStubDxe.inf  |  11 +-
 .../PlatformBootManagerLib/PlatformBootManager.c   |   5 +
 .../Library/PlatformBootManagerLib/BdsPlatform.c   |   5 +
 .../PlatformBootManagerLib/PlatformBootManager.c   |   7 +-
 16 files changed, 781 insertions(+), 4 deletions(-)  create mode 100644 MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c
 create mode 100644 MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.h

--
2.9.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2016-11-10  5:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 12:29 [PATCH v2 0/9] Defer 3rd party images loading to after EndOfDxe Ruiyu Ni
2016-11-08 12:29 ` [PATCH v2 1/9] MdeModulePkg/SecurityStubDxe: Defer 3rd party image before EndOfDxe Ruiyu Ni
2016-11-10  7:24   ` Gao, Liming
2016-11-08 12:29 ` [PATCH v2 2/9] MdeModulePkg/UefiBootManager: Add EfiBootManagerDispatchDeferredImages Ruiyu Ni
2016-11-08 14:11   ` Zhang, Chao B
2016-11-10  5:52   ` Wang, Sunny (HPS SW)
2016-11-10  6:01   ` Gao, Liming
2016-11-08 12:29 ` [PATCH v2 3/9] MdeModulePkg/BdsDxe: Check deferred images before booting to OS Ruiyu Ni
2016-11-08 14:08   ` Zhang, Chao B
2016-11-10  5:50   ` Wang, Sunny (HPS SW)
2016-11-10  6:01   ` Gao, Liming
2016-11-08 12:29 ` [PATCH v2 4/9] MdeModulePkg/SecurityStubDxe: Report failure if image is load earlier Ruiyu Ni
2016-11-08 12:29 ` [PATCH v2 5/9] ArmVirPkg/PlatformBds: Dispatch deferred images after EndOfDxe Ruiyu Ni
2016-11-08 12:57   ` Laszlo Ersek
2016-11-08 12:29 ` [PATCH v2 6/9] OvmfPkg/PlatformBds: " Ruiyu Ni
2016-11-08 13:04   ` Laszlo Ersek
2016-11-11 11:16     ` Laszlo Ersek
2016-11-11 11:24       ` Ni, Ruiyu
2016-11-08 12:29 ` [PATCH v2 7/9] CorebootPayload/PlatformBds: " Ruiyu Ni
2016-11-09  0:13   ` Ma, Maurice
2016-11-08 12:29 ` [PATCH v2 8/9] QuarkPlatformPkg/PlatformBds: " Ruiyu Ni
2016-11-08 15:39   ` Kinney, Michael D
2016-11-08 12:29 ` [PATCH v2 9/9] Nt32Pkg/PlatformBds: " Ruiyu Ni
2016-11-09  6:55   ` Dong, Eric
2016-11-10  5:56 ` Wang, Sunny (HPS SW) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR84MB029565D1FC60B6B8D3C062B7A8B80@CS1PR84MB0295.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox