From: "Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
Subject: Re: [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile
Date: Thu, 1 Sep 2016 02:22:09 +0000 [thread overview]
Message-ID: <CS1PR84MB02956FA30F6DA7040CCE4D8BA8E20@CS1PR84MB0295.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B3E0FEB@shsmsx102.ccr.corp.intel.com>
Got it. Thanks for confirming this and working on the replacement.
Regards,
Sunny Wang
-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Thursday, September 01, 2016 10:20 AM
To: Wang, Sunny (HPS SW) <sunnywang@hpe.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile
Importance: High
Sunny:
Yes. This is the replacement of Eric patch.
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Wang, Sunny (HPS SW)
> Sent: Thursday, September 01, 2016 10:18 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore
> BootManagerMenuApp from LoadFile
>
> Hi Liming,
> Except Ray's comment, others Look good to me.
> Reviewed-by: Sunny Wang <sunnywang@hpe.com>
>
> Hi Ray and Eric,
> It looks like this code change is used for replacing the one which we
> offline discussed to fix the duplicated Boot Manager menu issue, isn't it?
> - [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Add OptioalData for
> boot option.
>
> Regards,
> Sunny Wang
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Wednesday, August 31, 2016 4:19 PM
> To: edk2-devel@lists.01.org
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>; Eric Dong <eric.dong@intel.com>
> Subject: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore
> BootManagerMenuApp from LoadFile
>
> BootManagerMenuApp boot option is handled by
> EfiBootManagerGetBootManagerMenu.
> Don't need to handle it again when parse LoadFile protocol.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 17 +++++++-------
> ---
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index ecd0ae3..f8a3988 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -1940,7 +1940,6 @@ BmEnumerateBootOptions (
> UINTN Removable;
> UINTN Index;
> CHAR16 *Description;
> - UINT32 BootAttributes;
>
> ASSERT (BootOptionCount != NULL);
>
> @@ -2070,6 +2069,12 @@ BmEnumerateBootOptions (
> &Handles
> );
> for (Index = 0; Index < HandleCount; Index++) {
> + //
> + // Ignore BootMenuApp. its boot option will be created by
> BmRegisterBootManagerMenu().
> + //
> + if (BmIsBootMenuAppFilePath (DevicePathFromHandle
> + (Handles[Index])))
> {
> + continue;
> + }
>
> Description = BmGetBootDescription (Handles[Index]);
> BootOptions = ReallocatePool (
> @@ -2079,19 +2084,11 @@ BmEnumerateBootOptions (
> );
> ASSERT (BootOptions != NULL);
>
> - //
> - // If LoadFile includes BootMenuApp, its boot attribue will be set to APP
> and HIDDEN.
> - //
> - BootAttributes = LOAD_OPTION_ACTIVE;
> - if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index])))
> {
> - BootAttributes = LOAD_OPTION_CATEGORY_APP |
> LOAD_OPTION_ACTIVE | LOAD_OPTION_HIDDEN;
> - }
> -
> Status = EfiBootManagerInitializeLoadOption (
> &BootOptions[(*BootOptionCount)++],
> LoadOptionNumberUnassigned,
> LoadOptionTypeBoot,
> - BootAttributes,
> + LOAD_OPTION_ACTIVE,
> Description,
> DevicePathFromHandle (Handles[Index]),
> NULL,
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-01 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 8:19 [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile Liming Gao
2016-09-01 2:02 ` Ni, Ruiyu
2016-09-01 2:12 ` Gao, Liming
2016-09-01 2:18 ` Wang, Sunny (HPS SW)
2016-09-01 2:20 ` Gao, Liming
2016-09-01 2:22 ` Wang, Sunny (HPS SW) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR84MB02956FA30F6DA7040CCE4D8BA8E20@CS1PR84MB0295.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox