From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c05::22f; helo=mail-pg0-x22f.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg0-x22f.google.com (mail-pg0-x22f.google.com [IPv6:2607:f8b0:400e:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC0EC21CF1CF3 for ; Mon, 12 Feb 2018 16:54:03 -0800 (PST) Received: by mail-pg0-x22f.google.com with SMTP id a11so8703190pgu.13 for ; Mon, 12 Feb 2018 16:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=LB2FunI6tKy3mUUoQz4Ty3SoPxIIY/8IxlveLds6s2k=; b=d2ZMYEgJ3HOeqAve7VZDUsUVdy1YxC47p1Mm3gBb2WeSx/cSVDEn/752tMI6sHms5f yF2sr6zHPIHLndCtXGkP0NsGEjTn3fdj9mKQ07sZUKUKMGHnaDd5GCXzG7NCBcAEztz4 XataKAO1v9ighhsLDYkWHOPr2SW08egGmUAIc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=LB2FunI6tKy3mUUoQz4Ty3SoPxIIY/8IxlveLds6s2k=; b=t0SU5Jabye/iZayXJha1QYBZKZaxvCBXrdrPA5V4CLo0R2g7ezdxfJdKRkZzzAbC51 T/BbPo9g7P7rFbjUoLR5nVSPwckuLlV0K8DdpY2ytS8gin4+SGWanusjf4FBlr2a967v ekdxEY2sPAgQFwew8/iMzsollaLuptfh4N4H6rlrheqEDV/mn8DpRI+Z64yjXtfPNmnP OUpEqjaX1lO3KQZrxUQb3hIVCoCToz/XLRSob2n+gbaNg7PlNp0gVLaxH2k0G5RBnZUw NtBLTg7y1Z+iYgXJNLkgZp+yBSoa1l/reHaSFhuieiNCllcK2ntFR8ZmNS9rvIIPL02G mZnA== X-Gm-Message-State: APf1xPAu6VczddaiyInkWINmtL/CqCToISMq9YfExJ07bo+W9ykMu+Eg XOKaTNxGdrCIU14SHvCzJ2+/ODN2ZWU= X-Google-Smtp-Source: AH8x225HT2Qsf62xaIPYBhebxFpsv5YV2VSq6XQJ44nMWdin/4gZRSThKga81xFSKmeKueTdwofIBg== X-Received: by 10.99.67.197 with SMTP id q188mr10397236pga.255.1518483593222; Mon, 12 Feb 2018 16:59:53 -0800 (PST) Received: from CY1PR15MB0730.namprd15.prod.outlook.com ([132.245.253.237]) by smtp.gmail.com with ESMTPSA id y22sm29492756pfd.9.2018.02.12.16.59.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Feb 2018 16:59:52 -0800 (PST) From: Haojian Zhuang To: Guo Heyi , Haojian Zhuang CC: "edk2-devel@lists.01.org" , "linaro-uefi@lists.linaro.org" , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file Thread-Index: AQHTocvf6rQiVfNvrkKm7rrjsKoICaOhfgyAgAAJC1k= X-MS-Exchange-MessageSentRepresentingType: 2 Date: Tue, 13 Feb 2018 00:59:50 +0000 Message-ID: References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org>, <20180213002307.GA10678@SZX1000114654> In-Reply-To: <20180213002307.GA10678@SZX1000114654> Accept-Language: en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 MIME-Version: 1.0 Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 00:54:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On 02/13/2018 08:23 AM, Guo Heyi wrote:=0A= > Hi Haojian,=0A= > =0A= > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if the= re=0A= > isn't such device on Hikey, then you can't use this library instance inde= ed.=0A= > =0A= > But I think PeiDxeDebugLibReportStatusCode should be some common code, ho= wever=0A= > it depends on ReportStatusCodeLib and Status Code PEIM and Status code DX= E=0A= > driver. Have you added them too?=0A= >=0A= If I leave PeiDxeDebugLibReportStatusCode and move Dw8250SerialPortRuntimeL= ib out,=0A= I'll meet UEFI crash. It seems the debug lib is depended on serial port lib= .=0A= =0A= And I consider that Dw8250 serial port is only valid on D02. So I decide to= move them out.=0A= =0A= Best Regards=0A= Haojian=