From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c05::22a; helo=mail-pg0-x22a.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg0-x22a.google.com (mail-pg0-x22a.google.com [IPv6:2607:f8b0:400e:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AECCF222DE15E for ; Mon, 12 Feb 2018 04:51:30 -0800 (PST) Received: by mail-pg0-x22a.google.com with SMTP id u1so7462984pgr.0 for ; Mon, 12 Feb 2018 04:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=Rs/97DTqHvSb8dR+CkuAKBw/WiyOGrJ0UlpP6nKIefY=; b=fWEX7b1yy5wDO2l1iR2tf9TTReFq2abF5ZkQp2cgv2PgR8RjD3xK0YBJf29UIYM5vU 4oQy3axZA5y4G4l3OnbA2IAtMVr7ZXww7SJGJ+RGLhfOHMenKjSWm2OCXn9T9LsASG0o DKp1FwzRnaBOZTGy6KNJIS+e64reWbgu3nisw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=Rs/97DTqHvSb8dR+CkuAKBw/WiyOGrJ0UlpP6nKIefY=; b=pasztKxYeFKCeprid3xWDUc9k3mH8moir0ZWh0y8E00NxCexjaeppsqKceePLpPceP SGNVgk2iHw+ihXnVJhuUDKZIYQzJtz6nz+LUtHxnkoUapHVsieU+HhOdUXgQ5o6I77KG JPSm2jRUOhjm3+5x8ynXokx1oSJEydNcFUq98i/1sTaCLuEL0yYo3GEBnBBKrtWcLe42 1Wk4CMFeXq2EUgSOUtUqtdoHggP4IBgTaqhX9NkHJmEz1bOlV3zO460Mzn10IhrYKcVI 5Z5PFhEzjHdpFbp48tvGaryXT3kkncxDZOejbdxq6Yx8NDpVu/WXLKHWLZkAzqYacnru LQIg== X-Gm-Message-State: APf1xPCP9ICo/e9gTy27zVfG8Eeeajje5WgMW2lyA5ZnB/CSTCUhyzjT HZrwTEZsvBdcx9+TwbOHXtagAg== X-Google-Smtp-Source: AH8x227MoELX/z+Gc873P4sSqn/cwkap3t1yn3yWBToFfHg2qf1zHlECODjIvLAEqoxmc7Ar6yeUWw== X-Received: by 10.99.133.193 with SMTP id u184mr9214003pgd.401.1518440239499; Mon, 12 Feb 2018 04:57:19 -0800 (PST) Received: from CY1PR15MB0730.namprd15.prod.outlook.com ([132.245.253.237]) by smtp.gmail.com with ESMTPSA id m4sm13900078pfh.150.2018.02.12.04.57.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Feb 2018 04:57:12 -0800 (PST) From: Haojian Zhuang To: Ard Biesheuvel , Haojian Zhuang CC: Leif Lindholm , "edk2-devel@lists.01.org" , "heyi.guo@linaro.org" , "linaro-uefi@lists.linaro.org" Thread-Topic: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file Thread-Index: AQHTocvf6rQiVfNvrkKm7rrjsKoICaOgqkIAgAAAY8yAAAVaAIAAAyMpgAABpYCAAAKxug== X-MS-Exchange-MessageSentRepresentingType: 2 Date: Mon, 12 Feb 2018 12:57:09 +0000 Message-ID: References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> <20180212114506.gfu4hfz566jg7vvw@bivouac.eciton.net> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 MIME-Version: 1.0 Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 12:51:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable >From: Ard Biesheuvel =0A= >Sent: Monday, February 12, 2018 12:22 PM=0A= >To: Haojian Zhuang=0A= >Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi.guo@linaro.org; linaro-ue= fi@lists.linaro.org=0A= >Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtim= e lib from common file=0A= >=0A= >On 12 February 2018 at 12:19, Haojian Zhuang w= rote:=0A= >>>From: Ard Biesheuvel =0A= >>>Sent: Monday, February 12, 2018 12:05 PM=0A= >>>To: Haojian Zhuang=0A= >>>Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi.guo@linaro.org; ard.she= uvel@linaro.org; linaro-uefi@lists.linaro.org=0A= >>>Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runt= ime lib from common file=0A= >>>=0A= >>>>On 12 February 2018 at 11:47, Haojian Zhuang wrote:=0A= >>>>>From: Leif Lindholm =0A= >>>>>Sent: Monday, February 12, 2018 11:45 AM=0A= >>>>>To: Haojian Zhuang=0A= >>>>>Cc: edk2-devel@lists.01.org; linaro-uefi@lists.linaro.org; ard.sheuvel= @linaro.org; heyi.guo@linaro.org=0A= >>>>>Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime l= ib from common file=0A= >>>>>=0A= >>>>>On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote:=0A= >>>>>> With the SerialPortLib and DebugLib, Dxe runtime driver can't=0A= >>>>>> be executed well on HiKey. Serial logs are missing.=0A= >>>>>=0A= >>>>>"Can't be executed well"? Does this mean it crashes?=0A= >>>>=0A= >>>> No crash. Serial output are missing since SerialPortLib is different.= =0A= >>>>=0A= >>>=0A= >>>Does this driver take care to only create serial output at boot time?=0A= >>>Does it, e.g., call EfiAtRuntime() or use a notification callback at=0A= >>>ExitBootServices to make absolutely sure the serial port is no longer=0A= >>>used?=0A= >>=0A= >> These drivers don't use serial port directly. But I tried to use DEBUG (= )=0A= >> function to dump some debug informations in these drivers. I found=0A= >> that I can't output anything on serial console.=0A= >>=0A= >=0A= >But do those DEBUG() calls only occur at boot time? Or could they be=0A= >called at runtime as well?=0A= =0A= Excuse me that I didn't explain it clearly. =0A= =0A= At first, I need to make sure everything executed well when I switch to=0A= the common dsc file. So I added some debug messages in those key=0A= drivers.=0A= In the second, I need to debug the boot flow later. I mean that I need some= =0A= debug message in the initialization of DXE runtime driver. I'm considering= =0A= to make use of EmuVariable and predefined emu variable region in RAM.=0A= Then I could store the predefined boot options in emu variable region.=0A= And I could re-use PlatformBootManager in ArmPlatformPkg without big=0A= changes. So I need to add some debug messages in these DXE runtime=0A= driver.=0A= =0A= These two drivers in the common dsc file blocks me enabling debug=0A= messages in the initialization code of DXE runtime driver. So I have=0A= to move them out.=0A= =0A= Best Regards=0A= Haojian=