From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.73]) by mx.groups.io with SMTP id smtpd.web12.49829.1600718464347182450 for ; Mon, 21 Sep 2020 13:01:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=JKnJpR6x; spf=pass (domain: vmware.com, ip: 40.107.92.73, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTVqoyax70K3hAU1ac1jyOKhowO3i4Wynq6lD+pdQ8lxkHc2bRDycs15Vhi5OSF5c8W7eSTYyzQiBJjGEUNrB5O0TqPBvqDk2hS+mdRsNQBDAjRWedEAG7RF3/oot0dALeYKgzJALi2zLpTGeVjCHnHFZ75NMFMbV/EffK7c8wEl8ZdipR/JSVYwNdwQ+QtK70RgleSAtwpKHBN3xK4lEhcc0zf1JndQHF54oi/uvZGqbpyKarQIrRaccvQaxZn98wFc4cTd4driAVOULPA4Qo4BE95ObsCAV7ooHWgfKjDEk+RwddMcggaJSc1nm2hNrVHGA20lp8QWVt/x5ifa6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IYaVsQk9TGdPsoiSlZE1Rka5m6Sjsqudc7OXVXwTH8=; b=YfkEaZLW9hy/v6rRsAp74bt8HSEv2m0QtfLjdOrVTF2Gr5FQh1sr4d7KYqqjIVNzTYEY9rLIdmiX8my95T5mnJP2H86TqQVR9OCz6J35XiusUNaB9ncvJmCVmQ13byTLqCA9ZnQnFESHipBywQvcGHwLQhAQHTG01qqOU4AdC2snjetOoq26/J312whCwIeHzhgRJTc3todldJVWluSv3Zdccuq9L/6TeZP/ey6S9sX5zD/TQ10156ZlU6hZZMREu6s+T/XDytgdxi0aWl+0xUDyrDFqHrSH7j41h/wSIVf9Tbf2VG4wtKqfyV8U565D3qyi2lsbZZ4cnJxxOe3atA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IYaVsQk9TGdPsoiSlZE1Rka5m6Sjsqudc7OXVXwTH8=; b=JKnJpR6xD+/mv1cYOtrOxluDHcrmB6pY66jDNcLGdVhJQYRvfN+JcI93sDOW8W8x1oDeUFcvj+0Te4NJLd2kAt6uCA2yvtdVoNLa6cdSWmmad4zFqALmuyIo1oWzGDlH8jrbKjUwM8tnswcdyXChGW103ZFUCeqGEaT6eYgUZ7Y= Received: from CY4PR05MB3413.namprd05.prod.outlook.com (2603:10b6:910:59::21) by CY4PR0501MB3697.namprd05.prod.outlook.com (2603:10b6:910:8d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.9; Mon, 21 Sep 2020 20:01:02 +0000 Received: from CY4PR05MB3413.namprd05.prod.outlook.com ([fe80::1d5f:d95d:236d:eea6]) by CY4PR05MB3413.namprd05.prod.outlook.com ([fe80::1d5f:d95d:236d:eea6%6]) with mapi id 15.20.3412.007; Mon, 21 Sep 2020 20:01:02 +0000 From: "Andrei Warkentin" To: Pete Batard , Jeff Booher-Kaeding , "devel@edk2.groups.io" CC: Ard Biesheuvel , Leif Lindholm Subject: Re: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4 Thread-Topic: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4 Thread-Index: AQHWi1tpSsVc4MIFz02BFM1QbvlIoKlzjPUH Date: Mon, 21 Sep 2020 20:01:01 +0000 Message-ID: References: <20200914213230.78282-1-jeff.booher-kaeding@arm.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: akeo.ie; dkim=none (message not signed) header.d=none;akeo.ie; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.89] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3401c9e0-ddcf-443e-0247-08d85e6910f0 x-ms-traffictypediagnostic: CY4PR0501MB3697: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IIVr7qaqHf7HCtV6KJwhAHDdsnHAArwX6pXXoqCVOjwRoEyY4eeZp3nkf+Qn9zFzQ2+Mp4J1dwS2eC7BOOhpk3+SXH2mrKWlVIvkMcFZf/dXMIO2Et4YD1B4CzRtoVzZFfhYjGcHp2n20kcx6RL37dapKqwTokZwKJ9M4ME8yZvbHl0o75MXo6LsIbD94gY9CpHO6/TuzV6tqoAbPDs2yNMBvWksqhMytHJ4zX6WMgMtvhbnrQOEv+SQH4jfI69r/4C4o2qwaGYaRSI0w2FHBfie6SQcm8N+J7IymG24Kv7MAy1wg0RYIkYFgyfXi1E7810k0cweizu4D/Fvk3S/WXjq7+hpb3SkVi0FLWuQZWpwX102dsWY2YZt7TUYqWcukI+dKbyisb3RlyZIGww+WA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR05MB3413.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(86362001)(52536014)(8936002)(66476007)(66556008)(66446008)(166002)(110136005)(64756008)(8676002)(76116006)(5660300002)(966005)(478600001)(55016002)(66946007)(45080400002)(9686003)(19627405001)(54906003)(186003)(71200400001)(7696005)(4326008)(33656002)(26005)(2906002)(53546011)(6506007)(316002)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: FZRFzGmOn/WaUmKO8i3PHNNMJe5ktVcMF8TRJ7LWZnj3qkxB0Mgg8jntV5s3ONFLosdrv9xhYXK0IhTIWmKwqgAjkcrBpl9pzOGaJfFGNre6CiJ2NpoFIDkEwW/z7OqGkIscTon0F4/W86xqJWKyfdkesQmBqJqpWRhZU3IabCvZwIM5hX7ko7qKVSOmnU9hFV65GAIDAP3ZQqH8BaK6UB8TtBOPaVVOcYWyEB8/bGZ8339/y6EmKAo1KHj54ljwVj7KKc9nJhleLMD5AoymVqyhP8bSYSppdv4TSpBfPacPIUAgOnC7fn5ATGm8HBW2lYHa//KtGQEqJBkrP/adGZsIebOXJAADpdh3vc44cMMJ14MIZCqfgBkbLnrxYlbK6JMSYMKTvD2TsFq9I2FIyRMyFiGUNtFm5S1Xrx6WcmQtgEREIQY99rUU5hteyesoTBsYOMX/u/aDVim/pkFv+sBWqrlags21PDzZ/Zy1QsimHbk+mq8VgzPh7Dgop3XpjqsB8/WNXCF+KlpNTiZ1Qo94D4Wgc/Cpzid9EGApwNtEo4+cfogLunuC7cdG54X+hTY/YEuYQx8NXIA77sRh5RqjMSNMyiXcYZguFsei7SI2APQqV0CHkdA0HXDfwklSR4llJRxNpPxUMKsEe+mZQw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR05MB3413.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3401c9e0-ddcf-443e-0247-08d85e6910f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 20:01:01.9947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JjsEmg1D+wt70zQIxoWuLWXzrvBa0VHhXzvXUJ1h7fiGKJsrnRTndWwHceaas5OMbuXZPQ4XgK/5WnVN/ioAQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0501MB3697 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR05MB341362751FBC9A4FA4DB6D7BB93A0CY4PR05MB3413namp_" --_000_CY4PR05MB341362751FBC9A4FA4DB6D7BB93A0CY4PR05MB3413namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi folks, No objection at all. IIRC the original pin selection was driven by an artic= le I read about using OpenOCD with Pi 3. A ________________________________ From: Pete Batard Sent: Tuesday, September 15, 2020 7:26 AM To: Jeff Booher-Kaeding ; devel@edk2.groups.io= Cc: Ard Biesheuvel ; Leif Lindholm ; Andrei Warkentin Subject: Re: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout= for Pi3/4 Copying Andrei on this, as the existing JTAG pinout is not technically incorrect, since GPIO pin 4 can be used for TDI in ALT5 mode, and we are using the relevant ALT mode in the existing code. See https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsysprog= s.com%2FVisualKernel%2Ftutorials%2Fraspberry%2Fjtagsetup%2F&data=3D02%7= C01%7Cawarkentin%40vmware.com%7C1c1badf5e6f1433b44b508d859728a32%7Cb39138ca= 3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357695767996220&sdata=3DrGIzM4Io3= 6gFJrAK%2F4xZs0fm0DpXVvamhOYYXfc09ek%3D&reserved=3D0 As far as I'm concerned, I think it makes sense to use the same ALT mode and have all the JTAG pins grouped, but I'd like to confirm whether we deliberately chose not to use GPIO 26 in order to leave it available for some other purpose, before I approve this patch. If Andrei says he's okay with it, then I see no objection to this change. Regards, /Pete On 2020.09.14 22:32, Jeff Booher-Kaeding wrote: > Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3 = Datasheet has same pinout. > > Signed-off-by: Jeff Booher-Kaeding > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Pete Batard > --- > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platfor= m/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > index ac1004fe1836..6e793efb8227 100644 > --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > @@ -502,7 +502,7 @@ ApplyVariables ( > * 1 VREF N/A 1 > > * 3 nTRST GPIO22 ALT4 15 > > * 4 GND N/A 9 > > - * 5 TDI GPIO4 ALT5 7 > > + * 5 TDI GPIO26 ALT4 37 > > * 7 TMS GPIO27 ALT4 13 > > * 9 TCK GPIO25 ALT4 22 > > * 11 RTCK GPIO23 ALT4 16 > > @@ -510,14 +510,14 @@ ApplyVariables ( > */ > > if (PcdGet32 (PcdDebugEnableJTAG)) { > > GpioPinFuncSet (22, GPIO_FSEL_ALT4); > > - GpioPinFuncSet (4, GPIO_FSEL_ALT5); > > + GpioPinFuncSet (26, GPIO_FSEL_ALT4); > > GpioPinFuncSet (27, GPIO_FSEL_ALT4); > > GpioPinFuncSet (25, GPIO_FSEL_ALT4); > > GpioPinFuncSet (23, GPIO_FSEL_ALT4); > > GpioPinFuncSet (24, GPIO_FSEL_ALT4); > > } else { > > GpioPinFuncSet (22, GPIO_FSEL_INPUT); > > - GpioPinFuncSet (4, GPIO_FSEL_INPUT); > > + GpioPinFuncSet (26, GPIO_FSEL_INPUT); > > GpioPinFuncSet (27, GPIO_FSEL_INPUT); > > GpioPinFuncSet (25, GPIO_FSEL_INPUT); > > GpioPinFuncSet (23, GPIO_FSEL_INPUT); > --_000_CY4PR05MB341362751FBC9A4FA4DB6D7BB93A0CY4PR05MB3413namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi folks,

No objection at all. IIRC the original pin selection was driven by an artic= le I read about using OpenOCD with Pi 3.

A
From: Pete Batard <pete@= akeo.ie>
Sent: Tuesday, September 15, 2020 7:26 AM
To: Jeff Booher-Kaeding <jeff.booher-kaeding@arm.com>; devel@e= dk2.groups.io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <= ;leif@nuviainc.com>; Andrei Warkentin <awarkentin@vmware.com>
Subject: Re: [PATCH v1 1/1] Platform/RaspberryPi/ConfigDxe: Fix JTAG= Pinout for Pi3/4
 
Copying Andrei on this, as the existing JTAG pinou= t is not technically
incorrect, since GPIO pin 4 can be used for TDI in ALT5 mode, and we are using the relevant ALT mode in the existing code. See
https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fs= ysprogs.com%2FVisualKernel%2Ftutorials%2Fraspberry%2Fjtagsetup%2F&amp;d= ata=3D02%7C01%7Cawarkentin%40vmware.com%7C1c1badf5e6f1433b44b508d859728a32%= 7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357695767996220&amp;sda= ta=3DrGIzM4Io36gFJrAK%2F4xZs0fm0DpXVvamhOYYXfc09ek%3D&amp;reserved=3D0<= /a>

As far as I'm concerned, I think it makes sense to use the same ALT mode and have all the JTAG pins grouped, but I'd like to confirm whether we
deliberately chose not to use GPIO 26 in order to leave it available for some other purpose, before I approve this patch.

If Andrei says he's okay with it, then I see no objection to this change.
Regards,

/Pete

On 2020.09.14 22:32, Jeff Booher-Kaeding wrote:
> Updated the pinout to match the Pi4 datasheet, tested with the RPi4, P= i3 Datasheet has same pinout.
>
> Signed-off-by: Jeff Booher-Kaeding <Jeff.booher-kaeding@arm.com>=
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> ---
>   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 +++= ---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Plat= form/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> index ac1004fe1836..6e793efb8227 100644
> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
> @@ -502,7 +502,7 @@ ApplyVariables (
>      * 1      &= nbsp;    VREF        N/A&= nbsp;           &nbs= p;  1
>
>      * 3      &= nbsp;    nTRST       GPIO22&nb= sp;   ALT4    15
>
>      * 4      &= nbsp;    GND        = N/A            = ;   9
>
> -   * 5         = ;  TDI         GPIO4 &nbs= p;   ALT5    7
>
> +   * 5         = ;  TDI         GPIO26 &nb= sp;  ALT4    37
>
>      * 7      &= nbsp;    TMS        = GPIO27    ALT4    13
>
>      * 9      &= nbsp;    TCK        = GPIO25    ALT4    22
>
>      * 11      =     RTCK        GPIO23&nb= sp;   ALT4    16
>
> @@ -510,14 +510,14 @@ ApplyVariables (
>      */
>
>     if (PcdGet32 (PcdDebugEnableJTAG)) {
>
>       GpioPinFuncSet (22, GPIO_FSEL_ALT4= );
>
> -    GpioPinFuncSet (4, GPIO_FSEL_ALT5);
>
> +    GpioPinFuncSet (26, GPIO_FSEL_ALT4);
>
>       GpioPinFuncSet (27, GPIO_FSEL_ALT4= );
>
>       GpioPinFuncSet (25, GPIO_FSEL_ALT4= );
>
>       GpioPinFuncSet (23, GPIO_FSEL_ALT4= );
>
>       GpioPinFuncSet (24, GPIO_FSEL_ALT4= );
>
>     } else {
>
>       GpioPinFuncSet (22, GPIO_FSEL_INPU= T);
>
> -    GpioPinFuncSet (4, GPIO_FSEL_INPUT);
>
> +    GpioPinFuncSet (26, GPIO_FSEL_INPUT);
>
>       GpioPinFuncSet (27, GPIO_FSEL_INPU= T);
>
>       GpioPinFuncSet (25, GPIO_FSEL_INPU= T);
>
>       GpioPinFuncSet (23, GPIO_FSEL_INPU= T);
>

--_000_CY4PR05MB341362751FBC9A4FA4DB6D7BB93A0CY4PR05MB3413namp_--