From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.8686.1632795143653565135 for ; Mon, 27 Sep 2021 19:12:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gbSC+DSN; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="310151333" X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="310151333" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 19:12:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="553726071" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 27 Sep 2021 19:12:06 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 19:11:59 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 19:11:59 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 19:11:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pa9Mt34689mlq2NnZMMVSDK5JRpmOHAN/NmuLWXqovk2QSQnYRTQ38HHZ5+4MUtWQFU5Rv38H9calRFD7OSBj86yhghaLfC4QfzLh8Ucrn6PGWSBt//8jCqfQQ/arPUzczKaDIwC5lGGkGfZzUEMcICmoVTCiPYAozhj0L1OQVU8+hBAOzhWeEOuQwdgo1a/G9l7w02JK4TzPu4MfjfypAvP1JGw5Ls5/YoArj0PZ6IsqgEKa92awFGXkCA5SJXottwzVGGyUHC6GIDPrzzFLDc/ihfqJNvU1kshHqp0+Us/8KFqFGza+bZFSIYSXgpf16mJFQspC9rFddPO5xhyFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JrIkC7WgPBI47wdMa+kW4tL5TFKSG7z2w/BuAIg+Dj8=; b=ZL8z7Z+TEQIM9FXlhuJRBwSZfHxKaNWRIl5LI3c/Ks+tn7MGmKFC4Q+2WKhVP7jI7uOLve3BawtJnqcmwSef6KQevuIr+4Mzh2XZmiCm4R4ect88aOQvvne/Tfq1CXNUttX19HgdZ0gAiAT4TmCjYyskm/3GYhC8s1BSJCnJNC1PaCoceW+TvqpwbrxT20jjZ0Ia2sJRKU3ye5WbQ7q7BnsUgNcx0h1B96Zujq0wFlT4OIItnJv687xNleakHjPUSvOIO0f7gV74YY3fKq8bzcV7gPRzYE6Kmc6JInOWmEinu2Hlpqp2UdcIv0KIwf/pk0z2h97cPVNaDOiAtuOnJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JrIkC7WgPBI47wdMa+kW4tL5TFKSG7z2w/BuAIg+Dj8=; b=gbSC+DSNFkHS/6cI4H6cQmy2lMQeBtA4qPHUCRtr+57boK1NZr12FTXBWOnL/JvfYoNg0EhWa6HV7CL+58z7hQVbhDeE+Ij6i7xGfu3ikmRIAMQ/JbjKJMyW/RdEvwHPcwcMvwZ1YNFH5B9H3nW8vXYQQ024ssvhPqujw2e5HSM= Received: from CY4PR1101MB2072.namprd11.prod.outlook.com (2603:10b6:910:1d::15) by CY4PR11MB1383.namprd11.prod.outlook.com (2603:10b6:903:2d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Tue, 28 Sep 2021 02:11:58 +0000 Received: from CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f]) by CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f%8]) with mapi id 15.20.4544.022; Tue, 28 Sep 2021 02:11:58 +0000 From: "Ni, Ray" To: "Zeng, Star" , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" , "Kinney, Michael D" , "Liu, Zhiguang" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 Thread-Topic: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 Thread-Index: AQHXtA0tkxC+bifa40Kp2LwLfOqcdKu4s6SAgAAAhFA= Date: Tue, 28 Sep 2021 02:11:58 +0000 Message-ID: References: <16A8DA167D1CA920.13648@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5161052e-1216-474f-ebdb-08d9822559ee x-ms-traffictypediagnostic: CY4PR11MB1383: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zey1FUYV36QvGpEFDjZjKGudmZeM6Wm3x0nehQ/Vc0X8faXx8D1ctus/fRMXhGxL/sFHyPyCAusofJmQWJjy3mPch9qmbDcESOSZi5PgmPHZ9j2E4DXBAM5BHDNwlu+c6BYSUiSRWAIRE050WcROfDjowYuBzRvs7AlHoTYYatcfoT8ZrZLVybH5z+HVatEHNf8NqdnMm9i6DP6b6FDNZ1lCunsJdvl5XlaoWpScusci4o8GRxu8OjY+fv1l2pY2pNP6/Tudm9lWu5j1p+wqshmPtN3NdKRdm1oJdmZfelFPvw33Xd8mf1gA95gfqFmwRdTmPkNSokJLD/N/gnLl/NYDpJb+LSgpYDOPWjjwaNutOwJEMao6djq0hKnb4+orSXM4RkuaA6yodSM9QsLmihLrFYLOVzsE3R+8cCqc3WiSJjApuf9h8bacqK/MzpmxGH+X0VMz36FqIl5oPisZG1iBzkem4q80zW/v77En58Jw3cPBaW3CyDypYQGCv65gPZP+ieh/Sov4aKeuafG9qsVEk32IxGHcdsDk+6CRIuL1qYLKobyH1JLFf2DemUS5zmAX5FPNWXIBSyN3YdT0cMzeYHGTlnVJCsk+3gtw5+Y0SfgmLavjGr2bu4/iMSzhCiRfWPle6xSBsXTUjI++lx0fBPKQTC/517PuZGiipF9uDss4S9h8txLO2FQebg7BF/rT+a3aLMIq6H64daSFVeYx/qeCCwAF7dHkxEhLgGGLWMnl/abpRLHzM/wGTVK1L2jPz4sCB31mR73qGnb/gzfxnC/pCfNBOsxV6Err5iT6xQD7TbnCl1s1bo9/xENn/lGGsK7EXRSq70d8ozxA7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2072.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(110136005)(8936002)(9686003)(19627235002)(107886003)(4326008)(316002)(52536014)(8676002)(71200400001)(83380400001)(26005)(38070700005)(86362001)(66446008)(64756008)(38100700002)(66946007)(508600001)(53546011)(7696005)(6506007)(66476007)(66556008)(55016002)(76116006)(33656002)(122000001)(186003)(5660300002)(966005)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?WEZIejdVRnFYSWN2eUdZWmF1QUFmOVliK2dyZjlQNkk5WXBGQm5WNzhP?= =?iso-2022-jp?B?Ymk2UVVXM3dZNTlOZTUvVWpaSG00K3FCZDludHZPd0tKRWh4ZnQ2THBR?= =?iso-2022-jp?B?bThFdkl5aDhRZzcvNHhZK05RRFlFSG1WS0ZDUW1IWFhVUUIrQmFValUr?= =?iso-2022-jp?B?UStqeWFiczhhem0zQlJZK0N1TTZ6d0Rzd2RVZFM5Q0lrUEVMbExBSE5z?= =?iso-2022-jp?B?SWpzUHFabWFtc014dVFYd0xOSlM4U2pCSVI4SGhiekdhY0pOMlRSbjJw?= =?iso-2022-jp?B?bnR3dnNENm5NWldFVlJxdzN4RmVXcHB2RmV4dzNxci9JcWhvZWhXQzlo?= =?iso-2022-jp?B?OW9jaGxkVFZkaVJYQ0w5K012Q0NUOFIxYUR4aFB0M21UWWd6b1lQTHlN?= =?iso-2022-jp?B?ampDNWhRNnAvc3VJalBXTUtzV0ZqQ3dLRmZOZENVNTh3U1FxUmVaQ3N4?= =?iso-2022-jp?B?NTNDbUtrODZmV0lBUlprVW5Ya2MvTmNMQnlKWFpSaDFTbnlMRG5HZlZZ?= =?iso-2022-jp?B?dWNhOHlkb0V3WEJzZTZkd1N6TTRjM1U3TE9pUXZGekdhWlFwTVpwZmRW?= =?iso-2022-jp?B?UWJxeUVoRWdpLzhnQndDejQ0emtQVHQrUDU4a1NjQ0I2cmIydTN6bWdQ?= =?iso-2022-jp?B?WU56TzBNSzB1KzlyMTNGWUVCZ0pJTFI4RGtnaUVQWFk2Z21FMnlleXh5?= =?iso-2022-jp?B?c3JTUlliT0hmVTZsd2RDQjNobWVQblQ0bkJjcGVGYUhSSkxMRUNEZHRp?= =?iso-2022-jp?B?THdycEdHVDMxVDFHSUZNcWVnY2doZVRiSkhwUlFieEg1ejk5dlJ3c3Q1?= =?iso-2022-jp?B?cHRlWEc0UVBhcytTNnk0dTRyMG9XMkNiZWYzL1MwRWl2L3dlUk5QSDV0?= =?iso-2022-jp?B?ZVBqZEhkd0ZJc1M1bGUrOFMwT29BOTZYeW01TkZYdlA2VDZoUmtwMjNN?= =?iso-2022-jp?B?eXNSS3JnbmgxUDAveFd6UmNObzhlMFNJRWNQMGlhK3UrVkVEVk5idkhy?= =?iso-2022-jp?B?UGZDYXpmOUhxZVFuLy9uc2ZPT1Z6RytoeEY4RzRiZ1RNOHJKVzFnUTJB?= =?iso-2022-jp?B?UmFGMEpQZ2ZERFJWcHRCNnhpTGhOcnZXQ05qY28ySG5UZzZoVHVqeXVz?= =?iso-2022-jp?B?aG4xWFgybWpiVlNMbEhmRHMxUnRSRElGck1iN29Vb0hnNmlYZ09WOVVx?= =?iso-2022-jp?B?RXg2UG5JNHJySjNoVDdOcXBLMnNIWmpQU29xR0lQL1U4Y2RsVmlnUFJ1?= =?iso-2022-jp?B?aCtoTWE2U2NRWHkxSzR3UmNQOU5McmtNOEFHeER3VGU1anlMVXRabC9o?= =?iso-2022-jp?B?c2RtY0JEdzdTeEJWN1pPb251Ujlpa1RHbzh5M2tqV1VPcXJaSzBWa3hk?= =?iso-2022-jp?B?Ty9qaVBOVmNjMTN2VTFGSzhyQldzNnpBb2x6Syt6clY1MDFGRDRtNTR6?= =?iso-2022-jp?B?OS9NTENoYjRhSXZkUmdScGlSL3lVQWxVRzRENkcyMTZ3cUVhcXZ0c2VS?= =?iso-2022-jp?B?MUtWYS9vSTZubkZOYWV0S0JLdVJETUF5S2o1TUNRcTBBQ0RpNTk4K21z?= =?iso-2022-jp?B?NzVlUkY4S211MkNBb3c4TkVKZGx4WGNVYldpajM3YjA4Smp0TSsrajMx?= =?iso-2022-jp?B?bmpIckJZMkZyMUNzaHRSc0w5VFlhTDd1ei9id09WTnlkekhlYWQzZC95?= =?iso-2022-jp?B?OGxMNG9VR0FzeGhqQ3BSQ2IrUTVnd05LbTQvUUJvV0paUWVmWHBXQ3FM?= =?iso-2022-jp?B?SzVQSWJPMHdFSlVJVXVBVVByL2FJNjRwRzNQdzZUMDJmUlR3S0hrRC92?= =?iso-2022-jp?B?M3IyZkJnMGlENHlzSk5LL1gwaXowZTZtMmkzaXJ1SXA5Q1NWQ1NRNjFR?= =?iso-2022-jp?B?SU1IM2pEVExyZ0xyZmdROWxVRkJEVjRQZHBLbDlWMno4dWR3NTBNdXNa?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2072.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5161052e-1216-474f-ebdb-08d9822559ee X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 02:11:58.0818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z6NRFUzm/kL7682mCf4dMllwwkqAvDdaWGk2LudsdSQdYPSKNk6cLcoCVi3y+aIsMeG9N9rRjX1Urd0f9mBT8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1383 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Star, It might be better to split the patch to two patches. one is to change MdePkg adding the definitions. The other is to change ShellPkg consuming the definitions. > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, September 28, 2021 10:11 AM > To: devel@edk2.groups.io; Zeng, Star > Cc: gaoliming@byosoft.com.cn; Kinney, Michael D ; Liu, Zhiguang ; Ni, > Ray ; Gao, Zhichao > Subject: RE: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSo= cketLGA4677 from SMBIOS 3.5.0 >=20 > + Maintainers and Reviewers >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zeng, Star > Sent: 2021=1B$BG/=1B(B9=1B$B7n=1B(B28=1B$BF|=1B(B 10:04 > To: devel@edk2.groups.io > Cc: Zeng, Star > Subject: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocket= LGA4677 from SMBIOS 3.5.0 >=20 > This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h fr= om SMBIOS 3.5.0 and entry into QueryTable.c. > It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1= 200 into from SMBIOS 3.4.0 and entries into > QueryTable.c. >=20 > Signed-off-by: Star Zeng > --- > MdePkg/Include/IndustryStandard/SmBios.h | 7 +++++-- > .../SmbiosView/QueryTable.c | 14 +++++++++++++- > 2 files changed, 18 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/In= dustryStandard/SmBios.h > index 6918f58cce44..2c2b32b8d462 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -1,7 +1,7 @@ > /** @file Industry Standard Definitions of SMBIOS Table Specification = v3.3.0. -Copyright (c) 2006 - 2019, Intel Corporation. All > rights reserved.
+Copyright (c) 2006 - 2021, Intel Corporation. All ri= ghts reserved.
(C) Copyright 2015-2017 Hewlett > Packard Enterprise Development LP
(C) Copyright 2015 - 2019 Hewlett P= ackard Enterprise Development LP
SPDX- > License-Identifier: BSD-2-Clause-Patent@@ -810,7 +810,10 @@ typedef enum = { > ProcessorUpgradeSocketLGA2066 =3D 0x39, ProcessorUpgradeSocketBGA1= 392 =3D 0x3A, ProcessorUpgradeSocketBGA1510 > =3D 0x3B,- ProcessorUpgradeSocketBGA1528 =3D 0x3C+ ProcessorUpgradeSo= cketBGA1528 =3D 0x3C,+ > ProcessorUpgradeSocketLGA4189 =3D 0x3D,+ ProcessorUpgradeSocketLGA1200= =3D 0x3E,+ ProcessorUpgradeSocketLGA4677 =3D > 0x3F } PROCESSOR_UPGRADE; ///diff --git a/ShellPkg/Library/UefiShellDebu= g1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > index 7fc9d38a3b03..c312a7f8f227 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -2,7 +2,7 @@ > Build a table, each item is (Key, Info) pair. And give a interface o= f query a string out of a table. - Copyright (c) 2005 - 2019, > Intel Corporation. All rights reserved.
+ Copyright (c) 2005 - 2021, = Intel Corporation. All rights reserved.
(C) Copyright > 2016-2019 Hewlett Packard Enterprise Development LP
SPDX-License-Id= entifier: BSD-2-Clause-Patent @@ -589,6 +589,18 > @@ TABLE_ITEM ProcessorUpgradeTable[] =3D { > { 0x3C, L"Socket BGA1528"+ },+ {+ 0x3D,+ L"Socket LGA4= 189"+ },+ {+ 0x3E,+ L"Socket LGA1200"+ },+ {+ 0x3F,+ > L"Socket LGA4677" } }; -- > 2.27.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#81189): https://edk2.groups.io/g/devel/message/81189 > Mute This Topic: https://groups.io/mt/85916590/1779220 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [star.zeng@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D >=20