From: "Ni, Ray" <ray.ni@intel.com>
To: "Dong, Guo" <guo.dong@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table
Date: Sun, 26 Sep 2021 02:47:33 +0000 [thread overview]
Message-ID: <CY4PR1101MB20722F37C49B2AB6C7F9B17A8CA69@CY4PR1101MB2072.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210925035903.1644-1-guo.dong@intel.com>
- Status = ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo);
+ Status = ParseMemoryInfo (MemInfoCallbackMmio, NULL);
Guo,
I am curious why you changed this part.
Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from the parameter.
With the change, it has to locate the Guided HOB itself.
Other parts look good to me.
Thanks,
Ray
next prev parent reply other threads:[~2021-09-26 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 3:59 [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Guo Dong
2021-09-26 2:47 ` Ni, Ray [this message]
2021-09-26 18:32 ` Guo Dong
2021-09-28 2:10 ` Ni, Ray
2021-09-28 17:19 ` Guo Dong
2021-09-29 2:41 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB20722F37C49B2AB6C7F9B17A8CA69@CY4PR1101MB2072.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox