From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.14327.1632624458740671737 for ; Sat, 25 Sep 2021 19:47:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CWk1n6xb; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10118"; a="211399172" X-IronPort-AV: E=Sophos;i="5.85,322,1624345200"; d="scan'208";a="211399172" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2021 19:47:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,322,1624345200"; d="scan'208";a="654407434" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 25 Sep 2021 19:47:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 25 Sep 2021 19:47:37 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 25 Sep 2021 19:47:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sat, 25 Sep 2021 19:47:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sat, 25 Sep 2021 19:47:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n95M68i4hMyeI/fGSTiEZXeTNjUHALiLKN5VR0XkBtYMYsIMNd8DkC/cW1iofecuXVXDkq5GNql8F/RUf+LXd27jBZmnDNAHGnMgc7HlsyinsaQWGc/24/ReVIhkbs+eNNv3d4etXdA0zctIZy4pbleWOfUZwoeFRriBg1xrDP9jq2GyrDSmOGQB6hgW4oEDFgOT0RkhNrF/YKbI/ZxEjDHP9Fs80qrDwnYJkmxxAkRCeVEuFZxDKicV++j+eURFvXOPEo4Loshg741dSUHvnOs1FB8KcnX9i4cJTS41VSgbFWTx0k7lx8xvVLS92L91A1yUwY9M03Q7o4MY4Cbv+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sIVKvA0+f4iMzg8ttJP48web8kSZQiK0gmU/jET6FVk=; b=NeOavjfb+ZCxTuwXG6x11RB/ON8Z0EymqDTDhyygvu+qY067OpOPcAlkbXCy3qGulyu+WWvN+HDaAPeD7AT348+kmil8dRboSbhPQXHBekf2pWU846YWWYlGe4Pndpz9p0I3Z18cTN0MxK3dpzMjsnhuLCqKTJ2xlYYPJvRpSoenZSUSrHTKhxunjrkeJu/PZG2cmZzhMpCWa1NnazKJZXII9yhGdZnL5CUV+GfvhvKXA6oLKq+8OueI/l/+j8YlBoQhmbMArrhjZsJYBPWe/CEqlBf7nGwLS53DiYjmL1KBgAF29frsynq+uPgCOfraFxyVFndItsweib1i8SKN6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sIVKvA0+f4iMzg8ttJP48web8kSZQiK0gmU/jET6FVk=; b=CWk1n6xb18WLLCqDnNT2fo3mF5Fw6wM8KuWMCQCKXdYAeviIdPrda0gUX5snrT2XvZpSrluIerk1/s0+skPIB59tOxK0f1dSoWDmazMehcJXDGQ0maraLqfpLDYslZbz4wQtrwpqFjfFU/ZP/W6Gy+WxFYhuyV6L4SfjPGfdwLM= Received: from CY4PR1101MB2072.namprd11.prod.outlook.com (2603:10b6:910:1d::15) by CY4PR11MB1976.namprd11.prod.outlook.com (2603:10b6:903:120::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Sun, 26 Sep 2021 02:47:34 +0000 Received: from CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f]) by CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f%8]) with mapi id 15.20.4544.021; Sun, 26 Sep 2021 02:47:34 +0000 From: "Ni, Ray" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Topic: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Index: AQHXscG36fGuyEK78UeKENdUambyAqu1nY7A Date: Sun, 26 Sep 2021 02:47:33 +0000 Message-ID: References: <20210925035903.1644-1-guo.dong@intel.com> In-Reply-To: <20210925035903.1644-1-guo.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 375ddd34-cdad-432a-891b-08d98097fe1f x-ms-traffictypediagnostic: CY4PR11MB1976: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TWkuCj0fwkxzz6ouMe0lIhq20+TZMNyS2Y1k27hI54niumAQQOct/hFSs2E+E/jySFL6+YUQnK+Ku9wecm2I5oLT4gFr0yPcouQauSBHdftkRtDmq48rvo5Nb37JY1ByRa1J0UJ9oz+MFPAo/2I3no9JFT2J9Ms/dfXx7KgpW8v0KdhYw9/ZHGD63wQjivTsqy2nlI2gVCcD21coYaNroyD9iml1OcTI4y+tZVl6TVqBqQMt3hYYF0/zpqeU5RbgTn3hB7QG/k8mLFR164fD4iVHLralgyN0P8mdo86nV7mnKoM1GYmRTUvXa5tMmsxUsUl+axP+dHdFzzXhylz9ExTkWn8Cg1AF+ZpTmmh5c5USnUEjHqgHCtoQSqMa0NrFHPwZ4SF9ynFzuLXQU/3Oayk/7COu+8UUdXN8gSzLk4u7OwZGkcUUc1GUTvUg7CQrXME+bh89FeS1fLoqcsAcCw9CUci/CEuJcyu3pHlroLFzY+hooE1X8SwfZJ4LcBTmvsD89LVU7dZtP1gpaSWEI0/Eo+feiEswNgGh2QmTTrm/byvr7qFdcm5YVd0d8m7ib5s2mME9zZqDNi8RkmNVu1oNyvvZHRtvUDDxnO2iliZHctsG9r/dbzKGAYbywy77hR842ktPxCOELLDTdYNmEw7sb5MCGNywHSmEO6Vfu2idUBdqjGBsUG7B8zwadLptdb3b8jsQG9fZ4VEtqLhpFGej3V2QgZiQOtXfs8CscyQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2072.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(52536014)(26005)(76116006)(64756008)(186003)(7696005)(8936002)(66946007)(8676002)(66476007)(66556008)(66446008)(86362001)(5660300002)(9686003)(4326008)(107886003)(6506007)(38100700002)(33656002)(122000001)(110136005)(4744005)(316002)(55016002)(508600001)(38070700005)(54906003)(2906002)(81973001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PKFf/L1hTlwdNi0KJ7CNzL8x1pbve3SgJWug9MyxGGgsSkD0e2SDLP2oziMy?= =?us-ascii?Q?p1qZDF0H17w3PY9+hOh/6jEkYAZ30WB7rEIDc7Qp80mGQhGF9Imd8Cg6BXTs?= =?us-ascii?Q?+SwYgJKsIWsx8hqeWRNlz5LfP3/jFPwpDHWdFExul4BcRr6fgsy3GgpXZE85?= =?us-ascii?Q?zLqMD1x9f8G0IhmIyj7MfNuf777D02gPVyIBYM0skUp+5CQXdqdBL88oa/sm?= =?us-ascii?Q?+6FS8GflgGm3eiv/QlJ9+2cpYvzCDslaTx0yrCEr2Iar0GzZaOys3gJ5/Vdb?= =?us-ascii?Q?l5UeJjMG5LmtJa2a12UnjouO7ywM03X9z7IOp2f8b1O//Iu0gMoRG2lR/yV1?= =?us-ascii?Q?Qys/K2783Pou/eE7v5YtyHGX0z15XjG2YW09pYte4Q/td5FiqkWrWhwfzKEC?= =?us-ascii?Q?IzZ/Ln/oZbbO8MutW1KI6INGMohGE3iWuSRJkNjkBDkMQqgu81q1XlfwATap?= =?us-ascii?Q?ctL6bHcXo04sb39z9j0ak1eVfq5zFoXxr7HEQ4jYjhLnRjuKmW59l4TcHmUi?= =?us-ascii?Q?sUuN4QolaB5evG+HGfN9UD2GQvTL74y1gd5pH8zgMDTTZGX5tIcNywbEoLZ3?= =?us-ascii?Q?84g8ZZ6VGb8vujlt2idbAhC0odjXXhHNwzxW5XtsgOUqFVpINyRc6j8ZoCoK?= =?us-ascii?Q?G7QukvmgfalRIEZSVF/SYEcygjycSGbZesttruHpU8RRdFK4ELlSvxWvSuXR?= =?us-ascii?Q?VPXab+3IP9aUNXiewIEPvkFnPPBOj+ia5JrWSjlcNHMP1qB0VlrsS+vH7Uwc?= =?us-ascii?Q?qEtpobUZ3sOpAcnTkyO85RuyRVuEykJvMAAcQ/bzqE6tGUdUYXht731imRil?= =?us-ascii?Q?yzEZ9sPvDkBRTwcIjydJzYwhMbHHeQxSv0Cufk/2VEcu3J7aikj2XK0yDnKe?= =?us-ascii?Q?LkzmBtABOP9FsYfyY6X61HLwhNVmj2bjD30nTdZ4fGu7OX5yB9GARLkHYuqH?= =?us-ascii?Q?9l9I7NS83xpmukxb9rcSkfzwov4+FWJdDdZb2i12xv0WLztgeKQN/NmyhMxO?= =?us-ascii?Q?dlI/z6XG0UtVUbyr1vmS0c7ey/6I+QZOsABG+f0dnuTQRh1P1V70fS+dDrGE?= =?us-ascii?Q?ZhzXlm5rLrZiFpxMjJoQkf/M0mCyBuEhiONKtkaUsLHIXDffq7v7zdtcXwbf?= =?us-ascii?Q?c8x0XRClqUwLBKu0ZfaDarXZpHTDxfSeyd63IW8VcOgTP3SHzQpnfiuyEwXi?= =?us-ascii?Q?E32RIEV0RUTjGR2H2v1NKPYbMrP5POyHTMrLs0G/MYUkAHjGeqpjjB1IbEVx?= =?us-ascii?Q?KY7X0V/HUvMl8WebynVZ2UgOY72k+UIHEJIlyl6D87iHQ6ykxE3b92U2qPAf?= =?us-ascii?Q?KyoPUFv4y7FqhGr1hcxgBawl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2072.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 375ddd34-cdad-432a-891b-08d98097fe1f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2021 02:47:33.9783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yQK3CSYw2C54W2T7RRra0TBkBaL2ygs2fQ7f49B1nGE94kKr/82wha+RmiASnVrQEQkD8ab0hpi/p0TL1yB1Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1976 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable - Status =3D ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); + Status =3D ParseMemoryInfo (MemInfoCallbackMmio, NULL); Guo, I am curious why you changed this part. Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from t= he parameter. With the change, it has to locate the Guided HOB itself. Other parts look good to me. Thanks, Ray