From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.9459.1632924681931264521 for ; Wed, 29 Sep 2021 07:11:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Rb+ynZrL; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="223058192" X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="223058192" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 07:11:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="479276143" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 29 Sep 2021 07:11:21 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 07:11:20 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 07:11:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 07:11:20 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 07:11:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7QNzs5z++PenqsFZAdMuitRGzjmfSRhPZox8HL2deiRhlk2xYWfGF1plAi7KdsXeQArj5aKCtvKy5lSWLr5qI4eICV8Z9zqkOU+szcw49UZgmYTKKIkCjjjkHQ5Hjnrat4/hbA4gewbRWx+H08jv0pC1mIpDc4L01jUQYbxFFrfi5XjrW3TS+/QnmNIaBcZW1wcTXdxOjqKdpKMcQDlyae9MjJ7imrwNIvvz5awyZ1mnf+hWuruvFvt8jiZiVN9/0NjRNvLbz8hG6bgVfObdiDvx51Y4c3x1dcjLtd4b+XhbvcF/D7sC9e5iS5Q9tcbMsTi0zBbAuvhO1Ej1wXeIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cFJeTsAMSOZ8X0TE+fLWpbdCk15QEOEP4FSzxIxwyLk=; b=Ee6EVL7Ti7Aa51tZ9q6Sgt6lOcYOgMTUgrp6Xz6Fs1eHuCQN6JCkKP24hVKtBmrlCU9Ryvp53HZ9mCGtTgr1IglEEjWVDWw981qu1luCHVK9i4zJZcoMDjC/bv9aBuJj3KEpMUxcVdKgvM9NoXW0kQhTcgUF9ytG1axtBGiJoaQbiHu07VGfp4zh4WjwXwHI2A7Bg6M2IS3djgcKE7DenmmoWALTp7za3MpJn2N5pSKZjZ1UB1N11BoWoUyqtjBUhOVpK/rufBHqYoESKvk5yZZVVZKC+iYNOyDYb++xNPzH2xNQOYZDCU3TcSI3HsK7T8n/HlghBLnc8TqP2nJaLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFJeTsAMSOZ8X0TE+fLWpbdCk15QEOEP4FSzxIxwyLk=; b=Rb+ynZrLebhD0TUpfSy1TWK4e3wL5v/diqrqb8qZcMif1uNQM11MeDtckWAQc3+nL9DS/xZfCm5a5jD3VTBudIn388G87ZCVwH2NlBOLIW46D0TYTv05AOKOp3CVmNLR81D09qBUXhrpaPhH8DB7Q3gfANFAQ06u8vIcazo7SCo= Received: from CY4PR1101MB2072.namprd11.prod.outlook.com (2603:10b6:910:1d::15) by CY4PR11MB1959.namprd11.prod.outlook.com (2603:10b6:903:122::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Wed, 29 Sep 2021 14:11:17 +0000 Received: from CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f]) by CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f%8]) with mapi id 15.20.4566.015; Wed, 29 Sep 2021 14:11:17 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v1] UefiCpuPkg: Cpu feature data stored in memory may be migrated Thread-Topic: [PATCH v1] UefiCpuPkg: Cpu feature data stored in memory may be migrated Thread-Index: AQHXtSijzaJ+TgzKrUe0/NfPOrOw/au7DUbQ Date: Wed, 29 Sep 2021 14:11:17 +0000 Message-ID: References: <20210929115329.1220-1-yun.lou@intel.com> In-Reply-To: <20210929115329.1220-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d126c49-a5d4-4966-32e2-08d983530119 x-ms-traffictypediagnostic: CY4PR11MB1959: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uz8/k1qln60bPCrT14QEKXoHIN4Vf9Tia5ZOHSweZN0JGMl4UoMF1o0yV0S0Ed/cLhQR0ERcRIPsHHzvwRXNvjeMhkLgYX1cCZNxf4MwvbmPvRmXaptmXGETT961VUyDwrR7TAITUlIaAY6Wu6fotq5qpbWiOmQ6uVvBPcPyestjMbqKYa5HTzrgBMZHr9D6Bxfms6c7/fWxQPgV+svBQ0YB+LuYpWT5NEE3ckB4unFRyPCNji3mVxgtXz9k6emy5n3WOSatpUPXCMm3yCP+R2zRyRXQ6hgEADhnyS7RambZKnyDuAuFzqAd9Dd1wKcP4wkQ4J9E/00+XRQJUT9cq21H5BJSUYZC/HJH/EFEgP3rjHLRal7H8bYsTfst0U2tX+DlMuH2pIO/daGPD7AbHefQ+Www9Exg3V14Xcc4yzWZXfmEltwL4KycO4ra/YHuoJ/Otf9WHn9RdiI9OUQKtTiA6bSUbWayCPyQh+ZfIw9GdiIBB3HOcG6PH9dXUCD+NwdnuuNcYQUW2/EE+eLu2EW1Zt+H79OFyk8TEx4GipdZYTuP4g7ShK+IkKwJL0cgQJXA+WkWDgFaVFCmbm9lBTJUJEic4ZTE/thqEisCDazbZwrGD14KUYb83B4vEDFHdKWOh3cnQOYHne9L1zpxpnWLunYZl3TApoXXEhvroJ4WSa980kLG88rWwOCtpuZt9du0B8OZRsh66OSg0NNpvRp2ruKTD4ugK3BAlDUlMV3AB9im0WlglebbiIvBl4TIKPmGFRhZg3Fl6FsAWER/Yp8uupaskAdDvslKnmxqmuA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2072.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(316002)(7696005)(9686003)(2906002)(6506007)(4326008)(52536014)(186003)(33656002)(66946007)(38100700002)(55016002)(71200400001)(122000001)(66446008)(53546011)(54906003)(76116006)(83380400001)(110136005)(64756008)(38070700005)(5660300002)(107886003)(966005)(8676002)(86362001)(66476007)(8936002)(66556008)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7j5wvOZFotOZg7e/bJmhAnkNVaU0tg1iNMKl4w22PTlVG/Zn0RUaG393vk1i?= =?us-ascii?Q?YIAfYV2bXOBDNFiMuEpOQ0OrbeayXJdims1GhhgkkQ+zoDtMeubBcIvSYRDQ?= =?us-ascii?Q?oeUX2usK9MZ8hoPpGGNc841I9eGrk2wmWoQ7mY1zUhlcorVIaxrHCMTx3Mpn?= =?us-ascii?Q?jhbLzRmUK/tVHR1sddRnggweWNPjS3ts/Kg7W+vrSyO69jk/PwvSFSiCE3Tr?= =?us-ascii?Q?CSwVVRF5HU5z79fR1NCzxAyBRMCx9F+hHPRbd8unHz2zto+Ud3dVCSFjY6fp?= =?us-ascii?Q?alPT2Fxarwo0kHeP/TwTzj82rxj4ctXhXu+gO/D+kuV3GQbxST7Br2FrTM31?= =?us-ascii?Q?08Frd7qOD5fcQ8k3y4AQiBgpo4hQa/CIIypgdj1sNoCgbYRbmq/TQMx2CAm7?= =?us-ascii?Q?fBI6/MbR3X9I0OmbWRE9dvIxRia6Mj5R9iQvhh0NwaU67o5LPxPN8mZCDG9R?= =?us-ascii?Q?9mi3yp0bwLSqg2aENrOidBPNk9OXWxfWKisEPxWfl/OHj+wLtcw2L3lXhRVl?= =?us-ascii?Q?iDmn4QfI6EKKb2uBjuosAwhIFr6EA8Y6VAPOy+dJMmyVXc/bcTKMwzN5gysz?= =?us-ascii?Q?V+El+lo8sKYnmhyuzE8XDHB4Z9TAKVfskY2yJWFOKag2Tsxgb0ZMW9tJG8IJ?= =?us-ascii?Q?m0ToXU5eutjdhtzMN8CpNuDnzL0DwVquzWrS5Ieq9rbKuUhxrK1qOkIkSZNc?= =?us-ascii?Q?7eSlsxFQXCZSVysWXRfTp5+biGwYJy/GpQ3zQhyJRSUgoGZAXEur1BLkO06o?= =?us-ascii?Q?b6+wEEY5R7WPUYMuxU7W7wFgnFw9dk/c9TBELQ9semekWVLPixF+nshTSNkw?= =?us-ascii?Q?CVvovzoAlUu6yR9/Jh1AiOr1KEaOIyH2i+YcUUpxJe/HGf2lwMmMY35VTfgL?= =?us-ascii?Q?FGgT8qPQpUIIQz1Y5jKlay5heEFaQlZgPz3njY5e4HNb5Fe9tkQF62BXKCAX?= =?us-ascii?Q?2q1LkjLj5kAiEWp3nxZEE/ACfUEdIbLvFRUvLVrWJfcHPxDyT+TC9Mu+2WCQ?= =?us-ascii?Q?u9NFEeGmUH0b96+G2jzVN85w1HyutzrjupmFwmXcrF5SzjMWHCVEDIXhbTHy?= =?us-ascii?Q?sZNYbv6xyshJFtVEEKgS0CuOfKJHC1rrCjytJZgVmf0vn55nS2nFvP9cdEXd?= =?us-ascii?Q?+BgdExO+oCM3FaTw5chLtojBAYTUaOfmMB/zo3yrBFaFea6f4mPCSju7Lb8p?= =?us-ascii?Q?zM56Uhnk7yrD3ql2u53O6tDbwhVUp8cpoP7uNvowhAvAvdSuvOPmO+a+o+rB?= =?us-ascii?Q?E9rHpiYbIwFCQezPZfWI6sUog68NX1tfEuJzEVyXpMDDdMIpQaF82jqoQ5Yr?= =?us-ascii?Q?hYftqPvKNJkYkANJdg1tfGMr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2072.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d126c49-a5d4-4966-32e2-08d983530119 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 14:11:17.2859 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yZIZ3XSsM2At9qjneM1v+yR0znsuEIdiae4UnJa+5e0n/gxtyCav7T0yGQirDikbexJSzmQQCUhTFfVF2VF22g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1959 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for providing a very clear commit message. Reviewed-by: Ray Ni > -----Original Message----- > From: Lou, Yun > Sent: Wednesday, September 29, 2021 7:53 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric = ; Laszlo Ersek > ; Kumar, Rahul1 > Subject: [PATCH v1] UefiCpuPkg: Cpu feature data stored in memory may be = migrated >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3634 >=20 > The memory allocated through "PeiAllocatePool" is located in HOB, and > in DXE phase, the HOB will be migrated to a different location. > After the migration, the data stored in the HOB stays the same, but the > address of pointer to the memory(such as the pointers in ACPI_CPU_DATA > structure) changes, which may cause "PiSmmCpuDxeSmm" driver can't find > the memory(the pointers in ACPI_CPU_DATA structure) that allocated in > "PeiRegisterCpuFeaturesLib", so use "PeiAllocatePages" to allocate > memory instead. >=20 > Signed-off-by: Jason Lou > Cc: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 6 ++= +--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitial= ize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index 6e2ab79518..e9eba64914 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -153,7 +153,7 @@ CpuInitDataInitialize ( > CpuFeaturesData->AcpiCpuData=3D AcpiCpuData; >=20 >=20 >=20 > CpuStatus =3D &AcpiCpuData->CpuFeatureInitData.CpuStatus; >=20 > - Location =3D AllocateZeroPool (sizeof (EFI_CPU_PHYSICAL_LOCATION) * Nu= mberOfCpus); >=20 > + Location =3D AllocatePages (EFI_SIZE_TO_PAGES (sizeof (EFI_CPU_PHYSICA= L_LOCATION) * NumberOfCpus)); >=20 > ASSERT (Location !=3D NULL); >=20 > AcpiCpuData->CpuFeatureInitData.ApLocation =3D (EFI_PHYSICAL_ADDRESS)(= UINTN)Location; >=20 >=20 >=20 > @@ -205,11 +205,11 @@ CpuInitDataInitialize ( > // >=20 > // Collect valid core count in each package because not all cores are = valid. >=20 > // >=20 > - ThreadCountPerPackage =3D AllocateZeroPool (sizeof (UINT32) * CpuStatu= s->PackageCount); >=20 > + ThreadCountPerPackage =3D AllocatePages (EFI_SIZE_TO_PAGES (sizeof (UI= NT32) * CpuStatus->PackageCount)); >=20 > ASSERT (ThreadCountPerPackage !=3D NULL); >=20 > CpuStatus->ThreadCountPerPackage =3D (EFI_PHYSICAL_ADDRESS)(UINTN)Thre= adCountPerPackage; >=20 >=20 >=20 > - ThreadCountPerCore =3D AllocateZeroPool (sizeof (UINT8) * CpuStatus->P= ackageCount * CpuStatus->MaxCoreCount); >=20 > + ThreadCountPerCore =3D AllocatePages (EFI_SIZE_TO_PAGES (sizeof (UINT8= ) * CpuStatus->PackageCount * CpuStatus- > >MaxCoreCount)); >=20 > ASSERT (ThreadCountPerCore !=3D NULL); >=20 > CpuStatus->ThreadCountPerCore =3D (EFI_PHYSICAL_ADDRESS)(UINTN)ThreadC= ountPerCore; >=20 >=20 >=20 > -- > 2.28.0.windows.1