From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.3851.1632883307488691993 for ; Tue, 28 Sep 2021 19:41:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BodrPmwM; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="310396946" X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="310396946" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 19:41:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,331,1624345200"; d="scan'208";a="587793676" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 28 Sep 2021 19:41:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 19:41:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 19:41:45 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 19:41:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fES4UJFdjJ64rxGLgSP4os6A1Tf7uUzVYePImS+kut4tCpFBbtRjBmJJjFAa30R5NsguPLguKPyUN1RxQYxpySViTXIkAPguma+cB7TlYLwPKvZSPDvGqc3gU/sNFnumhNPykm5IlY7uO9vjjExKTkW+NoSVyq2CcSp2nTwlUeRls8TkJa0wkxn6Ybx9aJ69DDY/YHE9TFDlSWNM063PYOCaUfr5+e7Y9likj930vNVNzttmAslNpRviXKY2aXN3RSAJGYHGLoIN2MX90z3VvBT7r426pb0XPLJLSVeM/nOESjeXQ+d2UZY6BITG4YWNYh/fiple50TG6FvT/AWwNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7frS4znmx6+P7/tlSYooN4lsYT7jznp9a6Ob6aWivxI=; b=BvofNbOUYw0ZkkkQMdwwYBx6Sko7zvQgOd2N+xeIJmsvSBM4fhEew/Tq8XZH2UyWSyyyfkWWhUYsFSKJmb/TO/aQ3E2+nQw1Ak+8oPQDnuO+RFaidu4RR5PUTF/7FKEBIH2YyQTCUImCqySWAhDu55wc9zVgJMa28jAkbpegZkaZZ+G5HwotM0QVs1rPXQPJTmNDK0thkbcs2GKdRyRruH2thLCVlhUNybRfMem6H1sgMQKPyp6sq93J2/VDIxaeIPjc31S8l8fDDTNl64PmgXp06TGPjJ0qZ3GTC/1qw+rvDkxdeg85JOD2c8m4S5MAy5XMXXz4EOeTO0hUd7KkwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7frS4znmx6+P7/tlSYooN4lsYT7jznp9a6Ob6aWivxI=; b=BodrPmwMK1F6IuF1rGqdy5QJ5IOXfkdZUqn/fQeiWJ/YwvveNbNS+mCkKdnel8d9a+gGXoOHrOIT1INwLiMqijDM4ZMePu0KEXqUOFpqnXnz66HfdK0iPqvPAH6DRpfRGyeNqCVw/zltxjk7igRSRwMl6PmXPTZ8CElmLufYqKY= Received: from CY4PR1101MB2072.namprd11.prod.outlook.com (2603:10b6:910:1d::15) by CY4PR11MB1879.namprd11.prod.outlook.com (2603:10b6:903:11d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 29 Sep 2021 02:41:41 +0000 Received: from CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f]) by CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f%8]) with mapi id 15.20.4544.022; Wed, 29 Sep 2021 02:41:41 +0000 From: "Ni, Ray" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Topic: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Index: AQHXscG36fGuyEK78UeKENdUambyAqu1nY7AgAEIm4CAAhHV0IAA/osAgACcsZA= Date: Wed, 29 Sep 2021 02:41:41 +0000 Message-ID: References: <20210925035903.1644-1-guo.dong@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7014c048-822a-4f44-dacc-08d982f2ab0e x-ms-traffictypediagnostic: CY4PR11MB1879: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b+ZCDktW6W0/4ks+D3+dFdmjIP+DmcyyGS4HCtgdyVXV+Yj5v0utaahO1R9rJY5P/JHa4tf6l6G0KGLUjh7xFeyNoCWEJfT4QzIKDMJyZv5zahPr8+mVwyycX8eRgirRKkBdQEWZUN2QkLXkgi8eg8zPkyoZMwqE5A/cvXPWA1LhAUhKf38zpoudZoRxvgb+dQzj47mL5HCBsnKcKFGo86D8gCy+0ZFmH/wdECun46hM8fJ3cB3bHY8fJHku4jaIatHlSQn9fpe71JX0kbUA1d/uDJzQ7pbcJrEJ8nl+sO2YsebH/zcXeT3Ua2B0rfmg8VhrsePkivHp2YZY9JLrmURgHhK6XJ69Spl8lHMaz7KArsjjiNc2Ye1SA097ruBoqDip+r/AppV4Ofe5RxCxTOnHyKy6Mn4A9G8YXLZ/edX1IN7FVfbUl2tb6lE2Am1FkKgA+usFVjWN2DesO266aPR/1d/yBjcbmWy5D5Z112KyXhoz77oef2jJLXnEqeVUcf9AMuZI3gD18IZG+r0i1T4so9f9uyDYsGW/slECEB1nZamAFMujJw02gnoTGHIaL9XwD/ZtG+P+K/ByBp2dxYiisCOX0xFLVoSTo8EYYywGDn4e1PwVDz8F1zq6XY+qdWY6QSd3Qs8gG3ogSqDUyWwJSczssM91IKlq4lplLD8VE2AbcwGSvSNSJJdiuuGAf+Zs/nYmTRshUGnps/H4vY46QWWPfgxgZtB/W1MReXU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2072.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(110136005)(54906003)(316002)(38070700005)(122000001)(8936002)(7696005)(186003)(38100700002)(71200400001)(66476007)(26005)(53546011)(6506007)(8676002)(33656002)(508600001)(107886003)(86362001)(9686003)(55016002)(64756008)(4326008)(76116006)(2906002)(83380400001)(66556008)(5660300002)(66446008)(66946007)(52536014)(81973001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p//fm+DbHlrEcYCZxH01kCy8W6ELZ0Pl9ed5x2oBEccGkDDKWetKrXhuSgQM?= =?us-ascii?Q?49Bjkpt95VbhEVgPVeG+vX9COihmhgQNiHdQ6HcpIbiPoXN+/3pJHpW2euHC?= =?us-ascii?Q?27RPXaSR/3woOiXyVpy5MYWSk5ThUPa0Ij9RUnLO+C8cGvlieuQYut6dx3eL?= =?us-ascii?Q?Ga3IK6aPZPfaBXsVATkTULV3H11gRm+YS738btXuGbXLAWkD41VOVpLokKzm?= =?us-ascii?Q?Vk7+GVf4B1gn3JuKtkipmfw/N4GZ/QBDqhSFfEZgA3kZmrxmPJE+yQYDQL38?= =?us-ascii?Q?TApzOpMzeBRNeDWwZPGLOiqCYto1Zcx/Bh6EvcW1pBEyHEaX55DJMvVE9Ky9?= =?us-ascii?Q?YTMzYQHY+LFB2R6wcPmAOf1igeMNsCY4g32qFbDCjrN5N+lNLWhv0HpCqUAR?= =?us-ascii?Q?mZPwCr5HpudpriobY16LUbL4mzdyM+1DMOOBNyRFq+lMMNrWbBqXr1mw64vo?= =?us-ascii?Q?Ssk0V/qKeHQdJ+ottCr5SXyc4IdsTymYqQqoX6t8HUdQJgNu6hpIJPI38xJ2?= =?us-ascii?Q?L92P0ZExkk9oLaWyL6vAQjwr41zB2zKm+YO/h4+BPXJaahygxzlaofuZKI3/?= =?us-ascii?Q?p/fdleZrKMaQMf2J3Zt2PqylBo1VrET3HvHZDeNK2FST9xTZiYBiWTiWAzb+?= =?us-ascii?Q?yVcCqSI93Psr5Yu0gUtLALe+LLB4mDaCEq5O+IPmzS3fkEqU+cjv8Jy0xB0G?= =?us-ascii?Q?fwOpAG9D0lFymKLCstTFeGu3m0eyUzZhhwnrK2nCqlCzAhxjFvap7WOdrFWp?= =?us-ascii?Q?SE2e/AniNzDfv4+/OQpWmfIsbNR9TCMzByKbReO1D6IBK86ffcxsapSVILUZ?= =?us-ascii?Q?I5VY46mVqzkgtB3Hi66tlR15ynDzYUDmvuqcA+c+/09BuAuaMb4DTGWW9hgQ?= =?us-ascii?Q?fw5fGOymSx7Li18mmy0jyCwlKKY70nlN0s4uCv8qDGS/68saLYV8afZ5GmVM?= =?us-ascii?Q?91lHI7FZaoMQcjxP4UNarwjyfbFqKFD7cShafhXHu8FPc3mSEvgNoc/qS3be?= =?us-ascii?Q?BU48qnqQSn1158gNJpFqYG3bZq81UNCy1Gej84uqVnBdlu3YZpluru59hdas?= =?us-ascii?Q?rJyt4mrvB3XougziC2VAcTAuL5CGrirWjb76Avfov/F5SBTKOEqaTRhQG/hT?= =?us-ascii?Q?TzmwLPWG2TkkLoV4pRN3BUBxMBVy9YEnntTgp7Sff4A8zv1psPICeWlxRm+Y?= =?us-ascii?Q?RkyXZPjGaJRpIWDfc2hi4A9VFXG9VXCxmw+jfrSj8mwpWR2Jswvjk8YDHNPa?= =?us-ascii?Q?AexNl10mTNU+NcVGfWhdfHbvKHV2uQ/qcZ+MZbhLgv6CUuJcqCQ2mz9Iqdee?= =?us-ascii?Q?R8ouFkTxOgAQ7fYf5pGqP26j?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2072.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7014c048-822a-4f44-dacc-08d982f2ab0e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 02:41:41.2140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R6WF2kR02jZWml/rI8rsk4sZ180cuGFcYBKH9W6aYOFSs7jWBl5BPTxVNFLfRxIXJajcNQkqIlxB8RpcAFtR1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1879 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Guo, Thank you!:) -----Original Message----- From: Dong, Guo =20 Sent: Wednesday, September 29, 2021 1:20 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootload= er ACPI table Sure. I updated the patch per comments. Thanks, Guo -----Original Message----- From: Ni, Ray =20 Sent: Monday, September 27, 2021 7:11 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootload= er ACPI table I prefer we still let caller to provide the HOB pointer. This also eliminates a global variable "mAcpiBoardInfo". You could change the BuildHobFromAcpi() to return the HOB pointer. So that the pointer can be directly passed to ParseMemoryInfo(). Thanks, Ray > -----Original Message----- > From: Dong, Guo > Sent: Monday, September 27, 2021 2:32 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > Hi Ray, >=20 > In this patch, we added a shared file AcpiTable.c for both universal payl= oad and non-universal payload. > The exposed API from this file is: EFI_STATUS BuildHobFromAcpi ( IN = UINT64 AcpiTableBase); > This function will build an ACPI board HOB based on the information from = ACPI table. >=20 > For universal payload, it calls this function to build a hob for other mo= dules. The main function is very simple and clear. >=20 > For non-universal payload, ACPI board HOB is used in the ParseMemoryInfo(= ) callback for PCIE base info. > So we could get this HOB from the caller, or get this HOB inside the call= back. I select to do it inside the callback. >=20 > Thanks, > Guo >=20 > -----Original Message----- > From: Ni, Ray > Sent: Saturday, September 25, 2021 7:48 PM > To: Dong, Guo ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > - Status =3D ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); >=20 > + Status =3D ParseMemoryInfo (MemInfoCallbackMmio, NULL); >=20 > Guo, > I am curious why you changed this part. > Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from= the parameter. > With the change, it has to locate the Guided HOB itself. >=20 >=20 > Other parts look good to me. >=20 > Thanks, > Ray