From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.8610.1632795050811229545 for ; Mon, 27 Sep 2021 19:10:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XQYaTZSS; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="211687562" X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="211687562" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 19:10:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="587040658" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 27 Sep 2021 19:10:49 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 19:10:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 19:10:48 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 19:10:48 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 19:10:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxVemFzWgI21ovaFatcxxi9WPV9gTiH7pdXhs49ENTIwV41c8fHk39q11dwYWbmzP1PaPo9OlLgi34DASky9bNJNOEESNgUgvG0wx1rZdTEpIyU7f1z2a7hGHxTtoJrFsct7dQzMEBesy7lkiHW3MhPrKjacoJKkglhrIENXudRVrC8ChIMC2iJKHplzht2p6DQ43YScKsKUFY+Au7WbdHunYjzAuS2QjslRBKO5nWWRCwWxLwqMg2uit+HAqTauu6j3EGnJoBH4vkBBF+9LYVRO+0DTm2AwgZx7rR63J+ZxI7Ei94S0KIOHeurrzW0eViwNWFmJKaAW6l/MAcVsMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kuhwm74uGiCGgGPV0N8WupM75HWrxQAkrqyW8BS38qA=; b=mM88YkWzhPy5Qo9Q+Ttl/2sSwQKoi+bBWLMxdJ4ZBJ2jG8rDEukvt7Rx8iWDHm+NxKUJLkvn37zaLouwm91Ar8AEspZaC5Lj9tJWt0n9EfRviNfkjGh58oyNAnrWjSyo1BRR1XCeDG39kysxhYl9VLMJJKMD3uOCaXIW3oveLJW0TzKuvHjR/Ut4o6R/bppen1yHR7kMwzrd6RjhQUluekY4QGZC9agQRvHMCi9w8jXBD9OIavzkpCphmowt0RAjwDVJCJBjrLAGnMRlK66jxxClIgY+ewVq2c5QzrtELNyPNGNUSxQnhQTCgU05BRkHNILZOE2AMNM8W0Aab0McpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kuhwm74uGiCGgGPV0N8WupM75HWrxQAkrqyW8BS38qA=; b=XQYaTZSSCjTVWgHh8Fm7Il4Iaxj1ZRVSc90I3nfp8t/u/2UGG8CdFFL/oPEPHLRmYdHS1Y7bnvfXidqa0nygjzXeN++FV7pBzMUsWJzwpZa686/EtZQHLTPb9BUuFwWYBsfe65B6QTJGymExwMLGZfO+iQnURl9AiT+FWtq0hdA= Received: from CY4PR1101MB2072.namprd11.prod.outlook.com (2603:10b6:910:1d::15) by CY4PR11MB1383.namprd11.prod.outlook.com (2603:10b6:903:2d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Tue, 28 Sep 2021 02:10:47 +0000 Received: from CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f]) by CY4PR1101MB2072.namprd11.prod.outlook.com ([fe80::7dc5:34b5:bbff:832f%8]) with mapi id 15.20.4544.022; Tue, 28 Sep 2021 02:10:47 +0000 From: "Ni, Ray" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Topic: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Index: AQHXscG36fGuyEK78UeKENdUambyAqu1nY7AgAEIm4CAAhHV0A== Date: Tue, 28 Sep 2021 02:10:46 +0000 Message-ID: References: <20210925035903.1644-1-guo.dong@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ddcf59e-c692-4e8e-2377-08d982252faf x-ms-traffictypediagnostic: CY4PR11MB1383: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lvDoLilUCwtGZBbfjK1Ji9AfNEJpwMojOvKgB2GaFFBv7EpQMfTzL1rz7a4XvDBza4k5f2LrxxoW4ojsXy05aEby36iazTPM8rEAcdLzVtk9B0UOa40DEbeCWA7LYYyQplb5zIJH3GP7DSL8CnD3GQWxFbfr8ZRzBtPyAr1k3VTF12KTX5pGEUtjsrpzN95MF1v6ci3Uy/t8ai1Pf6ah8NYAaJz53NbI/r1FG2AvEF4llEj3zMIqW+xvTANrgaJIusWM8ZYnCJDS2oWcVXlJjGUa9bAp2NcMLHCBTLQWgTrxnICTGIJkv9m1vRirawo2l1iQYPZ5ZZtX4jIeE1MEnL0vUihjQkx0QiZZaKyAISVU5JCMHLvseNKAJ3uQjhqAkSEVkmHI/hGg8v8D8AVs6GZBgrvEhlQyjBT5LwjO7Qn00T5w97TFGryDKQp536cLU7leays6NlWThtRxDt+w0Ks2Rpf6R8tApZAlR1s5NxAgJwVA8I76V3v9da0txWPcHyLInwT3hXei6kVtrZnor0wiH2EV+ajJnu7WmDlHMyhvTfIi4bk+IIvMQ65mSLH0zwjQtyDXLSj5Uf7QH17T/ksg6M5vKrg9Fa8QWVKG2tDGYjNr/Q1139QLPbuOLijVBbK9o0Dm5lleLmm2p0049L2in9el/tYDXRuXvf+KkriB3vPAu27H6KZAlaIseDzAIpWp2Qr2Iaz06zsev2iOqX/vO0GYS5uIhnktO60b7Uc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2072.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(110136005)(8936002)(9686003)(107886003)(4326008)(316002)(52536014)(8676002)(71200400001)(83380400001)(26005)(38070700005)(86362001)(66446008)(64756008)(38100700002)(66946007)(508600001)(53546011)(7696005)(6506007)(66476007)(66556008)(55016002)(76116006)(33656002)(122000001)(186003)(5660300002)(2906002)(81973001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?deVDFKg9mb1FwGUJ4Vem+OL8FiRSSCY/IXyjdnt+GGdCC3BT68kFmtiYs6lS?= =?us-ascii?Q?c7R1X6r6NVOtrE2iukgkVapUXCY5pq1Z6db/Eepo/Em7/exwtmalfBUIN6p9?= =?us-ascii?Q?AmMenOu4y3Kg7vRjmeQZfVa1RXIVdig9dKYcq6LWHhZTtb7Ok5P6PDkmlEOw?= =?us-ascii?Q?BA3CrD+HdwY9q6iCK/bgccNYWO/5RCZjZmagDhWT+cEBuZALYwwOv/QxZCqm?= =?us-ascii?Q?v5p/ClwGwFoQNjwrbGy8i7bjypWqJX7VVIQ5u7Ib5qM75qSIKrnL1ZREAIaG?= =?us-ascii?Q?e16w7v8qTPfVblYr/vAcDdUGiebSfb0fFdMEmhVSA1EDw+kkEEnRiaJb/Oso?= =?us-ascii?Q?3KZfnPQ7fPKNcuX8CvMm7j/8aMtp+XhNpbt9s/cH9tkThmTVITNBTly0E4UW?= =?us-ascii?Q?OzIeKQy1x+wHwU0tvS0fP481B0XeQAyT0efTrskcoAHdMiUkiXJf41FdZuTC?= =?us-ascii?Q?RGQD+Bj5x+3CBBzA3vx0dDG2lvqOtjeXtnHkaXcBJVWLiSWX9JFw3dEbjjTv?= =?us-ascii?Q?N8BIykO48Fbyx8ivluuEYiepabjnFrAIpbZftMSExKe+Zda2edHQOlgqnMys?= =?us-ascii?Q?SeVpJC7J0uJihx3EMiotWctWFof96/4XGIknDPEEusg3X7M3klEwWmdXHAM4?= =?us-ascii?Q?mnst4QIpIlOafRA0ExUWMlLvzf3CmiuHVJWmKRrlzajSMO/xVrHzV/0MMvd8?= =?us-ascii?Q?akVwTDBLE/xrqL7J37KSQLj07kXfIxT91lBis4Js9eeJDRn3xRytYcX0ug/c?= =?us-ascii?Q?KNZDeXFRuPs12W7PXthjgmLBU4sIR8nVAoKvi9MJNXbMgaalDmoB9nBejKnf?= =?us-ascii?Q?ZjGG+cixVis1q7AXU3opanJ1uqlRnDNQS17iiLIj8YLNJsQuMS12T/sbeiQo?= =?us-ascii?Q?T/bI5VcRAMU3Gy28BGF4cFmm8w+Uj6ic1XwSBUHfw8vEphClsEbgGjwIVzyi?= =?us-ascii?Q?gBNx0YdJEo+16SvzrVW6lK9Q/wG+9wmqBmsz5V7pdyL+tCQHXSf6KAv6mOIX?= =?us-ascii?Q?JPe6QJSl9V73VZZyw03bU1hbybDsP93WmYljFaOSlcdH+xAK8z/kdNqYd6h5?= =?us-ascii?Q?msJRl0r1It9iazJxzd27pHhpR/Om5zIQvwSyP6zuLfDnqBg4183VZEFfjdGO?= =?us-ascii?Q?zwQJiqVtmq047fyYRgTjs3NEIO/b2GvfAmKM+OsDqy3enD3hyKkNDMLQxVhi?= =?us-ascii?Q?2qsujbhyk9svCLHgK6RNJ0b6mK81fUfXckFPeDK0XNriYu8kzrkRpHi6Buzl?= =?us-ascii?Q?Rk2BPWf0KXQiWHHCwKBSc9rKVF7yEdEmJ/UoQH7/J21qqfoGj3xFkrK31QtH?= =?us-ascii?Q?2ssAF0QjjjJQ8B7WfVhNoguk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2072.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddcf59e-c692-4e8e-2377-08d982252faf X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 02:10:47.0005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3eF3TvSIRyXIukbosT0WQQU3L120cU+t7Rruvh5E7EEjqwzdDJ3zm7t0bJZWO9FBwoFq3gxX7rLB5uPGHE7QoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1383 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I prefer we still let caller to provide the HOB pointer. This also eliminates a global variable "mAcpiBoardInfo". You could change the BuildHobFromAcpi() to return the HOB pointer. So that the pointer can be directly passed to ParseMemoryInfo(). Thanks, Ray > -----Original Message----- > From: Dong, Guo > Sent: Monday, September 27, 2021 2:32 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > Hi Ray, >=20 > In this patch, we added a shared file AcpiTable.c for both universal payl= oad and non-universal payload. > The exposed API from this file is: EFI_STATUS BuildHobFromAcpi ( IN = UINT64 AcpiTableBase); > This function will build an ACPI board HOB based on the information from = ACPI table. >=20 > For universal payload, it calls this function to build a hob for other mo= dules. The main function is very simple and clear. >=20 > For non-universal payload, ACPI board HOB is used in the ParseMemoryInfo(= ) callback for PCIE base info. > So we could get this HOB from the caller, or get this HOB inside the call= back. I select to do it inside the callback. >=20 > Thanks, > Guo >=20 > -----Original Message----- > From: Ni, Ray > Sent: Saturday, September 25, 2021 7:48 PM > To: Dong, Guo ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > - Status =3D ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); >=20 > + Status =3D ParseMemoryInfo (MemInfoCallbackMmio, NULL); >=20 > Guo, > I am curious why you changed this part. > Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from= the parameter. > With the change, it has to locate the Guided HOB itself. >=20 >=20 > Other parts look good to me. >=20 > Thanks, > Ray