From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.3347.1587635896600132267 for ; Thu, 23 Apr 2020 02:58:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wsNv8uaR; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) IronPort-SDR: H2fMa28R8ajHRQ+xkkSMYxwZviXJ38MTYiqjHXYZnLJm/dd+ihBq2eR5B/upwmy9EQTCIkDT7d uBD6+4HHnCLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 02:58:15 -0700 IronPort-SDR: gGI/vBdiJaXGgw9CvBUdUg6+ZJvrzY6iZYBA1PbBqKw7YQCEod3tUcVUaPaeLmbrKtpNkqPGUZ rJZo0xOeG+iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,306,1583222400"; d="scan'208";a="274181929" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2020 02:58:15 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 02:58:15 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 02:58:14 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 02:58:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gPd1CWBjVV0DzPNTSSrKD07QdROZYYJ3x4xU8rRzlPYfOR/Y4rroVIouPd21KtPCpMGa6utZz5SRJN99k8Y2YIqg6jq4BdfdaoLO1N/xEDmY6ncxyqjjFaXsE1iItou3pIzkyMzExdidWnyZPjILGDb8B4tBQCvR8u4oauE0Q49ELRA3s1Vd83r5cuR9JsW7d/OlSeYImkik43F8DeaotwAJmMjzzKGovTOYdSRXjFI719wI2Rm8Hy40NNObmusg3T/H8UpMlVrBn1jCYCrcOvDPyrGQcEatAghDuLRrQiTJs+1BAYFGIBnfpsQD47LDJvmbWfixLr+kouj9ky1efA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbaEdh+p64o/BFYSeXhcC1due9//VKoTdnMJ9vvZlq8=; b=c+JJ867W2QJZPhyIXX5eUTlsGWDdtDrAjYvD1XODqK4jq21u08WI2oHe3cnW63uUPAXr6Usi2YI1AIYVldx20Z0ilm0A9HV8K2AKVNQPYAojQ6Cci+fegMpDMA6GP3/JWdZ9CQ3XvQOLrLujHoGIMUBPXGYbUcy3mwdWAI18KABMZ4mMhSRvmJ14YYTyElYsbHTB/nyXeBpXGrbikowmmhtWThy4rXqJYYd0r0FpAWhhSqNLNDCHpU+Kl1H3D12E0TBY0s5Ce9qcSFOatriqI0W4b5FIIoFAaMVighFEEaKKgdupj4nhKS5KZz5GQbYTHe6TB7PlnntlZsRg/JkDOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbaEdh+p64o/BFYSeXhcC1due9//VKoTdnMJ9vvZlq8=; b=wsNv8uaRLyiX+0r3N58QLOwHCrvPsI621eTKDfHWP7AanyAoq8MtAXAPUyzmruUeZ+ZHJ1rjfrRi1h9x3YVFwBC7FuyLLSkURlCKF3b08TMiuvuq3OvLGsqUc57Y/H9xDQpS2HxqLlZWdfhUB3shS8dxiMX0lwj/7upIJI9ASOI= Received: from CY4PR1101MB2230.namprd11.prod.outlook.com (2603:10b6:910:1c::20) by CY4PR1101MB2261.namprd11.prod.outlook.com (2603:10b6:910:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 23 Apr 2020 09:58:11 +0000 Received: from CY4PR1101MB2230.namprd11.prod.outlook.com ([fe80::2006:7efe:c58:ce16]) by CY4PR1101MB2230.namprd11.prod.outlook.com ([fe80::2006:7efe:c58:ce16%3]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020 09:58:10 +0000 From: "Gao, Zhichao" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Fu, Siyuan" , "Kinney, Michael D" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions Thread-Topic: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWGUu5p41i+WCZ90uhoKy+Bp1mUaiGcQfwgAACOiA= Date: Thu, 23 Apr 2020 09:58:10 +0000 Message-ID: References: <20200423084627.3384-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F9FCB22@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F9FCB22@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhichao.gao@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a912a060-5caa-4841-afd7-08d7e76cd4d8 x-ms-traffictypediagnostic: CY4PR1101MB2261: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR1101MB2230.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(346002)(396003)(39860400002)(376002)(55016002)(9686003)(2906002)(7696005)(76116006)(19627235002)(26005)(33656002)(6506007)(53546011)(64756008)(478600001)(4326008)(66946007)(110136005)(54906003)(66556008)(71200400001)(66446008)(66476007)(186003)(86362001)(52536014)(316002)(81156014)(966005)(5660300002)(8676002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b1bDId9QL2ItRxKPzMcX4gimjsOA4yn5r+U1orEry7eO6nT8oy7mwJQzwA7E9XX6AmKwqLEqYjl1qVOJrUPAMrtOhKaSZanEiYt9xFw8N2EZkVM508pJrOUbs5/voIw2e3z+WD9SAnQNUmN+KOS16ft9JQRqTlDoKXWYSA/zW+Cp1cEh0Hjd6pZ/mH9g7tXyP6Ie8vtF0fydh0AIuuz/fqDkrcMcwmk1cNL7Mfz1qeU4oUnDzv++MtxqX1Os5BuASDJOAWxAABWspZb6qd2RGK8LAj32tFp/e6ZI+XHYgEaOfjNUC65qh/R8gRiVlRQhmfHe7kD7Ymc85QqQXWqziB+d52KhQZbF8AN7gMG+Exzf30Mn35Cafvyuw7hLup1YCHgXwr2qszRYZfkIE2yYDiXXOoZLiDLZftpRuElOhxvtN8J7Ssn6r36gD9pzcZk/XbxWOalehMcJxQVe0xC56i8WqqFDMhXtwSRThT+PUKlpEArq45JxDof9fq4gYLgKtM9CR8VHOGxVn1Vdd49D9Q== x-ms-exchange-antispam-messagedata: djiZkJZspfsTadXzsdU7NAwh00CzvkYom2olRz4UDb5jGJq1815ih672TFh21xrwYjnUXDMnDRvUfH0smwWKZXrSadLy1vh+XUoQw7oHzSj7ME8VkZWbPbTfcwfpUZMnQFwHfvze9TIn92xYe03veg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a912a060-5caa-4841-afd7-08d7e76cd4d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 09:58:10.7420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qIhnk6Nz76iYM9QHafnkmsKzCvuWU2XbO5//6peeLvLIvrE3zFXxNeeAoj6pYzycDIVMUB5wqCfVnLx2lQ8Xaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2261 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. Here is the main difference VS V1: 1. do not remove the field in the internal protocol structure:=20 a)directly call an assert function and return an error value. b)change the related field value to 0 to indicate the function is unsupp= orted any longer 2. remove the HMAC MD5 and HMAC SHA1 3. using OPENSSL_NO_MD4, OPENSSL_NO_RC4, OPENSSL_NO_DES to disable the bui= ld of related function. Remove the source file of MD4, ARC4, TDES, AES EBC = source file in the OpensslLib.inf and OpensslLibCrypto.inf 4. do not contain the change of MD5 and SHA1 because the change need to ch= ange the platform code first. I would sent the patch after finish the chang= e for platform code. I know the V1 get lots of feedback about the protocol changes. See #1. Thanks, Zhichao > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, April 23, 2020 5:31 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Fu, Siyuan ; Kinney, Michael D > ; Laszlo Ersek ; Yao, Jie= wen > > Subject: RE: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecate= d > functions >=20 > Hello > I think there are lots of feedback in v1 patch review. >=20 > Would you please give a summary on how they are addressed in this v2 ? >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gao, > > Zhichao > > Sent: Thursday, April 23, 2020 4:46 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Fu, Siyuan ; Kinney, > > Michael D ; Yao, Jiewen > > ; Laszlo Ersek > > Subject: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated > > functions > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > Retire below deprecated functions: > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > Update the Crypto Driver's version to indicate the binary change. > > > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Siyuan Fu > > Cc: Michael D Kinney > > Cc: Jiewen Yao > > Cc: Laszlo Ersek > > Signed-off-by: Zhichao Gao > > > > Zhichao Gao (7): > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > > > CryptoPkg/CryptoPkg.dsc | 46 +- > > CryptoPkg/Driver/Crypto.c | 62 +-- > > CryptoPkg/Include/Library/BaseCryptLib.h | 481 -----------------= - > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 ----- > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 -- > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 -------- > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 ----- > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------------- > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 ------ > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 -------- > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 ------ > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 -------- > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 ----- > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 -------- > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 ----- > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 -- > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 ----- > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 ------ > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 ------ > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 ----- > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 ----- > > .../Library/Include/openssl/opensslconf.h | 9 + > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > 31 files changed, 75 insertions(+), 3486 deletions(-) delete mode > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > > > -- > > 2.21.0.windows.1 > > > > > >=20 >=20