From: "Dong, Eric" <eric.dong@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
Date: Tue, 23 Mar 2021 13:48:41 +0000 [thread overview]
Message-ID: <CY4PR11MB12720CB017AF2E97177348AEFE649@CY4PR11MB1272.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210323011527.437-1-ray.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, March 23, 2021 9:15 AM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.
But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.
This change updates the accordingly comments.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
.../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
/** @file
PiSmmCommunication PEI Driver.
-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
+----------------------------------+<--
| EFI_SMM_COMMUNICATION_CONTEXT |
| SwSmiNumber | <- SMRAM
- | BufferPtrAddress |----------------
- +----------------------------------+ |
- |
- +----------------------------------+ |
- | EFI_SMM_COMMUNICATION_ACPI_TABLE | |
- | SwSmiNumber | <- AcpiTable |
- | BufferPtrAddress |--- |
- +----------------------------------+ | |
- | |
- +----------------------------------+<---------------
+ | BufferPtrAddress |---
+ +----------------------------------+ |
+ |
+ +----------------------------------+<--
| Communication Buffer Pointer | <- AcpiNvs
+----------------------------------+---
|
--
2.27.0.windows.1
prev parent reply other threads:[~2021-03-23 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 1:15 [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Ni, Ray
2021-03-23 10:09 ` Laszlo Ersek
2021-03-23 13:48 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB12720CB017AF2E97177348AEFE649@CY4PR11MB1272.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox