From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.9184.1616507326080885332 for ; Tue, 23 Mar 2021 06:48:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=baaGcN2Y; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: eric.dong@intel.com) IronPort-SDR: PZNHTbE4FB4bm2k1sV/F/A4XXYEt79Dk1lAZSFppUOFhQbHFe5pAt+4rcKUwIXT5NwTj5o+CGe Js3e3hoVp/8A== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="189879264" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="189879264" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 06:48:44 -0700 IronPort-SDR: aQVoRZQ9jvv8UjpNE+b0UjFULLlTkxU55cYXBW16WbGupeyz32OyclJ5xN5qlDRw6jZ3806Cr2 iI5xWiZnzPiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="414991728" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 23 Mar 2021 06:48:43 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 06:48:43 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 06:48:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Mar 2021 06:48:42 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Mar 2021 06:48:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeXvkgNNMsPw7w0FHrM+jG9mceMLwjPD2uC+8OH60TRLfmQdQystgwIJshaF8nmhEdxyy67tbeFCxZdviW/5ROandbJNeEY3XS84WEEJbaoXX2pJqbLi9KhQjRq4J5ZmePt6qrVPCPoHHpdL/9wo3wsg+epxpkGN91SyYGoGsMJ7yuSTeo2b/AncqNehl+oAu2tiyzmDeosAuaYkHP2Fmn5yh7QOhFkcQmunirznkphgpIPHzyZq6VNwJN+BfTJDxfEYp6Z0l6R338gEt/EycAMUAQ73MoozmjCYzVRvElXPl1R7Q5ikgENsj1n2RoPDBA9fhayrx70JF58kyucAyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdkRJOOAihMAGChjmD953UfS58At1MAFLpMTJ56CI+I=; b=Ap4102x+ESZOyQr54f3Nw1kVjsqUk6R8xNlZgs4IdFhh5U7yiBxRA6kNo5ZfLBBC4zqtanTGKb/9ePEjmrrktgpUg7I3rfe4WdSrRxiPCuW6WJ14mPQi564qhy2todEnUkmS0egT8/uW/h1w4Q4hf2rS6Nn+1toCTkSNxW6kH28/i6LlTNief1L8s4wto27n1tubKq5yZUNVpSSQkFteJOELsp+/R/85JPI2SFo92bWrlxyBN3XPUWe+ww98HWdidyT2II2V2IF7Q+EugEC1zt6jOevoDc5Zd5jaO3gzD2LVkWl1FjmEDgeYcpNeOmLEEbTq1UpICx7++pIWV8nnGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bdkRJOOAihMAGChjmD953UfS58At1MAFLpMTJ56CI+I=; b=baaGcN2Y7m5h1e2jhexMLyXl0r0XxFk5gLNdEP+LrQCn4vWh13FyaXVzWiKEuvU6ybuYTDm7toafg7nHa3JqxRYEMOGIfxdIWZV7DkF6ZtdisCfe9b2IJWmmUu8F+/JWi4Ory8xly4idNCLgy1vYJOO+xyHCoG2mv3gomcF9roE= Received: from CY4PR11MB1272.namprd11.prod.outlook.com (2603:10b6:903:29::9) by CY4PR11MB1398.namprd11.prod.outlook.com (2603:10b6:903:2a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 13:48:41 +0000 Received: from CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9]) by CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9%5]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 13:48:41 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Thread-Topic: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Thread-Index: AQHXH4ILkzxnjf7KhEOelJ7EPJ6TfKqRl1XQ Date: Tue, 23 Mar 2021 13:48:41 +0000 Message-ID: References: <20210323011527.437-1-ray.ni@intel.com> In-Reply-To: <20210323011527.437-1-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [61.155.142.104] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15fb3579-5921-4f5e-44d7-08d8ee025e9c x-ms-traffictypediagnostic: CY4PR11MB1398: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nAcorj+RqIa18Mk4JI/0lvN9gFP0cC5iH5MPmGwqyOC8YqSaFYlLXDHegqTxqvrQkCTdQ7x2ed438z3HgQqpgnBKwEtRq0rXS5GJTYzrR/XtZyAdHsioWr6JkTOtks5Gdo0VMLsC/12b2LO6Q55dLpfMER0YkOY1m4EU0KJvB9DEcA3LzQPzKlIWXT9poeTiF5PZzG8UjM75m2Bm1W06MFOPc231uakUnYg6Xc29G0paJSXVIGMwRmFni14cHKsJj6c3+G03hDRWXOPVKj8fSyD22TgYUbgmsm5WmlqszNT8drYQdzLh9qBaBC0HTK/B4G16wJYrU6QC6ggLQVxPrYk5M3uCanOyMFoR8PJ6UOxXDWot94wYjbo5Vx/GPkirG0cq/11xBPUqw1PY0CoNPNnUbBaj3b5tvVQT+kD7kuVQdPMQsGq4brjz1Xzg8O0xBINRBkT37GH9HkHPXad7/QeqoQ7b2JcPnBq+rzfPLa64lM+S/MAdgQ2jhGRLGQg7Cl650G7F/kIoL3Rvp6f/sf5A77GYhqNygywggsj/vciyuoloKqlxaZ8bGHBhDUibUGiy9ylgd4plfg8mNDg6Xm/0nG9LDxjhpFu/JTr9VIaN0Xa+daFbD8rDxSxQpp9ye9ngahV1HmmeZcCAr2O6XTrkCYq5Iv5CNeo+86cGrv8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1272.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(376002)(366004)(396003)(8936002)(54906003)(186003)(4326008)(33656002)(83380400001)(8676002)(110136005)(107886003)(26005)(71200400001)(52536014)(55016002)(316002)(76116006)(64756008)(5660300002)(66556008)(2906002)(66476007)(66446008)(38100700001)(66946007)(86362001)(9686003)(478600001)(6506007)(53546011)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rEmjNuyON52fDVOd8pImLHKdWI2c3152DHXg3Xr2GcNJPlnhodkfwdWFcdc+?= =?us-ascii?Q?ND0dIXCWtr7R3TTWbzFNvLneggpyVHknH4U010bv+NaRj+9CPq3zAypcfpNz?= =?us-ascii?Q?v32qtURW03IxFJ1xdxd8G78OA2Ac4hGXCbuQ3a70zZOFEhng73gcZgpVU6Jr?= =?us-ascii?Q?KiJtSHNsTW8keE3E1YLWnQ1KmmtOqt/318V83HniNoDzlkqJXXMPwqddjXOL?= =?us-ascii?Q?QFkjgsfxIyqbcEmeZ07eMeWfr06K98h8XpkWwQD4rIlOwHnyujBmQKhCJjvl?= =?us-ascii?Q?w0v8FxyHs61zyCkIAjxZAVht4CVJKbmxlre2Y3Fu34XnJ6rGWYs8KjCZ18/l?= =?us-ascii?Q?q02rInrRQbav86cWmZ9sQxu6ZWKbr2Xf7wyRVPiI9UJT+hFlCBT+71nanB/X?= =?us-ascii?Q?Z+Vy3cnLpB2sNdzV+YEejev3rCvvCjTf2Czg4sd/J3qQOpvmFGBYyRUuWsAP?= =?us-ascii?Q?zMaADJaR1QPEB/r3fbi+ZsqOeZNLjxe7egXq26SrOTx2rdD1skQrNLlvl/SL?= =?us-ascii?Q?yXE20A382D/p9wzsSBBADQXJdv03BOJuqn4HzjKAgz6M1XnF5HK8eNEfvmCC?= =?us-ascii?Q?+g0LlUF32/amDhxrrfGoensLeNq5vdFt/4JJoCGhnlezkhEOQv0ikQp8aCM9?= =?us-ascii?Q?Sni9R8VSbE/ZaDoGberW1aZDs2sT/vbAbtrO4eKdOu1jZTcnjIArleIAvPIU?= =?us-ascii?Q?/dd6paJUik7WTBiq0JmIMIWKBcuP0l8r7FN1hjnMycY6HTPU4JBn0uKkfrQa?= =?us-ascii?Q?9x/IE9Bt39q6ZXbDkx4FfMB9FBqbdPT8DJzcbHfg8/ZzeFxknQyC0z807C9t?= =?us-ascii?Q?Gt2EvAJUhCnTOneuGGG8VxiEqe/U9IP8ViCrrQjaqVZSbt90pxno+iDqKl9V?= =?us-ascii?Q?u61gqBAn58Gb5my7j0gdjm1N7ZY5hxPbGUuwmPgDO4mk1XQxW/mR6ge4IzVS?= =?us-ascii?Q?wpsCzGMr5ID7FrHRhrxYbj0wd1cJ0gNADoLsmvLPO7YYW7QWYA14wzqxYF0H?= =?us-ascii?Q?Xom1pXXqpPE3yiH4RwnWnIx5f6BURHoHBrGc7yVikx4kqyNQPs9duAvCk54J?= =?us-ascii?Q?gw+ASVWz8MSA/+CgEEApEOFcsIXEFtZnPLaVULndhJMoOYlWOG2puHSfPVIl?= =?us-ascii?Q?qsp+X2f9dlIZxhUC4gGn7YFT06wQ5idoTdkc98opsSbH3U2uv3bZxMnRBfTY?= =?us-ascii?Q?k12ld3Ui584BrZ6tmvbdPSWZfJvfIsm+rYPHrHwxLK3/Hmbd4n7pvfMV/+Ql?= =?us-ascii?Q?w2jMz/YODt3j3Vd6ypZW724nserjH5dLLBPn/7spWlQYB+bx0ZNhEb0ghEqW?= =?us-ascii?Q?cej/iXqOAVOXRO18JKVeOd6L?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1272.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15fb3579-5921-4f5e-44d7-08d8ee025e9c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 13:48:41.6090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cwYxgJv8xJw8LiviyeJORCBeFQjPec8iECk8wM8C2Uw93I1KhoHOWBpxC9A2Ck1Nybg4dRbiOs/RcQjGffqVSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1398 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, March 23, 2021 9:15 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments The comments in PiSmmCommunicationPei.c describe the whole memory layout of the SMRAM regarding the SMM communication. But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table removed the code that produces the ACPI Table. This change updates the accordingly comments. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- .../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCp= uPkg/PiSmmCommunication/PiSmmCommunicationPei.c index 68e5003ad4..110165b20b 100644 --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c @@ -1,7 +1,7 @@ /** @file PiSmmCommunication PEI Driver. =20 -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent +----------------------------------+<-- | EFI_SMM_COMMUNICATION_CONTEXT | | SwSmiNumber | <- SMRAM - | BufferPtrAddress |---------------- - +----------------------------------+ | - | - +----------------------------------+ | - | EFI_SMM_COMMUNICATION_ACPI_TABLE | | - | SwSmiNumber | <- AcpiTable | - | BufferPtrAddress |--- | - +----------------------------------+ | | - | | - +----------------------------------+<--------------- + | BufferPtrAddress |--- + +----------------------------------+ | + | + +----------------------------------+<-- | Communication Buffer Pointer | <- AcpiNvs +----------------------------------+--- | --=20 2.27.0.windows.1