From: "Dong, Eric" <eric.dong@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard
Date: Thu, 18 Mar 2021 00:37:59 +0000 [thread overview]
Message-ID: <CY4PR11MB12724E95D07796D98E774248FE699@CY4PR11MB1272.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210317110640.489-2-ray.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, March 17, 2021 7:07 PM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard
The change doesn't impact any functionality.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
UefiCpuPkg/CpuDxe/CpuGdt.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c index a1ab543f2d..8847bc4819 100644
--- a/UefiCpuPkg/CpuDxe/CpuGdt.c
+++ b/UefiCpuPkg/CpuDxe/CpuGdt.c
@@ -2,7 +2,7 @@
C based implementation of IA32 interrupt handling only requiring a minimal assembly interrupt entry point. - Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>+ Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/@@ -13,7 +13,7 @@
// // Global descriptor table (GDT) Template //-STATIC GDT_ENTRIES GdtTemplate = {+STATIC GDT_ENTRIES mGdtTemplate = { // // NULL_SEL //@@ -124,27 +124,27 @@ InitGlobalDescriptorTable (
VOID ) {- GDT_ENTRIES *gdt;- IA32_DESCRIPTOR gdtPtr;+ GDT_ENTRIES *Gdt;+ IA32_DESCRIPTOR Gdtr; // // Allocate Runtime Data for the GDT //- gdt = AllocateRuntimePool (sizeof (GdtTemplate) + 8);- ASSERT (gdt != NULL);- gdt = ALIGN_POINTER (gdt, 8);+ Gdt = AllocateRuntimePool (sizeof (mGdtTemplate) + 8);+ ASSERT (Gdt != NULL);+ Gdt = ALIGN_POINTER (Gdt, 8); // // Initialize all GDT entries //- CopyMem (gdt, &GdtTemplate, sizeof (GdtTemplate));+ CopyMem (Gdt, &mGdtTemplate, sizeof (mGdtTemplate)); // // Write GDT register //- gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt;- gdtPtr.Limit = (UINT16) (sizeof (GdtTemplate) - 1);- AsmWriteGdtr (&gdtPtr);+ Gdtr.Base = (UINT32) (UINTN) Gdt;+ Gdtr.Limit = (UINT16) (sizeof (mGdtTemplate) - 1);+ AsmWriteGdtr (&Gdtr); // // Update selector (segment) registers base on new GDT@@ -152,4 +152,3 @@ InitGlobalDescriptorTable (
SetCodeSelector ((UINT16)CPU_CODE_SEL); SetDataSelectors ((UINT16)CPU_DATA_SEL); }---
2.27.0.windows.1
next prev parent reply other threads:[~2021-03-18 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 11:06 [PATCH v2 0/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB Ni, Ray
2021-03-17 11:06 ` [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Ni, Ray
2021-03-17 16:31 ` Laszlo Ersek
2021-03-18 0:37 ` Dong, Eric [this message]
2021-03-17 11:06 ` [PATCH v2 2/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB Ni, Ray
2021-03-17 16:31 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB12724E95D07796D98E774248FE699@CY4PR11MB1272.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox