From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.2470.1616027883612135119 for ; Wed, 17 Mar 2021 17:38:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oS0NPWs5; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: eric.dong@intel.com) IronPort-SDR: FBaHrNaQIp/dwPl6U/mM77KNIN0MEWWnDZjwztbjUKV8lKSG0Kuo62gPTstGrsqJ7HDoJTLb9s AaevKT3EybCw== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="250930972" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="250930972" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 17:38:02 -0700 IronPort-SDR: 250eEW84jjliHYEgeh7bp2IqQf8Z3KuszID2W2wAxIh70E6f8u6NfoOj/eTkq0NrltInz3WoXz xoj78QfdBMIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="511920379" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 17 Mar 2021 17:38:02 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Mar 2021 17:38:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 17 Mar 2021 17:38:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 17 Mar 2021 17:38:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwLtQBu3tCzX9RmHNebtxCIZqF17/EAKnqFlpgBcz20+2xI+9X0zCLsXowvvnefu4ogz0LnReQT8KjtyrKKu1xBDUBFdqs26cCM+06xNANAOCvztzPAGEy75f/Y09N+xF02RJwRzDsAQsgmLm9gUoJCjJdOowMX+gCaW3fEbA75KUmg9uhYLsnmGxY1TJoOO4OsyywArbPIgrxNOqfICTSGw/Aez33KQx5HFu+Sd0R/cJPExtZSb3p/QTPSR9RT6Z9Bk63dEUkzut2Cy9+YUWuYKFfG5ctsYW/PHJhlPkg7zJ8/OFPrZBFOuzDIH6wacqw+oiHx6QGN7meQGytHpEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eJGLCsctOJ2eJYN2WuCy5R882w7oj5AcPEtk5nhysM=; b=oIZ/IGp1uP+Di8tZ2UyW8EwLRuhni3CS1I/XC66M/S94xvykjUKShQiNjV/sf50tENa/5pKzHW+jvVLyCO4N376C/ceBldATiMjo6bQxjTztf5XwpP/kwYYetH3stT/8yXpAgBbsygPns+DE4hNV0L2nutLk9lnNK5I+2T+A5YkV6XCJPgIODfGbs3BSIns+RiP3Opvz1MPG2Sqs1OjGmZwEG5pdT+hkZ5tyMGr8gtvUqzlzfDTjGOgBV9oLiX8aVzw5rx8YbtNRcunKsxRlBH3IPbA4QnV0DpuBnD8lcfiFbfXOvMFBkd1Mj0kzGGdrxLIfDtdaQzs84JsIA+gziQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eJGLCsctOJ2eJYN2WuCy5R882w7oj5AcPEtk5nhysM=; b=oS0NPWs5H0N10yuEPSk/53Ygo6N/4szB4hA8FuscHwnU0VqQYcKx3Cmcsu3opJktJhFbT0g+RG1Cz1r0U/GDrTinn8vrN/l56zvfii62Q/n86TKuzkxXxh+BeTpiGY3SWErxijXou6lFadeytIAwZe80T9iRXVwOPcMOjEnz9Fg= Received: from CY4PR11MB1272.namprd11.prod.outlook.com (2603:10b6:903:29::9) by CY4PR1101MB2278.namprd11.prod.outlook.com (2603:10b6:910:18::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 18 Mar 2021 00:38:00 +0000 Received: from CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9]) by CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9%5]) with mapi id 15.20.3933.032; Thu, 18 Mar 2021 00:38:00 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Thread-Topic: [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Thread-Index: AQHXGx20a+w+fH5RsUaxK/tBQE/KO6qI55Lw Date: Thu, 18 Mar 2021 00:37:59 +0000 Message-ID: References: <20210317110640.489-1-ray.ni@intel.com> <20210317110640.489-2-ray.ni@intel.com> In-Reply-To: <20210317110640.489-2-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b599a37-715a-4eeb-fac4-08d8e9a61525 x-ms-traffictypediagnostic: CY4PR1101MB2278: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3paNWie/3KAar+RR3DDeSwa2t8VB1m0LVSfF8h5F0ZX95spVtS80+f5t9IkPyxsUr2exRHF88ktfflVEhyI7wJiyiG1xqe9XZzBogSnUWqAbamwSx/NVC0RhnBpIGbAQ7JZ/mp8k5VP+EiceuiaHhFlRD5MWQZengUlwcNg97apGqh2gO2q1q/tZTAIImV+dfisyKWyawkh2zyfQoCghawzcpD2XU3y1qo5hu38E+mb76R8yZSfO7eXN1UeZgcWsIqSQozXa/wY7ohndHmndk7kEEvkPCTDMtQ17DfCjE6RuGCKhxIyahuOwJ2QrxPNGVynQ7fQVHRSk6xOzPGIQmU44svqs5Zqyy6HG7WDg69FRvM84yK7c1oTwGsm07fbRWPosMBFzlQlS5zhu/ikW2cKBxwthMTjP0N0cGapA/IgWWBTSJ7DMgVOELP2IkX3iaG2RZlKjRIP/5xGIztJf9/ZwCnqARXfsdmkxtkHr8S7F2ujmPyRyzO1FWupCOfw0ztVl/VU0atUoY/8s5PHOcPZEFxsvi8yhTaOBxxq0vIUIN8r2bjSgbJlLsNQkTNLQty29qKIs1OLTAsKG1CJC1y+ydVlktJrrzaDanRRxH29mqegTwIWLGBOaUrvlHOnT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1272.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(376002)(346002)(366004)(39860400002)(26005)(107886003)(64756008)(4326008)(71200400001)(33656002)(66556008)(110136005)(38100700001)(8676002)(66476007)(66446008)(9686003)(76116006)(86362001)(83380400001)(54906003)(478600001)(66946007)(55016002)(53546011)(8936002)(186003)(52536014)(316002)(2906002)(7696005)(5660300002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wlNDBMkg4qSPS+yiQdIeA5vL0XCMPIyCI0UTnNccyw3+/LQ4gPZjl5LZDIIn?= =?us-ascii?Q?+wYADgSkPVKdMQ6B5xzcsM8fXWoCIH1eZLoKMG01LM1pWiJkept+i1wTs8ZI?= =?us-ascii?Q?untVhhLYS1+JU1Bpy86w6WKobYUU8MaMDwvIM5c8CUn6HHgohAsd0+jpGTMN?= =?us-ascii?Q?yacJTtC9BzOXpD0QnCoDD7PydMvqYkse6VZx3JOF/pjCZPTHVUddyU9cPxUV?= =?us-ascii?Q?86fldDC1gr8PXH0EiTFUpt7V5yp3KPoGQdzsny6kgKg2VBBv2fN3qLRxx1Ls?= =?us-ascii?Q?m3sh6fieGJtMAMF4T72TDW8U/ZNdfImuuN5XqD5WLSUe0GLp+XrUe/imT4K7?= =?us-ascii?Q?KkBlnL4s8k9QlIeE+aei0W25yLn9tUglz9WIBChEa98pFXyp1VbbrATI1+qF?= =?us-ascii?Q?H7pDjNFEQTHhHCZ0rAeM4pVU3RUoQckGhm3SzurdjponUnSvyL9bZ8VHVDin?= =?us-ascii?Q?Z5QL0yg/LYMDxQcEGrWG1cfKAmsdpWaOFeZmwE03qpJKnF6f055LmwiiI45e?= =?us-ascii?Q?X1gPD2ComWhTQD1qMCyFf8YwUKG7wgprBoHJV6L8pjqkMF3vK/WpMDcJqoKG?= =?us-ascii?Q?6rirqz47U7ZHR4yt+lB3TVlPh2JzaW3p62eFhgM6fpZI+gKO4UBYEfcptLik?= =?us-ascii?Q?qQYp0IXgjCjPXa31BqfHQKzft2MqKpmjXMb4MY4ZmAJ4ju8OdJB0SKkGgObe?= =?us-ascii?Q?xbUJ5+GnfC2IKfoU2Qvc26SdjUdJAa4+b56ahrPKF0l2NTsTIMVKsU6twj7K?= =?us-ascii?Q?Uk3UbCx89REK4/nGDgVYB5HT/WUlKKt8m3ebKJJlJNgTIRv/yahKBWz7ucSv?= =?us-ascii?Q?ji7w90yMZuiKnspVf7LwiUlbWHEs831QJy91eRE734UHeWY8G1CfcQZkhUpp?= =?us-ascii?Q?m6Oi9bJsP8n4R2+kPwonJcCXCCGmkonJiFv6VKPdedH72Nun0O3NB4xGxHDq?= =?us-ascii?Q?ILrWTVut+0wRpdruPcvxkRO7Ldux4rSuIMV4ZtZ08zclQyoTaLBHQd8t4gYe?= =?us-ascii?Q?drSvOUtqbk3KHDY/LdURj38xkehuBSpyuoQrNQ6Vo5QIsk4oLG0WgBSQZ4ZR?= =?us-ascii?Q?dBmlj0AANfUPbK+tYnoJoRgtr/FO/BCBvo49RaZKl5MX/WMvVio51XIOsIw9?= =?us-ascii?Q?uf65p24hBTsghglS6imzAwpiHDA3InJYDJlD2f8zoMhdJMxf+OKHWY5Rvqh4?= =?us-ascii?Q?KvMN5hbPDxgrJH+QqfYZA/VgdS6+TraUfRzLRdmeF3bekAJbgQFMly7d7cqn?= =?us-ascii?Q?C9KPgXb+PhFQ+ft8B1U8pY4bYCF/EeB5PwZBBFcaUe2L+f18BNN6/Ccxppsz?= =?us-ascii?Q?zZw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1272.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b599a37-715a-4eeb-fac4-08d8e9a61525 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2021 00:38:00.0879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wUirPlXlmJVkNLcRNe6Mg0JSnpA8U7ZeJGugNvOTjaB+hfFhzWF5YnO23Rc1EMOzT5iL1GxAi31q+1YI+JzmZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2278 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 17, 2021 7:07 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: [PATCH v2 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII= coding standard The change doesn't impact any functionality. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/CpuDxe/CpuGdt.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c index = a1ab543f2d..8847bc4819 100644 --- a/UefiCpuPkg/CpuDxe/CpuGdt.c +++ b/UefiCpuPkg/CpuDxe/CpuGdt.c @@ -2,7 +2,7 @@ C based implementation of IA32 interrupt handling only requiring a min= imal assembly interrupt entry point. - Copyright (c) 2006 - 2015, Intel Co= rporation. All rights reserved.
+ Copyright (c) 2006 - 2021, Intel Corp= oration. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-P= atent **/@@ -13,7 +13,7 @@ // // Global descriptor table (GDT) Template //-STATIC GDT_ENTRIES GdtTemp= late =3D {+STATIC GDT_ENTRIES mGdtTemplate =3D { // // NULL_SEL //@@ = -124,27 +124,27 @@ InitGlobalDescriptorTable ( VOID ) {- GDT_ENTRIES *gdt;- IA32_DESCRIPTOR gdtPtr;+ GDT_ENTRIES = *Gdt;+ IA32_DESCRIPTOR Gdtr; // // Allocate Runtime Da= ta for the GDT //- gdt =3D AllocateRuntimePool (sizeof (GdtTemplate) + 8= );- ASSERT (gdt !=3D NULL);- gdt =3D ALIGN_POINTER (gdt, 8);+ Gdt =3D Al= locateRuntimePool (sizeof (mGdtTemplate) + 8);+ ASSERT (Gdt !=3D NULL);+ = Gdt =3D ALIGN_POINTER (Gdt, 8); // // Initialize all GDT entries //-= CopyMem (gdt, &GdtTemplate, sizeof (GdtTemplate));+ CopyMem (Gdt, &mGdtT= emplate, sizeof (mGdtTemplate)); // // Write GDT register //- gdtPt= r.Base =3D (UINT32)(UINTN)(VOID*) gdt;- gdtPtr.Limit =3D (UINT16) (sizeof = (GdtTemplate) - 1);- AsmWriteGdtr (&gdtPtr);+ Gdtr.Base =3D (UINT32) (UI= NTN) Gdt;+ Gdtr.Limit =3D (UINT16) (sizeof (mGdtTemplate) - 1);+ AsmWrite= Gdtr (&Gdtr); // // Update selector (segment) registers base on new GD= T@@ -152,4 +152,3 @@ InitGlobalDescriptorTable ( SetCodeSelector ((UINT16)CPU_CODE_SEL); SetDataSelectors ((UINT16)CPU_= DATA_SEL); }---=20 2.27.0.windows.1