From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.32861.1613984824702016386 for ; Mon, 22 Feb 2021 01:07:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cnxM+f/Q; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: eric.dong@intel.com) IronPort-SDR: sBUZv5IDHLExb66FuN/hwtV3xQDoiIW4yySk48IHjhF0AnC2EaZ1QzQ7SrgnmeMofIq9ITyUaX +mK9TErD8JbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="172040758" X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="172040758" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 01:07:03 -0800 IronPort-SDR: vG2vIYj0x5Cv78okyYaQ1ni9ltbRHqAK3ya0fvUakHfENPmfUFLZPUlnWMtVIF9kDzIEr0UZER 5mpgvpZdWp1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="595890923" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 22 Feb 2021 01:07:03 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Feb 2021 01:07:02 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Feb 2021 01:07:02 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 22 Feb 2021 01:07:02 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 22 Feb 2021 01:07:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQdnVqFgXCtvVhb4mbB2Bhg41RLOu6Z1EB3lHV9RYzMhaSVQE0/u2xysuqfpK7JRyVbwvX0MA+/t5E/AQZYQ3GOfTQQwlzcrTzA5YJaI9AvMWwX/L72urUuuA2bWb7dZowYektNTgn81EfjXkep8nX7CAq2I5fYylv/GZn1KNLMTk2RbPArVfjDxZ+UxUsg8/rtXdif6f2KRcC0DnLMSX9Aoru2Sa8DCj6HBl2mgOlltr7VRvkVfAgpmsZqlNjOMOYUXNuO1tCzpnhVR2ahSg/jEivf2THBbveGxGTAK8sS7uflKtcfOrhJAc9RCch6ZAalKj1BRXfegHJArp3RWKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beS+hhBykBL7cVLymfT9NODzOO+rQaMd7UDlzfc9EhQ=; b=UYIkA6d7KtLzZ/7xc+imGpv8j+Oigi5YBWquPlY/vr2HTlRADxKB+sX2CP9yLHN8iIzndw12gW+xZ5VyC5iUVUmOVreyBXeikT9tl+WyXljNzJfDq6QyTepAaCkea3jIydiE0PTWHx+RxIQqpUjkJtp7+5Lw41rZ/BVAeO6lsF3JdrEtf+Q290iYrOS9CCd3+rLOZ1Xlxc7qchVQd9LbR/3nRiuBVrw0R9OXT/v7ZPg6XFjisUzm6tE6P/1Nxfa7dPh9G3qOt+sxDbPFleTtxgupFstkHeZhUnc+DogekacpbNGAU6GwqQBL0vVwqF7ngaYUFKG8IJyw7v5V3Qr67w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beS+hhBykBL7cVLymfT9NODzOO+rQaMd7UDlzfc9EhQ=; b=cnxM+f/QBinR0ULPhekqMFvx8vTZwbtpy63tKGtN8H1VPZJM+N9C1gDIdUWNLtmmrhhUSWctkdsKAh1cA5+I8ZoEDQ5CN9elrd7J+c3iQfq/4NIfnRlFgNPC0qo3SrVst4+AqoWBsKHjjT1MMvz/prgQ42kf7lsC8INo6L4dEkc= Received: from CY4PR11MB1272.namprd11.prod.outlook.com (2603:10b6:903:29::9) by CY4PR11MB1976.namprd11.prod.outlook.com (2603:10b6:903:120::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.31; Mon, 22 Feb 2021 09:07:01 +0000 Received: from CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9]) by CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9%5]) with mapi id 15.20.3868.032; Mon, 22 Feb 2021 09:07:01 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v3 4/4] UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CPU_EXCHANGE_INFO Thread-Topic: [PATCH v3 4/4] UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CPU_EXCHANGE_INFO Thread-Index: AQHW/u48/beYAIcLxkuQ+t9hK97c7apj9kag Date: Mon, 22 Feb 2021 09:07:00 +0000 Message-ID: References: <20210209141634.1999-1-ray.ni@intel.com> <20210209141634.1999-5-ray.ni@intel.com> In-Reply-To: <20210209141634.1999-5-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6861257-4374-4682-692f-08d8d7113705 x-ms-traffictypediagnostic: CY4PR11MB1976: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qi+5xou9UUpOaHCHIaC2YgdCCa9cdTQjlI+DpTt1ER0Bo7IWvl5bbGKWV8RvLbojewgn2y6EPI+4Itb0Bi5zqDfskrnXlDOIu0+75HvLMwIAbwFF0JF1O7ZZ4hCiTkAsF2xcJwKpewJPXUwHGkBKMv/12K9pWN3Rypl2ARd3cDVW6flYTtXK/t1q2kFcAGqKgG45nsYBqJhXEdIyKU6UUyb++JD1PJq2gmXSa6Q7tZ/yJqi6ufjdYV1C18PnQCrSccqQwqwOP9dkjtPe9wokntYEU5WAhDFOiGVRhpyTvG/L9MEiT/TGIpgjzi2mTBalMQsF3WUrnqaWLqKT3NfMAgTfDfmN0ceDR8MLczs+ve3JV/NilYek/2RK5Wrh7GSJIFlx2wyos7XXhHbFVutaxzp2LYKxab5rrIHwX4ZpOF/aCMIWAMXV+Qa3jU0qvoP2gMsW4PrNvN2IFt4oudiQPVZMs40fYBwptTwPLWiL0gOFKMopRz5N+2fkhRRELb75McKHHwBKdxkYJD1i5YHADw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1272.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(136003)(39860400002)(396003)(346002)(376002)(107886003)(4326008)(7696005)(33656002)(8676002)(64756008)(55016002)(8936002)(66556008)(9686003)(71200400001)(86362001)(52536014)(2906002)(316002)(66446008)(19627235002)(54906003)(5660300002)(66476007)(110136005)(83380400001)(66946007)(26005)(186003)(6506007)(53546011)(478600001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?oEMiJRmJ5uYZoljNLEwr0O+CSSxEkwVFvS48at5V2XavnffoTW0UTnK3g1qr?= =?us-ascii?Q?KRTAqKwyYCTy5CRZ8qXknZLMT41+VZm7TAE61RA3Hx+foP70JrJRpbtn8Q87?= =?us-ascii?Q?9oluTQdUDK5IxbIlmCbVjuqPBIPyKQ23MhgnchjRfFXwFig6se77DfStFJ/B?= =?us-ascii?Q?8GERBF/L9fYvyUH0DxStMbWONuXKCfXyps3+h29HU8PjGHgZ3tVxNriwV5SP?= =?us-ascii?Q?bHB8H5nESqUGiPz5sKt6XPk1hwXkJ5q+fm+/YOLHll8EBWlGFT5CIQedW2Ta?= =?us-ascii?Q?uMp7HaQMHo86NFCjRoxUbBMNUHwJSIBnEQg/6ePc9fAjkJJmOp88/VTkCiEe?= =?us-ascii?Q?lvH5keR+a+fOwD9YThjifDiEk0FGkXCVb1g/+safHKvn6Vplit5gVVe3mWJ7?= =?us-ascii?Q?0DSZdgyfH7pFfzmGmd5m45CuaPtgiq+ARA9DcUEqObma1zR31PL76uoxgE8P?= =?us-ascii?Q?ePlfrRa4LZN24wQhJFY9iAi7cIWw33HmdHfY8id99+m38tsdB4W1APXm6OB7?= =?us-ascii?Q?b4NpNZpRd/SyI6NEQ3RaZghMO7ADjOWcTro+2OPH+9aQ3BrGKiBRbN6cuRVj?= =?us-ascii?Q?9oxHtvHOqNVskQCaxnmZgs9jLYLiebDfPfC9Ct/NFhWr3GcdKVP/jttN5/oX?= =?us-ascii?Q?G1E/cYmM9tF1srYSC5MHZGOBQ1cZ+MJ1xBPERUOungpWaj8sMbCtOdzw4SXE?= =?us-ascii?Q?RPg0ssRVc3OxN7aHG7pV7BoEJjl/zIdLJZ3vAuIgcHqzb+UBjDtFWW4Byhsb?= =?us-ascii?Q?WMEOPvu+guOnVkOzivrPAjVQHtu4XCB2HiK2+iFWYDmXQVYXo+gE1Jq2GHIg?= =?us-ascii?Q?DcReEHEd1xMjR1tAvrnEp4l0ibEC0N9dEdg30si0cgwNhXflRtVuPX6G/nec?= =?us-ascii?Q?Z6o+Gfu4OAAYzUf/iSLtYzkfC263rrikgmyNpEMZcJ/93329vkcthHsxb6nM?= =?us-ascii?Q?DVrhIx7NNkExeiUxd3klGrrAUibznhA7qG7q+25QHFp/5AtDVmUVOOY2D1n4?= =?us-ascii?Q?bKFwaT0IVogh12WIPGaDXdZtzA+eCAwVUe8y5IG8GJHL5wNSNwXTbWjC71hT?= =?us-ascii?Q?rWI2FoPIJBJnw6TQocaQIesrhtwbE10fX3r3NtUZmTvjbRcz2bQq8SmWgKzh?= =?us-ascii?Q?LzOpGe+saAwjPVDbDptaKJWekSCGK6m4/y22+YfoPE/X8ULo1vmX7dG+WgSs?= =?us-ascii?Q?JK8gcCgElK9PQIWLC/TkBXC2/0q8yeSGZRL8ZGPIeH6IDak7f4JyPxYwwzJA?= =?us-ascii?Q?xPdYT945D+CQX8Jlq2mrlSaN64tqGi/KXhFHzOvuZqqRwOD6gQUOHYEMExCV?= =?us-ascii?Q?V9hWL4ZA2yzYmmBW6sZx/jXF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1272.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6861257-4374-4682-692f-08d8d7113705 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 09:07:00.9063 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yh9ba5SYR3iiocO1RW4iKnpBldgtfjRFfB/cVG82LD4018EpIUfMdN97gMdt4zPgtfy0PDZzSzbkgb5eteaNbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1976 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, February 9, 2021 10:17 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: [PATCH v3 4/4] UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CP= U_EXCHANGE_INFO The Lock is no longer needed since "LOCK XADD" was used in MpFuncs.nasm for= ApIndex atomic increment. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 4 ---- UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 4 ---- UefiCpuPkg/Library/MpInitLib/MpLib.c | 1 - UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-- UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 4 ---- 5 files changed, 1 insertion(+), 15 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm b/UefiCpuPkg/Li= brary/MpInitLib/Ia32/MpFuncs.nasm index 4363ad9a18..7bd2415670 100644 --- a/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm @@ -121,10 +121,6 @@ SkipEnableExecuteDisable: lock inc dword [edi] ; AP init- mov edi, esi- add = edi, MP_CPU_EXCHANGE_INFO_FIELD (Lock)- mov eax, NotVacant= Flag- mov edi, esi add edi, MP_CPU_EXCHANGE_INFO_FIEL= D (ApIndex) mov ebx, 1diff --git a/UefiCpuPkg/Library/MpInitLib/= MpEqu.inc b/UefiCpuPkg/Library/MpInitLib/MpEqu.inc index 46c2b5c116..2e9368a374 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpEqu.inc +++ b/UefiCpuPkg/Library/MpInitLib/MpEqu.inc @@ -13,9 +13,6 @@ ;-------------------------------------------------------------------------= ------ %include "Nasm.inc" -VacantFlag equ 00h-No= tVacantFlag equ 0ffh- CPU_SWITCH_STATE_IDLE = equ 0 CPU_SWITCH_STATE_STORED equ 1 CPU_SWITCH_STATE_LO= ADED equ 2@@ -72,7 +69,6 @@ endstruc ; Equivalent NASM structure of MP_CPU_EXCHANGE_INFO ; struc MP_CPU_EXCHANG= E_INFO- .Lock: CTYPE_UINTN 1 .StackStart: = CTYPE_UINTN 1 .StackSize: CTYPE_UINTN 1 = .CFunction: CTYPE_UINTN 1diff --git a/UefiCpuPkg/Library= /MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c index 2568986d8c..5040053dad 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1006,7 +1006,6 @@ FillExchangeInfoData ( IA32_CR4 Cr4; ExchangeInfo = =3D CpuMpData->MpCpuExchangeInfo;- ExchangeInfo->Lock =3D 0; = ExchangeInfo->StackStart =3D CpuMpData->Buffer; ExchangeInfo->StackS= ize =3D CpuMpData->CpuApStackSize; ExchangeInfo->BufferStart = =3D CpuMpData->WakeupBuffer;diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib= .h b/UefiCpuPkg/Library/MpInitLib/MpLib.h index 02652eaae1..0bd60388b1 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -1,7 +1,7 @@ /** @file Common header file for MP Initialize Library. - Copyright (c)= 2016 - 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2= 016 - 2021, Intel Corporation. All rights reserved.
Copyright (c) 202= 0, AMD Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clau= se-Patent@@ -190,7 +190,6 @@ typedef struct _CPU_MP_DATA CPU_MP_DATA; // into this structure are used in assembly code in this module // typedef= struct {- UINTN Lock; UINTN StackStart;= UINTN StackSize; UINTN CFunction;diff = --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm b/UefiCpuPkg/Library/= MpInitLib/X64/MpFuncs.nasm index db297f5cca..50df802d1f 100644 --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm @@ -157,10 +157,6 @@ LongModeStart: lock inc dword [edi] ; AP init- mov edi, esi- add = edi, MP_CPU_EXCHANGE_INFO_FIELD (Lock)- mov rax, NotVacant= Flag- mov edi, esi add edi, MP_CPU_EXCHANGE_INFO_FIEL= D (ApIndex) mov ebx, 1--=20 2.27.0.windows.1