From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.124369.1597970339887742402 for ; Thu, 20 Aug 2020 17:39:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qYaRTFC1; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: eric.dong@intel.com) IronPort-SDR: GLL1P0wqsDN9YAbpMCHhFXuW4T/lcxT1qtyhUpwk2sDM8y4IDN3V+A1vHX41ApOQDzzixZilES D0n8NQqPaz7g== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="216969540" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="216969540" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 17:38:58 -0700 IronPort-SDR: 5CruseMRqodpjzjtMHvhbJocRBDwics+ZgZGVY14wIS/Z1hfwvHOjfL9Xy0DSzIpuJUM5RNA0y iwOIHQTmQO3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="297770505" Received: from fmsmsx603-2.cps.intel.com (HELO fmsmsx603.amr.corp.intel.com) ([10.18.84.213]) by orsmga006.jf.intel.com with ESMTP; 20 Aug 2020 17:38:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 20 Aug 2020 17:38:57 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 20 Aug 2020 17:38:57 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Aug 2020 17:38:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XVP41fSLFr4yR57Tgv13F3ptgD9TRbeOEgxAznkRGN7Bvlix5rkNOIpI0co+AimgWStxifjkGfcxpXYN3ey3u/Ez8g6YxVk1IrNxpDmQig3ovWb/nC6R7azdoohC4SKBEuvVIe09y9QDlhJ0E2RRTeqdvfocPnvxJEe5OyxuRajuMkpwdOypJFl6zrY0Uj50HlRX4/Y7D+gyUtQ7fdLf7pv70MphFVlf9f6m8xEiSKA6Fb9Oq3aUS+botUFibw9e6xJIph2SnMw/htu+9+AezqYD3H9izQE54E7aoIjKnCNVgN23wN2MIOzmWbPQaHovoBq5omP7ADASq7ci7qeDKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4exIpaG2XIN3eRcK5lEC7c5eZTEhSHou0RrfXyFNrA=; b=M0BQTyqukJBpE3SpBytWgOoSFXtQ67frUrXQkAqIViIWSaxjt9mN5H0oyqOkAhuh5yQJxeFb5+l02Lkyfvx8+jwswF3LrcdDx7lZPROgZXGsmVDvtqABOUEBsZu6ZpMrIXRmmlU+2pRqWGfF0IkbWGsX5GbYaD9774+9vpwpIWIfj6rpMjVz8go2GlbsiI3Kl2EbmYnqRfAk303nIyX7Dzj7lKrB+6bhTslODmQFCzXRO9TcVPvCUHK29nRd2yZuO0rnd5DmvNbxgL+3RpKGWGbTCMtcIREzfn9miRkiK/2HC4I0kyAqx4pMb2BaCQa4OcrjoSLik0OPqT/w/XH6Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4exIpaG2XIN3eRcK5lEC7c5eZTEhSHou0RrfXyFNrA=; b=qYaRTFC1KlSZHstEUaDj8w/N1N9qQ2mtlUsCGwRIzu/UMQVAc88RxVy2DMHe0g9wtXSGjxykstlPio5Jn4y1EyavIl2+ZIdsGoco5HL6BE3EUIUqcpxJ8OH0f5Sj6M6wcCyRNujhhy8qCjFIvF813+kJneZSq0ammsa4ipNqLps= Received: from CY4PR11MB1272.namprd11.prod.outlook.com (2603:10b6:903:29::9) by CY4PR11MB1270.namprd11.prod.outlook.com (2603:10b6:903:2c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.20; Fri, 21 Aug 2020 00:38:54 +0000 Received: from CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::5fc:81fa:9c36:24eb]) by CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::5fc:81fa:9c36:24eb%3]) with mapi id 15.20.3283.027; Fri, 21 Aug 2020 00:38:54 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "thomas.lendacky@amd.com" CC: "Gao, Liming" , "Ni, Ray" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Topic: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Index: AQHWdwGx6Uur4yqe8kKWMc8PGI5spKlBuMoQ Date: Fri, 21 Aug 2020 00:38:54 +0000 Message-ID: References: <76a9f18992475b915e5f8457704676067210cacf.1597935198.git.thomas.lendacky@amd.com> In-Reply-To: <76a9f18992475b915e5f8457704676067210cacf.1597935198.git.thomas.lendacky@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: beeaba92-64e8-41de-0ba6-08d8456a951f x-ms-traffictypediagnostic: CY4PR11MB1270: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dFHLfYA0scpor1f5eRsNxN+u6mQu5MST20lBUqSSuv2iyYhTPrBOzCitKCzH2N7DshylIcxkz2vpGpRY4nW1u0h6FSnvoXyY32T7nicaZbVH+KIsWR5ho1Jo4UWJJlPlWjh892pgvIet+eZU7sVIZWVk+YXqb7qhQ5r2ihPsysv/UqznYddpaDeZ9VMKT6gA8vAQ+sTJbc4g8cWod2suVVB7jcLdeZJY/2pDxIMg+/tCQ0RbUUJ79AvPAWxZBSEMEgufc3lD2T1F4s5doymSTaSI0NsgPQB2RvnSNnSVpIFGNm5ANSYMfBtR4wsEbhBGHzyOSxaLy1XQJQfN5Z2lKd60s5UWabRT3sa7/c15lNs5DIG8iWfVQr7Ig2rEjS2M2biUxMf4EzqZukIjPjsBKw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1272.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(39860400002)(366004)(376002)(346002)(136003)(86362001)(110136005)(107886003)(316002)(2906002)(4326008)(186003)(52536014)(966005)(71200400001)(478600001)(9686003)(55016002)(8676002)(66446008)(76116006)(83380400001)(5660300002)(7696005)(33656002)(8936002)(53546011)(66556008)(6506007)(66476007)(66946007)(64756008)(26005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: EIW9hVHCdEXQheW77FUDXcNxbvpnk6/xmOfJ0Q2QFCdGQQ8uOH2WC+xMSajjFmg4o7Tp97XCFBANdPm4CQ7S0Kwl94hn2VaPqEYkMRAftKZ9TEuiYw+IT9g2tGLtiRP13bTD2ToVeMjBzd+rhdADp5eXSlHKTY0Ezz8cZ+aowPBAIE8F7uS/9w0BxQCeViSGn7Ogg2Wdl8dbXldoLyOmk3zMph849KOnS48ai2bHnWfyE2E9uw+mHObWF+TJw7SAlkQaEW8Lja0Qo/3245BCATHCfM9ovqUeNTlLM0Ljnmc77Z0nQpFg930VVxXRVOelo2h8oz/qdFjwacUQfgL8KW0cbCSRmah9Ky+ok4l/Hb2HqU+6Ik6+QD7R7sqtCJpEYag/oGvqzsDCOz6lt/eYZJK2iN8gmVBaYBFUlYtPtyUPiuSDpM3iQsrPjjUVL3Jf6cy2X2jBjKl37CihoaJjwMPwSFvdmRsCCdL1OSOqoCiYHqE9EURQ1aXuRzXc612t98yaTZtQHsYBhwV7YqR1GqtPiiX8gdfOrmG2Na6NoMeWS+Kcb2f3/f5sJX+VWPu4MBd8ViweOQ2KL9FyYGWKGKXdKHPh2JV7HV8apBtl5hfw+1VF+oxH/VRZTqoP+jV1grIKVm4y8aMQqVsf6UyRXQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1272.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beeaba92-64e8-41de-0ba6-08d8456a951f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2020 00:38:54.1930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NjVzqCgXrSK2TngPqWCGLPL9SinWx3fmYpArRLZbc2Z0dW+OAIJm04vrHlFG6LqG2CRZ6obBB72hZMR94rwfGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1270 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, August 20, 2020 10:53 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric = ; > Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul1 > Subject: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initia= lize > the DoDecrement variable >=20 > From: Tom Lendacky >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2901 >=20 > The DoDecrement variable in ApWakeupFunction () wasn't always being > initialized. Update the code to always fully initialize it. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Tom Lendacky > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 90416c81b616..07426274f639 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -885,9 +885,7 @@ ApWakeupFunction ( > UINT64 Status; > BOOLEAN DoDecrement; >=20 > - if (CpuMpData->InitFlag =3D=3D ApInitConfig) { > - DoDecrement =3D TRUE; > - } > + DoDecrement =3D (BOOLEAN) (CpuMpData->InitFlag =3D=3D > + ApInitConfig); >=20 > while (TRUE) { > Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); > -- > 2.28.0 >=20 >=20 >=20