From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.8700.1615903138373214499 for ; Tue, 16 Mar 2021 06:58:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=HhyV3uOt; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: eric.dong@intel.com) IronPort-SDR: tetRIAhJOPmF7ZL1JYM4RP6B3USX/lp+CfZbjJ9v2gKRC4Q0qC+4kVXPyb2nq8qHZgGsu7goEH yNw3E77x98Mg== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="186882752" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="186882752" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 06:58:56 -0700 IronPort-SDR: M8fkx0LvdqLv6R28Qo0JJAEmEp1DdLg5BYxpcI45pSDHiUSrgoUUqj4cj3mSq2QcIbo7ZiUH0b fRIUXOprWmkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="605270466" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 16 Mar 2021 06:58:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Mar 2021 06:58:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 16 Mar 2021 06:58:55 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 16 Mar 2021 06:58:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAzrNwOgnoLJOKxzWI0kDJyXAjQKAX+JH7mXM97c9wqKOaLOgdfkXhqoSb6IUZQIWkLLABdEtH7Fslww6aqXKhOnRrGUTSdrDHmg6OjB2nlBJBO1JOvalinybxBpryzSRDT5Omfjr+voUA5bqFpr3/uhfupJOOBvkvljH5ZUifebZ3wGePloocpNzKB+Tsk8OA/wgniTOV/VRj9u9uYfvIcmzG4AhDX8Wp9GvRN5Go7z99V6Jv3gNIawIPJmkWGKpeLXPVKQkPV1wfcdwTm9sTk5MO2teQH4Nlk9hfc3IiV/cltssMDtkF1M9LN1b7xZXlFFw/be3zEbvACCXjTogQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZ+tEUTgoZ7lK3HX88rM0qurnkyBuN/JloAfgkoBOEI=; b=JxeZnApfOBPF4vx2uS+zWQSbz8zUJufUxOBEZKcwUeKJSDl6B7h+txvh97+badPICUXXMx3kpjJjmhE3IWN5r7WDWZoU7qkJVh/DxhTgexbYA7bGC/pj/N+bMzI56rz1Pi8VdRXMM8ZMwxAZUdewr9b8J/3LaJDJsrGjVWL3F8AypXL88BuCVh48uSU8sqQRfOzro4ODmMtOmcpWjjqm45591oTjyaPAQZ11kz0crwPw+PVzG9KRDZJ5e3f2l9G9F2xGcU4HtRxJXYy7EAN2+vbHj+rnlakgc9DO3ZdlWjbcLDwN+Au3oH8hbObVCtYZxvZGjPsBXOiH0S0JHbtNpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pZ+tEUTgoZ7lK3HX88rM0qurnkyBuN/JloAfgkoBOEI=; b=HhyV3uOt8BTm+iN1DrkLbPWlChR7NMd4PPSF8z/xL2ej3XFsqU8JUa+Ru2PWrEyBLwMQtwtgqKaNrGdB5KDUYI65LBKAC7Q6s++CmRsBYeeWpo7dAbw5h0IvcR0tVnJvGlG7QzIb9zy2DN0/bAxoCN8L/fczBlkXE52b7l2u1Fg= Received: from CY4PR11MB1272.namprd11.prod.outlook.com (2603:10b6:903:29::9) by CY4PR1101MB2279.namprd11.prod.outlook.com (2603:10b6:910:17::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 13:58:53 +0000 Received: from CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9]) by CY4PR11MB1272.namprd11.prod.outlook.com ([fe80::918c:7df3:f688:d5e9%5]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 13:58:53 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Thread-Topic: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Thread-Index: AQHXGhU97MOqiL+kl0mm0E0msDAJtaqGpLrg Date: Tue, 16 Mar 2021 13:58:52 +0000 Message-ID: References: <20210316033350.2026-1-ray.ni@intel.com> <20210316033350.2026-2-ray.ni@intel.com> In-Reply-To: <20210316033350.2026-2-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [61.155.142.121] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 034ebea5-5fe1-45ff-2c02-08d8e883a224 x-ms-traffictypediagnostic: CY4PR1101MB2279: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G3WY7ZYBIkhaiq/hkiFtT6Q8GEBQ7Vye+b9I6lrdJhA+NpjNJMGDvir5vZezU21kKpBj0xaEZPb0uc9fEoWT5ZmBbvYSGl9cfOt9EPI9vCRwAFLZN9BZd+q9xbcO87yqoPcXdadym1TJ3qtsN7U0rUn01LJd3DYd1VWUXCqycZu8iSG17KeZcPq/09wdfQuJKsUgcZOFChyCgDEF5vIBeffhszrWeBoRH4TZ+aRqoTS2XDrCzkEZNU9mHk2jNHjGE9du5bZTM90NaAgwf7vD6YuAvmKP469OJGnsQFtq4bfn96UguSwwqzkXAsdH7Pjbb5ApeCPJ+dWCsACM9kksr4jSfuVtNPXwuMFii6XwKHxOZDj6AezwkydvKFfK8IC2WmCfPSz5ITuCY4mcFJhjdWSi2HNkOMZhSQS44JVCFYvnDqPiqmiTfhAAD1oJFgpQmSb6eEeIgvfEVHU0J+Oz3/5lb9ygYWct1+bvCAaOfz1REW8Rd82IKiDZR2Wq7rMDebqV4Sd1To6MtrRF86GRkHqZy/0HfP0mvB5AWQsZBXzbWiUe5kLSemk3KDTMwoqY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1272.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(366004)(136003)(39860400002)(396003)(55016002)(83380400001)(4326008)(478600001)(64756008)(316002)(53546011)(8936002)(33656002)(26005)(9686003)(6506007)(52536014)(66446008)(5660300002)(186003)(86362001)(2906002)(110136005)(66946007)(66556008)(76116006)(54906003)(66476007)(7696005)(107886003)(71200400001)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?GCC0AWyl+ktx7NiFNPRCIwSXngGvmi5XyIpR7CjiflA4abiaLppzILSRvm66?= =?us-ascii?Q?e7w35i3s4aWv3fGM+7M/sYishjJVTcWq808HvAL3T2KDvY1vOtc/G4CbrhRn?= =?us-ascii?Q?dumN2gOwqxWFtLHLGih3yTWpofcdj9Apv8HOw3SDdWCh/+b4tC6fSONDw+ZB?= =?us-ascii?Q?0ua/CZ+bZQMaWr/+ww+uMDzzdusqoQjua0aKjxOpnO4cihGptCvalFXXYYdq?= =?us-ascii?Q?B/+0nce9tWPTOlNdTFB7aRJsC8Gv1Doyob2EIYLFNiC2pKYvromuNpP9G3lV?= =?us-ascii?Q?riLx5Ml5bkEwR4Fo4C7Z0GADvH6pK4fMwBy3sZFfmwMs6ME00TbT0IwsZZDN?= =?us-ascii?Q?uUn5GOU6ETko7ua0JYhA4RR4wk3lXEZOKREmoF7JbPFLeInDdhR1iMH3PcFa?= =?us-ascii?Q?qT0+7CorVVIar14LkcyIK4/07VViCNS1dykpY3JSlhTuGZO03ndEWHcW4BC7?= =?us-ascii?Q?9sFYBqZuFwkCWWxC5k8gLtCtQvNfvlhbHzIuImpIAEh+KsgkjyCx1gHpPSvK?= =?us-ascii?Q?Dpddo4MoWlTsykjbGalZlhjCFPpLXb8978VGpaorUJ/sN7SOccPf9zxEBTWM?= =?us-ascii?Q?xaxAGXztdYswFATa5pybx58gFia2BEoQokBuI3cZ+77q1gJCRN45DM9VW/8Y?= =?us-ascii?Q?Ra/4H07BeeXe3bNQr9f/MSotEbsgWSjF3R6YjAwGjyxkHOsXBLOJxTfsxXAq?= =?us-ascii?Q?Ko9s0eh5acxPM0sJwzcQflTHXzss/BkBeWrFRJF54k7n0NOVImhtkZu5xNQz?= =?us-ascii?Q?p599MeKT+0NLo975bD+/6HGK+rnWlSVN6cd0XDqo0DjOdpX8FSUQVyckYa9R?= =?us-ascii?Q?vzHzLA0uOIcT61KMLKCwcE0ZBRMf5xWNWV8WM+1m41lEvxDqnqqJvdq9MlmX?= =?us-ascii?Q?Dk5q9vDn9BcU2+2WmZqJO3ur6gJQjuqerzhdYvBegyQmHZkNfXmfMjfYbHPy?= =?us-ascii?Q?wGzYr8Kb2YUU9nnDGcVkY5TXSRyxx7wGaXEDNAs9nmgUV8QIrj1AMyte0G1i?= =?us-ascii?Q?1nYcP6ccsuH6V/I7bYTsaQtar7Nn0h13CiF7ssgziEEiGoK8z7wPLY/feVKs?= =?us-ascii?Q?8LOJDxU5yEEtNE4375J/etG0gxnHWBMQcwlJsA6/HxSBbOjp/EaL3YFLl1pz?= =?us-ascii?Q?W3IUcTzdZPB4JwYf7X/7BgwUppbFtVEMo+rAweG+FDYZinAB3e9VgUjApNZt?= =?us-ascii?Q?yKA0YyF6iRpDNIeN0or2hD87iPH7T0dn0120FQg1xJmRha+zWJOWhBYXGBhX?= =?us-ascii?Q?D4Tagd4tqRoo6amw5pBfacB8rs5bz16kUPkoEcY0iTUoWRa7T0z3TBRUvJPr?= =?us-ascii?Q?CqWy4XztBS2ntrSKFZsps88U?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1272.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 034ebea5-5fe1-45ff-2c02-08d8e883a224 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 13:58:52.9965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 65JDj0Q/qqOb+sRFRuPaReg6nHu9VQrudIRxCX7Yr1Ew0kbZ2wTZxPYe4Pty9mf5V5u/9kTmX1tcuQJVkKTl0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2279 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, March 16, 2021 11:34 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII co= ding standard The change doesn't impact any functionality. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/CpuDxe/CpuGdt.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c index a1ab543f2d..322ce87142 100644 --- a/UefiCpuPkg/CpuDxe/CpuGdt.c +++ b/UefiCpuPkg/CpuDxe/CpuGdt.c @@ -2,7 +2,7 @@ C based implementation of IA32 interrupt handling only requiring a minimal assembly interrupt entry point. =20 - Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -13,7 +13,7 @@ // // Global descriptor table (GDT) Template // -STATIC GDT_ENTRIES GdtTemplate =3D { +STATIC GDT_ENTRIES gGdtTemplate =3D { // // NULL_SEL // @@ -124,32 +124,31 @@ InitGlobalDescriptorTable ( VOID ) { - GDT_ENTRIES *gdt; - IA32_DESCRIPTOR gdtPtr; + GDT_ENTRIES *Gdt; + IA32_DESCRIPTOR Gdtr; =20 // // Allocate Runtime Data for the GDT // - gdt =3D AllocateRuntimePool (sizeof (GdtTemplate) + 8); - ASSERT (gdt !=3D NULL); - gdt =3D ALIGN_POINTER (gdt, 8); + Gdt =3D AllocateRuntimePool (sizeof (gGdtTemplate) + 8); + ASSERT (Gdt !=3D NULL); + Gdt =3D ALIGN_POINTER (Gdt, 8); =20 // // Initialize all GDT entries // - CopyMem (gdt, &GdtTemplate, sizeof (GdtTemplate)); + CopyMem (Gdt, &gGdtTemplate, sizeof (gGdtTemplate)); =20 // // Write GDT register // - gdtPtr.Base =3D (UINT32)(UINTN)(VOID*) gdt; - gdtPtr.Limit =3D (UINT16) (sizeof (GdtTemplate) - 1); - AsmWriteGdtr (&gdtPtr); + Gdtr.Base =3D (UINT32) (UINTN) Gdt; + Gdtr.Limit =3D (UINT16) (sizeof (gGdtTemplate) - 1); + AsmWriteGdtr (&Gdtr); =20 // // Update selector (segment) registers base on new GDT // - SetCodeSelector ((UINT16)CPU_CODE_SEL); - SetDataSelectors ((UINT16)CPU_DATA_SEL); + SetCodeSelector ((UINT16) CPU_CODE_SEL); + SetDataSelectors ((UINT16) CPU_DATA_SEL); } - --=20 2.27.0.windows.1