Hi Sheng W
Just a reminder, please make sure your update can work on pure EDKII platform both IA32 and X64.
I recommend you validate the OVMF with SMM both IA32 and X64 to ensure there is no impact to the existing platform.
Thank you
Yao Jiewen
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Ni, Ray
Sent: Tuesday, October 27, 2020 5:44 PM
To: Sheng, W <w.sheng@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Adjust level paging type for Internal CR3
No. You cannot extern a variable defined only for x64. You may meet build failure in IA32 build.
From: Sheng, W <w.sheng@intel.com>
Sent: Tuesday, October 27, 2020 3:54 PM
To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Adjust level paging type for Internal CR3
Hi Ray,
Thank you for the review.
Sure. I will update the patch.
Sure. I will update the patch.
Sure. I will update the commit message.
gSmmFeatureEnable5LevelPaging is in platform smiEntry.nasm.
Yes, It is not a good variable here.
Do you think it is better to use extern “BOOLEAN m5LevelPagingNeeded;” in file Edk2/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c ?
Thank you.
BR
Sheng Wei
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Ni, Ray
Sent: 2020年10月27日 9:27
To: Sheng, W <w.sheng@intel.com>;
devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Adjust level paging type for Internal CR3
The overall logic looks good to me and I agree to add an internal function like the patch.
Some minor comments: