Re: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c

["Yao, Jiewen" <jiewen.yao@intel.com>]

HI Zucher
I am not sure why you only add a .c file, but do not add this c to any INF file. This seems a dummy C file.
I recommend you drop this and create a full patch to add C and update INF file.

Since you are talking performance and size, do you have any data?
For example, how fast you have got? What is the size difference before and after?
This can help other people make decision to choose which version.


Thank you
Yao Jiewen


> -----Original Message-----
> From: Christopher J Zurcher <christopher.j.zurcher@intel.com>
> Sent: Thursday, October 29, 2020 2:43 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Sung-Uk Bin <sunguk-bin@hp.com>; Ard
> Biesheuvel <ard.biesheuvel@arm.com>
> Subject: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for
> CryptAes.c
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507
> 
> This patch provides a drop-in replacement for CryptAes.c which utilizes
> the EVP interface to OpenSSL. This enables access to the assembly-optimized
> algorithms.
> 
> This patch has been unit-tested in both VS and CLANG build environments
> using both an X64 assembly-optimized implementation of OpensslLib and
> the
> standard implementation.
> 
> Usage of this file does not require an assembly-optimized implementation of
> OpensslLib to function; it does however require one to provide a speed
> improvement.
> 
> The C-only AES implementation included by CryptAes.c is extremely small,
> and since this file includes the EVP interface, it will significantly
> increase the size of any module that includes it. As a result, I have not
> replaced the original CryptAes.c as a default in any of the CryptLib
> implementations.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Sung-Uk Bin <sunguk-bin@hp.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Christopher J Zurcher (1):
>   CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c
> 
>  CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c | 262
> ++++++++++++++++++++
>  1 file changed, 262 insertions(+)
>  create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c
> 
> --
> 2.28.0.windows.1