From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.4174.1604106633237443424 for ; Fri, 30 Oct 2020 18:10:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ftdTTMLk; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 35gwd30pAhKc0AEvWuTLu0CO4HOZoL4IiLVrKw+CKowMIysI4FRXx+mOMOuhikKcZNoniGK/AG DYWP6t2U28mw== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="156460669" X-IronPort-AV: E=Sophos;i="5.77,435,1596524400"; d="scan'208";a="156460669" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 18:10:32 -0700 IronPort-SDR: SS3f+Yv2IPPveCFIA3XvwYuMm765n7jTDojleVVibiyvd4d4URaavUMWQhlK9xl6XPZn8KsbS8 c9pZAJ7h2E9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,435,1596524400"; d="scan'208";a="351442645" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 30 Oct 2020 18:10:32 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 18:10:31 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 18:10:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Oct 2020 18:10:31 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 30 Oct 2020 18:10:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KjC/DWhlSvX3D6a23YZZHp6MqgCude4LMGAbkF1v9Q5EWPIzUsh18APforgKAD+9Tza5CjLg5HfE9PDMWa3b5B+BbBmMhfN4/Yiry8NGw7oN9/U3qJFISYEalsFax3durbfPXjO6BqOSAgrjy76nCzasfLCp8vwQ2UpgPu0eVASuVBk/foH+580lvNJHralKK0B77a7gzLK6RBEK+BjpgUmAQ5bet6tjM5lCkHAwYaFrpEyMsS+5hKv1poOjYeowCb828roLB0mvuaRNv0WqvzrNZ75jj4AcOGaE2ys0mcdG0coviPXWGE0cdUVh92xLK+f0AmlhRpsq6EdCkwGSVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIFjdXoeqo8kXLDFf2jbsFaj3u3osm6O+G7jhx5Z2NU=; b=Sg+MFjgcbiKyuay5Sp0q+2TvHbjCj+c85qMXQ+Lu5QDovc9RqUu2TLyhstfxhu2Qk27TqgJkCRz7KkzaPeZoAPgcvPTYWkbrT6ysUcdNkuKwRjtNsmtwLpfnhMTS3eI2SOgrftlqeDRVKGwKx3GGh6ivQKSChnZ47mali0owRQ7/HWFQsIATZOuvv4pQSnRpU99KaA8L0CIpIJBojXAZnmjccER92PkgLHl892ZEkGni/3SyOIcWTDG4Uidf2BXr6s1WfOkcHA1nicyTnTgRap4WGUxLwjJSlb2FL/kDMS5AdBHUA9xraC3uAt7sFZGFSnumdrjWhoQwTVbwaA2tBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIFjdXoeqo8kXLDFf2jbsFaj3u3osm6O+G7jhx5Z2NU=; b=ftdTTMLktXuN0k4ZPyrZ3LMiadTXfvKLbxR2/yo15YfShAKI7LOlobbMeqJ5+IRU5jOGVvNYb9lzKCRFaL66JSTPAwH6HjDaxcTiB8AdojYNQ4KSC05ZyUVo6uLI41oAAmfTQJPhpauyql0Pp39aU2zrSgdI6paDSm760NJl1FM= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR1101MB2231.namprd11.prod.outlook.com (2603:10b6:910:1f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Sat, 31 Oct 2020 01:10:26 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac%10]) with mapi id 15.20.3477.028; Sat, 31 Oct 2020 01:10:26 +0000 From: "Yao, Jiewen" To: "Zurcher, Christopher J" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Jiang, Guomin" , Sung-Uk Bin , Ard Biesheuvel Subject: Re: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c Thread-Topic: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c Thread-Index: AQHWrVo1s+HCwcbLE0KI4UNqtIO/mKmw6OKw Date: Sat, 31 Oct 2020 01:10:26 +0000 Message-ID: References: <20201028184254.6923-1-christopher.j.zurcher@intel.com> In-Reply-To: <20201028184254.6923-1-christopher.j.zurcher@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.80.124.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70da23a4-b0b8-4e48-d5d9-08d87d39c031 x-ms-traffictypediagnostic: CY4PR1101MB2231: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gDizVE2OZoFQR9TadOj+eizRACYoQ0OAvX7Hl4uzt0N8L4AxbNmW8kdjI5bWzyb0z8r9XcuUv4EmumDWnjCEh03UrnYMHm4UOyuJenpdnRtC18euhbblLMh+Tmbg3wxNsHVqYgKSdTfJh1cjucNWBafEnzyk+uppURX5L5y5dmJLGUEMmznFbs2arW6jJQZ0ggHgQI0jgxy1tBNWukV9fUOIdAogra/miSKtYBLwQMJSNIVrrrBdfQ4bNxqFOhUj1IhbEeVe+Wl0BGoI4yS4MS3ZYG3rQXyS+m70PLacjlwUYiaYSzngArFRVAfEHf6yNMVC9Q3glLZPZf2D2qYiiI2ygtXdvSE65xkJr0Xb2Ic/5dCyMTHYMjGiOpcmbaIxC6m76JQQiF0cSTav/C5E9w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(64756008)(66476007)(66556008)(66946007)(26005)(66446008)(86362001)(71200400001)(110136005)(478600001)(186003)(2906002)(52536014)(33656002)(966005)(83380400001)(4326008)(316002)(54906003)(55016002)(76116006)(7696005)(9686003)(8676002)(53546011)(8936002)(6506007)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: IxoESBQ1kTEhHJfjXkGryLE0/+wm91FhOZp9NYVVRiMm1jQ12v11rUlQ7veOEjBTSbLuTBbimovQ2RTUBOJvRhokLDKAepBkP/KQDVUNgHyopdb5AfrMhqV/nfuzK4SgMIcmJvxjUiXiW1H7xZMHb6zQ5VfJhT0irjOAkSspWKAWncKFoAh0SDnq+kxWUa/IxPPuSTnmBoIVclpLKKfwExleWjxFU+ru9Wlnw+S6TGZ0MxvBW+yVsWRCk/CJOfntWEjUuK1TUhDFIeq9ymp1Qa8VJZQc9+mjYEZZVdqdRUU74JEUOG0TA71zgvwIQGILr5qx0ok2fJa+YYhoqyVfLuq30YqdE+z/K8Pfz4TiNQaT7liwEkKTGafozhkiUwAPIwyL54Ppg3loIm12llBSEfvSn2m1HziO6e298/x7LcWNGepMfpPxO8AlOdoNkR8oG+Rjw5MZszTyv5bZJ6ynUUm1cfaEjkQW6U6yIMFkDPQ9o8voDTPRblMRcdCqPaYhLlz/d7V1ZfuGUJq40Yd4RadUKMgdVYyTq7n05zgpK9hlacb1BHsqCEXaqqeEdgkdvt+UiXUbqJcW3PqJQEYD9xHV+MGOUB4pYSCdKARJWDgyTzEicfmAnm7XVoOikDNq11yuPgMqZTKyTOPkYi2Buw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70da23a4-b0b8-4e48-d5d9-08d87d39c031 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2020 01:10:26.2685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uz30PIOx3eFfBKiEC2tjADN4G0RpKKJUUdB6tXimL4scdf82dAgVqxFYpgOosC67JINUNOI82gohX7mpT7ME8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2231 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Zucher I am not sure why you only add a .c file, but do not add this c to any INF = file. This seems a dummy C file. I recommend you drop this and create a full patch to add C and update INF f= ile. Since you are talking performance and size, do you have any data? For example, how fast you have got? What is the size difference before and = after? This can help other people make decision to choose which version. Thank you Yao Jiewen > -----Original Message----- > From: Christopher J Zurcher > Sent: Thursday, October 29, 2020 2:43 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Lu, XiaoyuX ; Jiang, Guomi= n > ; Sung-Uk Bin ; Ard > Biesheuvel > Subject: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for > CryptAes.c >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2507 >=20 > This patch provides a drop-in replacement for CryptAes.c which utilizes > the EVP interface to OpenSSL. This enables access to the assembly-optimiz= ed > algorithms. >=20 > This patch has been unit-tested in both VS and CLANG build environments > using both an X64 assembly-optimized implementation of OpensslLib and > the > standard implementation. >=20 > Usage of this file does not require an assembly-optimized implementation = of > OpensslLib to function; it does however require one to provide a speed > improvement. >=20 > The C-only AES implementation included by CryptAes.c is extremely small, > and since this file includes the EVP interface, it will significantly > increase the size of any module that includes it. As a result, I have not > replaced the original CryptAes.c as a default in any of the CryptLib > implementations. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Sung-Uk Bin > Cc: Ard Biesheuvel >=20 > Christopher J Zurcher (1): > CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c >=20 > CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c | 262 > ++++++++++++++++++++ > 1 file changed, 262 insertions(+) > create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c >=20 > -- > 2.28.0.windows.1