From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>,
"matthewfcarlson@gmail.com" <matthewfcarlson@gmail.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, XiaoyuX" <xiaoyux.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"Leif Lindholm" <leif@nuviainc.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] [CryptoPkg] Add CC flags for MSVC ARM on IntrinsicLib
Date: Thu, 8 Oct 2020 00:26:09 +0000 [thread overview]
Message-ID: <CY4PR11MB128822FB762B3CD444848DE68C0B0@CY4PR11MB1288.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c7ca6d90-3124-9a79-4136-db3290ffd8f5@arm.com>
Need ARM or compiler expert to give R-B.
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel
> Sent: Thursday, October 8, 2020 2:45 AM
> To: matthewfcarlson@gmail.com; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>;
> Leif Lindholm <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] [CryptoPkg] Add CC flags for MSVC
> ARM on IntrinsicLib
>
> On 10/7/20 8:41 PM, matthewfcarlson@gmail.com wrote:
> > From: Matthew Carlson <matthewfcarlson@gmail.com>
> >
> > This adds compiler flags for AARCH64 and ARM for the Visual Studio
> > compilers to the IntrinsicLib inf.
> >
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>
>
> Hi Matt,
>
> Please don't put the package name in [] in the subject line. That will
> cause 'git am' to strip it when applying the patch.
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
>
> > ---
> > CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > index fcbb93316cf7..ad05b3a000c4 100644
> > --- a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > +++ b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> > @@ -64,4 +64,6 @@
> > MSFT:RELEASE_*_IA32_CC_FLAGS == /nologo /c /WX /GS- /W4
> /Gs32768 /D UNICODE /O1b2 /FIAutoGen.h /EHs-c- /GR- /GF
> > MSFT:DEBUG_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4
> /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm
> > MSFT:RELEASE_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4
> /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF
> > - INTEL:*_*_*_CC_FLAGS = /Oi-
> > + MSFT:DEBUG_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4
> /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm
> > + MSFT:RELEASE_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4
> /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF
> > + INTEL:*_*_*_CC_FLAGS = /Oi-
> >
>
>
>
>
>
next prev parent reply other threads:[~2020-10-08 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 18:41 [PATCH v1 0/1] [CryptoPkg] Add CC flags to IntrinsicLib Matthew Carlson
2020-10-07 18:41 ` [PATCH v1 1/1] [CryptoPkg] Add CC flags for MSVC ARM on IntrinsicLib Matthew Carlson
2020-10-07 18:44 ` Ard Biesheuvel
2020-10-08 0:26 ` Yao, Jiewen [this message]
2020-10-08 11:13 ` Leif Lindholm
2020-10-08 11:33 ` IntrinsicsLib - Was: " Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB128822FB762B3CD444848DE68C0B0@CY4PR11MB1288.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox