* [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver @ 2020-09-15 6:21 Qi Zhang 2020-09-15 6:21 ` [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex Qi Zhang ` (3 more replies) 0 siblings, 4 replies; 10+ messages in thread From: Qi Zhang @ 2020-09-15 6:21 UTC (permalink / raw) To: devel Cc: Qi Zhang, Chasel Chiu, Nate DeSimone, Star Zeng, Jiewen Yao, Jian J Wang Some open board are TPM disabled. So the boot may hang because these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where it is used. So we need to remove these PPIs from Depex for Fsp wrapper PEI and PeiTpmMeasurementLib. Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Qi Zhang (2): IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) -- 2.26.2.windows.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex 2020-09-15 6:21 [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Qi Zhang @ 2020-09-15 6:21 ` Qi Zhang 2020-09-16 2:07 ` Chiu, Chasel 2020-09-15 6:21 ` [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid Qi Zhang ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Qi Zhang @ 2020-09-15 6:21 UTC (permalink / raw) To: devel; +Cc: Qi Zhang, Chasel Chiu, Nate DeSimone, Star Zeng, Cc : Jiewen Yao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2963 Cc: Chasel Chiu <chasel.chiu@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Cc: Jiewen Yao <jiewen.yao@intel.com> Signed-off-by: Qi Zhang <qi1.zhang@intel.com> --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf index c3578397b6..00166e56a0 100644 --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf @@ -73,5 +73,4 @@ gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid ## PRODUCES [Depex] - gEfiPeiMasterBootModePpiGuid AND - gPeiTpmInitializationDonePpiGuid + gEfiPeiMasterBootModePpiGuid diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf index 884514747f..aeeca58d6d 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf @@ -77,5 +77,4 @@ FspsWrapperPeim.c [Depex] - gEfiPeiMemoryDiscoveredPpiGuid AND - gPeiTpmInitializationDonePpiGuid + gEfiPeiMemoryDiscoveredPpiGuid -- 2.26.2.windows.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex 2020-09-15 6:21 ` [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex Qi Zhang @ 2020-09-16 2:07 ` Chiu, Chasel 0 siblings, 0 replies; 10+ messages in thread From: Chiu, Chasel @ 2020-09-16 2:07 UTC (permalink / raw) To: Zhang, Qi1, devel@edk2.groups.io Cc: Desimone, Nathaniel L, Zeng, Star, Yao, Jiewen Reviewed-by: Chasel Chiu <chasel.chiu@intel.com> > -----Original Message----- > From: Zhang, Qi1 <qi1.zhang@intel.com> > Sent: Tuesday, September 15, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star > <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> > Subject: [PATCH 1/2] IntelFsp2WrapperPkg: remove > gPeiTpmInitializationDonePpiGuid from Depex > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2963 > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Cc: Jiewen Yao <jiewen.yao@intel.com> > Signed-off-by: Qi Zhang <qi1.zhang@intel.com> > --- > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > index c3578397b6..00166e56a0 100644 > --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > @@ -73,5 +73,4 @@ > gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid ## > PRODUCES [Depex]- gEfiPeiMasterBootModePpiGuid AND- > gPeiTpmInitializationDonePpiGuid+ gEfiPeiMasterBootModePpiGuiddiff > --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf > b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf > index 884514747f..aeeca58d6d 100644 > --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf > +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf > @@ -77,5 +77,4 @@ > FspsWrapperPeim.c [Depex]- gEfiPeiMemoryDiscoveredPpiGuid AND- > gPeiTpmInitializationDonePpiGuid+ gEfiPeiMemoryDiscoveredPpiGuid-- > 2.26.2.windows.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid 2020-09-15 6:21 [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Qi Zhang 2020-09-15 6:21 ` [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex Qi Zhang @ 2020-09-15 6:21 ` Qi Zhang 2020-09-16 2:09 ` [edk2-devel] " Yao, Jiewen 2020-09-16 8:42 ` development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] Laszlo Ersek 2020-09-16 9:34 ` [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Yao, Jiewen 3 siblings, 1 reply; 10+ messages in thread From: Qi Zhang @ 2020-09-15 6:21 UTC (permalink / raw) To: devel; +Cc: Qi Zhang, Jiewen Yao, Jian J Wang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2963 Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Signed-off-by: Qi Zhang <qi1.zhang@intel.com> --- .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf b/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf index 6625d0fd01..be5e344d7f 100644 --- a/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf +++ b/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf @@ -46,5 +46,4 @@ gEdkiiTcgPpiGuid ## CONSUMES [Depex] - gEfiPeiMasterBootModePpiGuid AND - gEfiTpmDeviceSelectedGuid + gEfiPeiMasterBootModePpiGuid -- 2.26.2.windows.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid 2020-09-15 6:21 ` [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid Qi Zhang @ 2020-09-16 2:09 ` Yao, Jiewen 0 siblings, 0 replies; 10+ messages in thread From: Yao, Jiewen @ 2020-09-16 2:09 UTC (permalink / raw) To: devel@edk2.groups.io, Zhang, Qi1; +Cc: Wang, Jian J Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Qi Zhang > Sent: Tuesday, September 15, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; > Wang, Jian J <jian.j.wang@intel.com> > Subject: [edk2-devel] [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove > gEfiTpmDeviceSelectedGuid > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2963 > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Signed-off-by: Qi Zhang <qi1.zhang@intel.com> > --- > .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git > a/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > b/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > index 6625d0fd01..be5e344d7f 100644 > --- a/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > +++ b/SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf > @@ -46,5 +46,4 @@ > gEdkiiTcgPpiGuid ## CONSUMES > > > > [Depex] > > - gEfiPeiMasterBootModePpiGuid AND > > - gEfiTpmDeviceSelectedGuid > > + gEfiPeiMasterBootModePpiGuid > > -- > 2.26.2.windows.1 > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#65258): https://edk2.groups.io/g/devel/message/65258 > Mute This Topic: https://groups.io/mt/76859555/1772286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] > -=-=-=-=-=-= ^ permalink raw reply [flat|nested] 10+ messages in thread
* development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] 2020-09-15 6:21 [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Qi Zhang 2020-09-15 6:21 ` [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex Qi Zhang 2020-09-15 6:21 ` [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid Qi Zhang @ 2020-09-16 8:42 ` Laszlo Ersek 2020-09-16 9:31 ` Yao, Jiewen 2020-09-16 9:34 ` [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Yao, Jiewen 3 siblings, 1 reply; 10+ messages in thread From: Laszlo Ersek @ 2020-09-16 8:42 UTC (permalink / raw) To: Chasel Chiu, Jiewen Yao Cc: devel, qi1.zhang, Nate DeSimone, Star Zeng, Jian J Wang Jiewen, Chasel, On 09/15/20 08:21, Qi Zhang wrote: > Some open board are TPM disabled. So the boot may hang because > these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where > it is used. So we need to remove these PPIs from Depex for Fsp wrapper > PEI and PeiTpmMeasurementLib. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > > Qi Zhang (2): > IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from > Depex > SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid > > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- > .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > Please adopt a *much more* disciplined approach when merging patch series. (1) When you merge a patch set, please report back on the list. Identify both the pull request URL, and the commit reange. In this case, the pull request was https://github.com/tianocore/edk2/pull/930 and the commit range is a62fb4229d14..7bcb021a6d54. (2) The associated Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2963 has been completely neglected, by both submitter and maintainers. - The original BZ report is *absolute trash*. - No URL into the mailing list archive has been captured in the BZ, about the posted series. - The BZ status is still CONFIRMED. - No mention of the pull request, or the resultant commit, range in the BZ ticket. (3) The github pull request at <https://github.com/tianocore/edk2/pull/930> does contain *any* indication of the bugzilla ticket, or the cover letter on the list. Basically we have random artifacts in three different places (Bugzilla, github.com, mailing list), and nobody of the involved parties (reviewers, maintainers, constributors) on this patch set have made *any* effort to cross-reference them. We now have to hunt down everything separately. (4) Worst of all, the subject line of commit 414d7d11e6ea contains a Unicode code point called FULLWIDTH COLON (U+FF1A) rather than a normal colon (U+003A). Compare: - bad (current): IntelFsp2WrapperPkg: remove [...] - good (should have been): IntelFsp2WrapperPkg: remove [...] It makes absolutely no sense to use non-ASCII code points in subject lines, for something as trivial as a colon. I've been here for 8-9 years now and it's incredibly frustrating that I *still* have to whine about basic stuff like this on a regular basis. I don't even know whom I should CC at Intel (management or otherwise) to see an improvement in attitude here. I guess this community cannot be saved. Laszlo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] 2020-09-16 8:42 ` development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] Laszlo Ersek @ 2020-09-16 9:31 ` Yao, Jiewen 2020-09-16 12:13 ` Laszlo Ersek 0 siblings, 1 reply; 10+ messages in thread From: Yao, Jiewen @ 2020-09-16 9:31 UTC (permalink / raw) To: Laszlo Ersek, Chiu, Chasel Cc: devel@edk2.groups.io, Zhang, Qi1, Desimone, Nathaniel L, Zeng, Star, Wang, Jian J Hi Laszlo Thanks. I agree 1, 2, 3. I take the blame. It is my fault. For 4, it is out of my scope. I cannot find this by my eyes. Everything works well on my side. Can we improve patch checker to catch this in CI ? I don’t think I can find any Unicode in code or commit message easily. I prefer to let a tool to do that work. Thank you Yao Jiewen > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Wednesday, September 16, 2020 4:43 PM > To: Chiu, Chasel <chasel.chiu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> > Cc: devel@edk2.groups.io; Zhang, Qi1 <qi1.zhang@intel.com>; Desimone, > Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star > <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > Subject: development process failure [was: remove TPM related ppi from Depex > for Fsp wrapper PEIM driver] > > Jiewen, Chasel, > > On 09/15/20 08:21, Qi Zhang wrote: > > Some open board are TPM disabled. So the boot may hang because > > these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where > > it is used. So we need to remove these PPIs from Depex for Fsp wrapper > > PEI and PeiTpmMeasurementLib. > > > > Cc: Chasel Chiu <chasel.chiu@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > > Cc: Star Zeng <star.zeng@intel.com> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > > > Qi Zhang (2): > > IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from > > Depex > > SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid > > > > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- > > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- > > .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- > > 3 files changed, 3 insertions(+), 6 deletions(-) > > > > Please adopt a *much more* disciplined approach when merging patch series. > > > (1) When you merge a patch set, please report back on the list. Identify > both the pull request URL, and the commit reange. > > In this case, the pull request was > > https://github.com/tianocore/edk2/pull/930 > > and the commit range is a62fb4229d14..7bcb021a6d54. > > > (2) The associated Bugzilla: > > https://bugzilla.tianocore.org/show_bug.cgi?id=2963 > > has been completely neglected, by both submitter and maintainers. > > - The original BZ report is *absolute trash*. > > - No URL into the mailing list archive has been captured in the BZ, > about the posted series. > > - The BZ status is still CONFIRMED. > > - No mention of the pull request, or the resultant commit, range in the > BZ ticket. > > > (3) The github pull request at > <https://github.com/tianocore/edk2/pull/930> does contain *any* > indication of the bugzilla ticket, or the cover letter on the list. > > Basically we have random artifacts in three different places (Bugzilla, > github.com, mailing list), and nobody of the involved parties > (reviewers, maintainers, constributors) on this patch set have made > *any* effort to cross-reference them. We now have to hunt down > everything separately. > > > (4) Worst of all, the subject line of commit 414d7d11e6ea contains a > Unicode code point called FULLWIDTH COLON (U+FF1A) rather than a normal > colon (U+003A). > > Compare: > > - bad (current): IntelFsp2WrapperPkg: remove [...] > - good (should have been): IntelFsp2WrapperPkg: remove [...] > > It makes absolutely no sense to use non-ASCII code points in subject > lines, for something as trivial as a colon. > > > I've been here for 8-9 years now and it's incredibly frustrating that I > *still* have to whine about basic stuff like this on a regular basis. > > I don't even know whom I should CC at Intel (management or otherwise) to > see an improvement in attitude here. > > I guess this community cannot be saved. > > Laszlo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] 2020-09-16 9:31 ` Yao, Jiewen @ 2020-09-16 12:13 ` Laszlo Ersek 2020-09-16 12:30 ` Yao, Jiewen 0 siblings, 1 reply; 10+ messages in thread From: Laszlo Ersek @ 2020-09-16 12:13 UTC (permalink / raw) To: Yao, Jiewen, Chiu, Chasel Cc: devel@edk2.groups.io, Zhang, Qi1, Desimone, Nathaniel L, Zeng, Star, Wang, Jian J On 09/16/20 11:31, Yao, Jiewen wrote: > Hi Laszlo > Thanks. I agree 1, 2, 3. I take the blame. It is my fault. > > For 4, it is out of my scope. I cannot find this by my eyes. Everything works well on my side. > Can we improve patch checker to catch this in CI ? > I don’t think I can find any Unicode in code or commit message easily. > I prefer to let a tool to do that work. Yes, we could perhaps enhance "BaseTools/Scripts/PatchCheck.py" to require subjects to be 7-bit ASCII only. (And then some people would disagree...) I guess the idea is, unless it's a proper name being inserted in the subject line, we should stick with 7-bit ASCII. For example, we should reject U+FF1A (because U+003A is the right code point), but we should still accept proper names in full UTF-8 (maybe not even restricted to Latin script only)! I don't know how this could be implemented in "PatchCheck.py"... I guess what I would prefer is if contributors' input devices were configured accordingly. When they press a key that promises to insert a colon -- that is, when it *looks like* a colon --, then the symbol should *become* a colon -- that is, U+003A, and not U+FF1A. Thanks, Laszlo >> -----Original Message----- >> From: Laszlo Ersek <lersek@redhat.com> >> Sent: Wednesday, September 16, 2020 4:43 PM >> To: Chiu, Chasel <chasel.chiu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com> >> Cc: devel@edk2.groups.io; Zhang, Qi1 <qi1.zhang@intel.com>; Desimone, >> Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star >> <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com> >> Subject: development process failure [was: remove TPM related ppi from Depex >> for Fsp wrapper PEIM driver] >> >> Jiewen, Chasel, >> >> On 09/15/20 08:21, Qi Zhang wrote: >>> Some open board are TPM disabled. So the boot may hang because >>> these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where >>> it is used. So we need to remove these PPIs from Depex for Fsp wrapper >>> PEI and PeiTpmMeasurementLib. >>> >>> Cc: Chasel Chiu <chasel.chiu@intel.com> >>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> >>> Cc: Star Zeng <star.zeng@intel.com> >>> Cc: Jiewen Yao <jiewen.yao@intel.com> >>> Cc: Jian J Wang <jian.j.wang@intel.com> >>> >>> Qi Zhang (2): >>> IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from >>> Depex >>> SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid >>> >>> IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- >>> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- >>> .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- >>> 3 files changed, 3 insertions(+), 6 deletions(-) >>> >> >> Please adopt a *much more* disciplined approach when merging patch series. >> >> >> (1) When you merge a patch set, please report back on the list. Identify >> both the pull request URL, and the commit reange. >> >> In this case, the pull request was >> >> https://github.com/tianocore/edk2/pull/930 >> >> and the commit range is a62fb4229d14..7bcb021a6d54. >> >> >> (2) The associated Bugzilla: >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=2963 >> >> has been completely neglected, by both submitter and maintainers. >> >> - The original BZ report is *absolute trash*. >> >> - No URL into the mailing list archive has been captured in the BZ, >> about the posted series. >> >> - The BZ status is still CONFIRMED. >> >> - No mention of the pull request, or the resultant commit, range in the >> BZ ticket. >> >> >> (3) The github pull request at >> <https://github.com/tianocore/edk2/pull/930> does contain *any* >> indication of the bugzilla ticket, or the cover letter on the list. >> >> Basically we have random artifacts in three different places (Bugzilla, >> github.com, mailing list), and nobody of the involved parties >> (reviewers, maintainers, constributors) on this patch set have made >> *any* effort to cross-reference them. We now have to hunt down >> everything separately. >> >> >> (4) Worst of all, the subject line of commit 414d7d11e6ea contains a >> Unicode code point called FULLWIDTH COLON (U+FF1A) rather than a normal >> colon (U+003A). >> >> Compare: >> >> - bad (current): IntelFsp2WrapperPkg: remove [...] >> - good (should have been): IntelFsp2WrapperPkg: remove [...] >> >> It makes absolutely no sense to use non-ASCII code points in subject >> lines, for something as trivial as a colon. >> >> >> I've been here for 8-9 years now and it's incredibly frustrating that I >> *still* have to whine about basic stuff like this on a regular basis. >> >> I don't even know whom I should CC at Intel (management or otherwise) to >> see an improvement in attitude here. >> >> I guess this community cannot be saved. >> >> Laszlo > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] 2020-09-16 12:13 ` Laszlo Ersek @ 2020-09-16 12:30 ` Yao, Jiewen 0 siblings, 0 replies; 10+ messages in thread From: Yao, Jiewen @ 2020-09-16 12:30 UTC (permalink / raw) To: Laszlo Ersek, Chiu, Chasel Cc: devel@edk2.groups.io, Zhang, Qi1, Desimone, Nathaniel L, Zeng, Star, Wang, Jian J, Yao, Jiewen Right. Now I understand why this is not enforced before - We do support Unicode in some content. Unfortunately, I don’t think you can enforce the contributor's keyboard device. We sometime write different document with different context, and switch between English and other language. It is not feasible. We do out best, but we still make mistakes. I still prefer a tool to do some simple check. For example, dash "-", colon ":", quote "\"", bracket "()" - per my experience. If you really only care about "REF: ", then we can only add check for "REF :", together with "Cc:", "Reviewed-by:", "Signed-off-by:", etc, to ensure they are using correct ":". Thank you Yao Jiewen > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Wednesday, September 16, 2020 8:14 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> > Cc: devel@edk2.groups.io; Zhang, Qi1 <qi1.zhang@intel.com>; Desimone, > Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star > <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > Subject: Re: development process failure [was: remove TPM related ppi from > Depex for Fsp wrapper PEIM driver] > > On 09/16/20 11:31, Yao, Jiewen wrote: > > Hi Laszlo > > Thanks. I agree 1, 2, 3. I take the blame. It is my fault. > > > > For 4, it is out of my scope. I cannot find this by my eyes. Everything works > well on my side. > > Can we improve patch checker to catch this in CI ? > > I don’t think I can find any Unicode in code or commit message easily. > > I prefer to let a tool to do that work. > > Yes, we could perhaps enhance "BaseTools/Scripts/PatchCheck.py" to > require subjects to be 7-bit ASCII only. (And then some people would > disagree...) > > I guess the idea is, unless it's a proper name being inserted in the > subject line, we should stick with 7-bit ASCII. For example, we should > reject U+FF1A (because U+003A is the right code point), but we should > still accept proper names in full UTF-8 (maybe not even restricted to > Latin script only)! > > I don't know how this could be implemented in "PatchCheck.py"... > > I guess what I would prefer is if contributors' input devices were > configured accordingly. When they press a key that promises to insert a > colon -- that is, when it *looks like* a colon --, then the symbol > should *become* a colon -- that is, U+003A, and not U+FF1A. > > Thanks, > Laszlo > > > >> -----Original Message----- > >> From: Laszlo Ersek <lersek@redhat.com> > >> Sent: Wednesday, September 16, 2020 4:43 PM > >> To: Chiu, Chasel <chasel.chiu@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com> > >> Cc: devel@edk2.groups.io; Zhang, Qi1 <qi1.zhang@intel.com>; Desimone, > >> Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star > >> <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > >> Subject: development process failure [was: remove TPM related ppi from > Depex > >> for Fsp wrapper PEIM driver] > >> > >> Jiewen, Chasel, > >> > >> On 09/15/20 08:21, Qi Zhang wrote: > >>> Some open board are TPM disabled. So the boot may hang because > >>> these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where > >>> it is used. So we need to remove these PPIs from Depex for Fsp wrapper > >>> PEI and PeiTpmMeasurementLib. > >>> > >>> Cc: Chasel Chiu <chasel.chiu@intel.com> > >>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > >>> Cc: Star Zeng <star.zeng@intel.com> > >>> Cc: Jiewen Yao <jiewen.yao@intel.com> > >>> Cc: Jian J Wang <jian.j.wang@intel.com> > >>> > >>> Qi Zhang (2): > >>> IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from > >>> Depex > >>> SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid > >>> > >>> IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- > >>> IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- > >>> .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- > >>> 3 files changed, 3 insertions(+), 6 deletions(-) > >>> > >> > >> Please adopt a *much more* disciplined approach when merging patch series. > >> > >> > >> (1) When you merge a patch set, please report back on the list. Identify > >> both the pull request URL, and the commit reange. > >> > >> In this case, the pull request was > >> > >> https://github.com/tianocore/edk2/pull/930 > >> > >> and the commit range is a62fb4229d14..7bcb021a6d54. > >> > >> > >> (2) The associated Bugzilla: > >> > >> https://bugzilla.tianocore.org/show_bug.cgi?id=2963 > >> > >> has been completely neglected, by both submitter and maintainers. > >> > >> - The original BZ report is *absolute trash*. > >> > >> - No URL into the mailing list archive has been captured in the BZ, > >> about the posted series. > >> > >> - The BZ status is still CONFIRMED. > >> > >> - No mention of the pull request, or the resultant commit, range in the > >> BZ ticket. > >> > >> > >> (3) The github pull request at > >> <https://github.com/tianocore/edk2/pull/930> does contain *any* > >> indication of the bugzilla ticket, or the cover letter on the list. > >> > >> Basically we have random artifacts in three different places (Bugzilla, > >> github.com, mailing list), and nobody of the involved parties > >> (reviewers, maintainers, constributors) on this patch set have made > >> *any* effort to cross-reference them. We now have to hunt down > >> everything separately. > >> > >> > >> (4) Worst of all, the subject line of commit 414d7d11e6ea contains a > >> Unicode code point called FULLWIDTH COLON (U+FF1A) rather than a normal > >> colon (U+003A). > >> > >> Compare: > >> > >> - bad (current): IntelFsp2WrapperPkg: remove [...] > >> - good (should have been): IntelFsp2WrapperPkg: remove [...] > >> > >> It makes absolutely no sense to use non-ASCII code points in subject > >> lines, for something as trivial as a colon. > >> > >> > >> I've been here for 8-9 years now and it's incredibly frustrating that I > >> *still* have to whine about basic stuff like this on a regular basis. > >> > >> I don't even know whom I should CC at Intel (management or otherwise) to > >> see an improvement in attitude here. > >> > >> I guess this community cannot be saved. > >> > >> Laszlo > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver 2020-09-15 6:21 [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Qi Zhang ` (2 preceding siblings ...) 2020-09-16 8:42 ` development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] Laszlo Ersek @ 2020-09-16 9:34 ` Yao, Jiewen 3 siblings, 0 replies; 10+ messages in thread From: Yao, Jiewen @ 2020-09-16 9:34 UTC (permalink / raw) To: Zhang, Qi1, devel@edk2.groups.io Cc: Chiu, Chasel, Desimone, Nathaniel L, Zeng, Star, Wang, Jian J Patch is merged. The pull request was https://github.com/tianocore/edk2/pull/930 and the commit range is a62fb4229d14..7bcb021a6d54. Thank you Yao Jiewen > -----Original Message----- > From: Zhang, Qi1 <qi1.zhang@intel.com> > Sent: Tuesday, September 15, 2020 2:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; > Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star > <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com> > Subject: [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM > driver > > Some open board are TPM disabled. So the boot may hang because > these PPIs can't arrive. And gEdkiiTcgPpiGuid will be notified where > it is used. So we need to remove these PPIs from Depex for Fsp wrapper > PEI and PeiTpmMeasurementLib. > > Cc: Chasel Chiu <chasel.chiu@intel.com> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > > Qi Zhang (2): > IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from > Depex > SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid > > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 3 +-- > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 3 +-- > .../Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > -- > 2.26.2.windows.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-16 12:30 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-09-15 6:21 [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Qi Zhang 2020-09-15 6:21 ` [PATCH 1/2] IntelFsp2WrapperPkg: remove gPeiTpmInitializationDonePpiGuid from Depex Qi Zhang 2020-09-16 2:07 ` Chiu, Chasel 2020-09-15 6:21 ` [PATCH 2/2] SecurityPkg/PeiTpmMeasurementLib: remove gEfiTpmDeviceSelectedGuid Qi Zhang 2020-09-16 2:09 ` [edk2-devel] " Yao, Jiewen 2020-09-16 8:42 ` development process failure [was: remove TPM related ppi from Depex for Fsp wrapper PEIM driver] Laszlo Ersek 2020-09-16 9:31 ` Yao, Jiewen 2020-09-16 12:13 ` Laszlo Ersek 2020-09-16 12:30 ` Yao, Jiewen 2020-09-16 9:34 ` [PATCH 0/2] remove TPM related ppi from Depex for Fsp wrapper PEIM driver Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox