From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.7915.1604642185604399800 for ; Thu, 05 Nov 2020 21:56:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=e+jaMfLN; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) IronPort-SDR: j1dLYymH08v1jOXGxBMA/xRe8DeO/VBtI/Peu3QUO6T00ZL5OwwfMc5W/ZPINdJjqfAQZsNJ3x VDyb3PNhAxgg== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="157285561" X-IronPort-AV: E=Sophos;i="5.77,455,1596524400"; d="scan'208";a="157285561" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 21:56:24 -0800 IronPort-SDR: 8mkEgJS1Oagf3e4FdRDT//Z3fX3pdFqapUc1zV3A0edoE/wQbo93zI6qBTtTm7BK1HdeytE1Rh 6OH1ikNBFlpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,455,1596524400"; d="scan'208";a="364593289" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 05 Nov 2020 21:56:17 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 21:56:17 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 21:56:16 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 5 Nov 2020 21:56:16 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 5 Nov 2020 21:56:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nTEZlMbYW9IkrLBirjN6A82JXGNvVJMORQlu91NRu2bkLQldjCntqf9c+xTgmM/IASbvM9XtY5bmpCdPA3bFRk6Ol+1dOjqjHVhhrJiObZJRj/G/x8b3js9lN/ztKWqJaVAoHpS2Zd/3JgkBRdqhcBj9IhAfshdzd5HU5ndsFCbP+O0strGBBw+rvt2vXOyQsOkJauzyWgk6Ek05BlP9I3dM093sY/Afo0MZwwOXnjD6cgalusmlQr1Ck7ORiw46jxgqgSaoFamdh6txkrHAL3plS+OCtlw51O5mbu2n6pdaBmSDd1FnXjy1rrv1AiqRpx7LCY1WdYmH0Q6LJxlIMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgNA04rRYYyoZ2DebDjARad/kwC+IKdDpcvOHcuOt7I=; b=eTxAhvzyK6P2+yY6th4QGlocGvZtWQD3lwK8poFtRfZWtEyZd6RlaTU4HLEyPwzyzlf/sqSoeXf40PNMVcFGDOKDi+CMbfSnsAeAsZ654MLft1WX/OSVMi5Gw9Ugn3RH04sKG6rb9PONIBf9bV8Dom86YNwWwXy2mjRSq54qeosOhal8g3n2ggoPBHwvHkqwPcvw/Z324pAs36YLsUGsgB7WcoLHtbFJQzsI5Ft9NtFVjqcsrTgfoiZUgupq0j3HlBfTyO+8Nw9ojoogH1ENvWbvbM9GcKOpPVOlyhbEnBpWVC0xh9cAJLbn8ZrLr1c5+/Am1sLad2KnFT3R4fP1uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgNA04rRYYyoZ2DebDjARad/kwC+IKdDpcvOHcuOt7I=; b=e+jaMfLNJ29mLBhaIAOB6OilIh7ISRMm9w8hUYXBjjJgOz/+x2OekCJW7eNEBJAT5E9f29a9XCgEB42AbTki98Y4fkroGZ0fm60bucnMefn5Ah7vdPITk4cDneNCxbcKVrRsD14+70VtKuZek5/0DaR7jX2Lse++xK1rAWANEk4= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR11MB0005.namprd11.prod.outlook.com (2603:10b6:910:7a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Fri, 6 Nov 2020 05:56:15 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::a188:2994:6c14:aad7]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::a188:2994:6c14:aad7%12]) with mapi id 15.20.3499.032; Fri, 6 Nov 2020 05:56:14 +0000 From: "Yao, Jiewen" To: "Zurcher, Christopher J" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , "Ard Biesheuvel" Subject: Re: [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64 Thread-Topic: [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64 Thread-Index: AQHWsiyB4+1/v20uXEu0lqu2S9yUHqm6nppA Date: Fri, 6 Nov 2020 05:56:14 +0000 Message-ID: References: <20201103215834.7533-1-christopher.j.zurcher@intel.com> In-Reply-To: <20201103215834.7533-1-christopher.j.zurcher@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62afe942-3f2e-42bd-650b-08d88218ac03 x-ms-traffictypediagnostic: CY4PR11MB0005: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fY++ysQYGlq3xlwGRvzvjp4EPh5jocDyybG8zOdnKk2UAs3kAzFMbyehvxaiGm+2XodYxWNm4wsnCBuzuaXOPg1cuw44jaf9iP+FZegAc4YyLdACr6FUsLg1fqVQrHsmXutuNNI2BfJzG0LDyAAL+1/rnqX2ukjPyrMGc2RkUquORnKSS4gfiqxK4a7a/gd/l1e/zUQa9fz7A54oS+430ooZ9z8W2jGszaKgN38uv2jjHq/UyU4MPIefoeHUyYueJmWYwrhqjR5v44pqw9QMgyGbDO2XKQ57eE2P9JFzoX9b7O4myJ9uC6f9/dS2NpILD88k68/tsn1M3oSDQ939Kw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(110136005)(316002)(54906003)(4326008)(86362001)(52536014)(8936002)(26005)(186003)(8676002)(9686003)(55016002)(478600001)(66476007)(6506007)(53546011)(7696005)(83380400001)(5660300002)(19627235002)(33656002)(76116006)(2906002)(71200400001)(66946007)(64756008)(66556008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Wiohbqu/99DD7SiWYlWbwXFKdETaC2NVS2sTNgjnaUi9ECAVJ3r9nje5trgoR7Op2jDNh3WbuYhu/GihXXqdFybQ92IgZQRiql2Ughye7bb4+pK21PaQ4WixnDheEePhrBPcLtHOrLfrcEest0LkxoGsC9mm3VyHTTa7PwjTLaQyJ7Z43dCs8OriFRv0s/khSV1QQQuzclzggQnLY2fMVvh1D5JtGW8mQ6lDKMUYBC9GlZhWRScsb+0r/6HP1C7DC6sgDsh1SZmQ9mTGY9Zs5Dl5dTKc5cRYa7+Z0nJiOIsVpVwzhLQjNtlQ7K46g3wtDSwzQN49bmGAZWYdkP23cfpwzqp1R0hYo8qpSxTxhC9YWdEJiO+Dwv+qdnx97nvYrbu2C3io3aqi3HwDt+AvV7WWbeRCzcmVRHD2ZRv8vWvGoVyUXo4XoN9QuYE6aBuMqHZGTumq8N1c8IdU0ow53XmxOPzVb7M7JR0K4bJG0DaJ7ZEbU2NvAUJHz8CQTHGyVxdX+eDMvdJ1ClTnG5u7GmhPitT2R2I7yyrysz7cP/LA1rS57CSnasMiSYqpyat/1v6dpKEI6WsPQ09nsj51rvEfzMe6wci+laY4NcDa3HkbcloB2JN3xNJ2xEIq4qCo0a9mf5xObQwPzvNhFiWCAg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62afe942-3f2e-42bd-650b-08d88218ac03 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2020 05:56:14.8285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SKUY8Bo5u2riko68PHg3Ir9IjkvZlbSPisGeYxkwC0PvsFFaN5QW+rBhexkqzBxeaYrhQ0BCJ/IcTKqqsmisUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0005 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch 1/2 reviewed-by: Jiewen Yao > -----Original Message----- > From: Christopher J Zurcher > Sent: Wednesday, November 4, 2020 5:59 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Lu, XiaoyuX ; Kinney, > Michael D ; Ard Biesheuvel > > Subject: [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction > support for X64 >=20 > V5 Changes: > Move ApiHooks.c into X64 folder > Update process_files.pl to clean architecture-specific subfolders witho= ut > removing them > Rebased INF file to merge latest changes regarding RngLib vs. TimerLib >=20 > V4 Changes: > Add copyright header to uefi-asm.conf > Move [Sources.X64] block to cover entire X64-specific config >=20 > V3 Changes: > Added definitions for ptrdiff_t and wchar_t to CrtLibSupport.h for > LLVM/Clang build support. > Added -UWIN32 to GCC Flags for LLVM/Clang build support. > Added missing AES GCM assembly file. >=20 > V2 Changes: > Limit scope of assembly config to SHA and AES functions. > Removed IA32 native support (reduced config was causing build failure a= nd > can be added in a later patch). > Removed XMM instructions from assembly generation. > Added automatic copyright header porting for generated assembly files. >=20 > This patch adds support for building the native instruction algorithms fo= r > the X64 architecture in OpensslLib. The process_files.pl script was modif= ied > to parse the .asm file targets from the OpenSSL build config data struct,= and > generate the necessary assembly files for the EDK2 build environment. >=20 > For the X64 variant, OpenSSL includes calls to a Windows error handling A= PI, > and that function has been stubbed out in ApiHooks.c. >=20 > For all variants, a constructor is added to call the required CPUID funct= ion > within OpenSSL to facilitate processor capability checks in the native > algorithms. >=20 > Additional native architecture variants should be simple to add by follow= ing > the changes made for this architecture. >=20 > The OpenSSL assembly files are traditionally generated at build time usin= g a > perl script. To avoid that burden on EDK2 users, these end-result assembl= y > files are generated during the configuration steps performed by the packa= ge > maintainer (through process_files.pl). The perl generator scripts inside > OpenSSL do not parse file comments as they are only meant to create > intermediate build files, so process_files.pl contains additional hooks t= o > preserve the copyright headers as well as clean up tabs and line endings = to > comply with EDK2 coding standards. The resulting file headers align with > the generated .h files which are already included in the EDK2 repository. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Mike Kinney > Cc: Ard Biesheuvel >=20 > Christopher J Zurcher (2): > CryptoPkg/OpensslLib: Add native instruction support for X64 > CryptoPkg/OpensslLib: Commit the auto-generated assembly files for X64 >=20 > CryptoPkg/Library/OpensslLib/OpensslLib.inf | = 2 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | = 2 +- > CryptoPkg/Library/OpensslLib/OpensslLibX64.inf | = 653 +++ > CryptoPkg/Library/Include/CrtLibSupport.h | = 2 + > CryptoPkg/Library/Include/openssl/opensslconf.h | = 3 - > CryptoPkg/Library/OpensslLib/OpensslLibConstructor.c | = 34 + > CryptoPkg/Library/OpensslLib/X64/ApiHooks.c | = 18 + > CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni-mb-x86_64.nasm | > 732 +++ > CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni-sha1-x86_64.nasm | > 1916 ++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni-sha256-x86_64.nasm | > 78 + > CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni-x86_64.nasm | > 5103 ++++++++++++++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/aes/vpaes-x86_64.nasm | > 1173 +++++ > CryptoPkg/Library/OpensslLib/X64/crypto/modes/aesni-gcm-x86_64.nasm > | 34 + > CryptoPkg/Library/OpensslLib/X64/crypto/modes/ghash-x86_64.nasm | > 1569 ++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha1-mb-x86_64.nasm | > 3137 ++++++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha1-x86_64.nasm | > 2884 +++++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha256-mb-x86_64.nasm | > 3461 +++++++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha256-x86_64.nasm | > 3313 +++++++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha512-x86_64.nasm | > 1938 ++++++++ > CryptoPkg/Library/OpensslLib/X64/crypto/x86_64cpuid.nasm | = 491 > ++ > CryptoPkg/Library/OpensslLib/process_files.pl | = 232 +- > CryptoPkg/Library/OpensslLib/uefi-asm.conf | = 21 + > 22 files changed, 26746 insertions(+), 50 deletions(-) > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibX64.inf > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibConstructor.c > create mode 100644 CryptoPkg/Library/OpensslLib/X64/ApiHooks.c > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni- > mb-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni- > sha1-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni- > sha256-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/aes/aesni- > x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/aes/vpaes- > x86_64.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/X64/crypto/modes/aesni-gcm-x86_64.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/X64/crypto/modes/ghash-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha1- > mb-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha1- > x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha256- > mb-x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha256- > x86_64.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/X64/crypto/sha/sha512- > x86_64.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/X64/crypto/x86_64cpuid.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/uefi-asm.conf >=20 > -- > 2.28.0.windows.1