From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.8473.1603767219823777275 for ; Mon, 26 Oct 2020 19:53:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=J7/Cw4vp; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jiewen.yao@intel.com) IronPort-SDR: lN/x7/bz1A+KpBmOqOVRB68e8cicKRGgGm7Jra0U9frjESR0InaJVdpyhFeeJtWeCjte6UhVCx m6xT/TL78tjA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="165427925" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="165427925" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 19:53:38 -0700 IronPort-SDR: zUDoZb8ke8lJY/5aJHbYhE9ZHDWnsltzMnjlzISY5cl4CEHlgf/FRXElK4SjvB4zxOKets8MdF hbQlRLJTMqXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="535613656" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 26 Oct 2020 19:53:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:37 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 19:53:37 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3A7tFesMUilZIfaBAbOUsgwundgjtR/dMORJP8ymu+Z2n6hBlhuFFMEWq/JPoypjUIhJKk0ddkY0c/86R4HFxUWdywVbbZLHvErdZYNwZ+/OK5BSDd5iSN5Riyls4KXdsQgM2mSoVWdfrmVy9K7L2vu25UskvyyXZ4IKkZ4OW1xtslSAqXQ4Yl70SaJP9r3mfHTxPZZ8PeBg8j7SoaFlDRpv40vfmEamVC3yLrwx1dyl6VeFFSmhfblYAbKE/sz+iAr6QQ0NrJSqu73d+7LJ3QoND/ZqXnobL11gxZYhfRE4Q7+GYitXdvaWb2p07Vt8f7NaMYMVUPG5X3xiBK97A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjcP2Wcdfm25muPwckwJedA/aCsIHhtOJAlJm+KCncY=; b=liczDoLxFkSgAF6EtPCYPHUkv+0CRhbITt+/fgR2W3KW/n+iMI0D+qEMIhyoaTVyFojpV/ot6CJ0rAhrFNHw8IIf1KwTkff17YIP1ofxzb02bxgqWhbHdfz+DoLvmzwwYmOblObD6kRlL41T/d1IkvDmcW9Lm9Q2oZ1Irf5jB5DlTm56jSKedNB9Jxtw+y68XdYAN27R3wzp7eQoR1TRnXqdHBUwhHrOjtvK+UbH9CzpOFqCJ2mUFRAUMm0cp5R2YS2d86lB+Gb6UPOxdQWBs0z8w85Q4z6aDQBnGHAoIHyE1a3tYHlSTmulr4b8odtj2KavH6XAQXuefHtpMUBBsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjcP2Wcdfm25muPwckwJedA/aCsIHhtOJAlJm+KCncY=; b=J7/Cw4vpB+Ymqp75Y+e6M9ZGTbV+BuTWrog7W3585foSxbFFogEScUGUrIFSc3mAfVWhHOZimM0JFzs4hcjY4hKzVIY8AxkXYPGxFdZhWw4fcEDUjXaOtNkucWazSKAor+yOudpSs1Lzi1LXcJpPeoAI4JyNjOVY3x+WjAlXWYk= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR1101MB2166.namprd11.prod.outlook.com (2603:10b6:910:1e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Tue, 27 Oct 2020 02:53:34 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac%10]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 02:53:34 +0000 From: "Yao, Jiewen" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Thread-Topic: [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Thread-Index: AQHWrAryo2uai2HYiUWSfGYhUg4U/amqwIKQ Date: Tue, 27 Oct 2020 02:53:34 +0000 Message-ID: References: <20201027024300.21100-1-zhichao.gao@intel.com> <20201027024300.21100-4-zhichao.gao@intel.com> In-Reply-To: <20201027024300.21100-4-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.195] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ccb68a49-c6d0-42a8-edde-08d87a237ef1 x-ms-traffictypediagnostic: CY4PR1101MB2166: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PiWV3Rwsx3uOx6uZUEKNB422btJuy+ZUPMY43X57DpA9vWKFh9kDu2EiYa24KUx15ysORFpWZirVRijbwOvrm5t3+fvMuK8Fgs9yltXWcGhT6DkLxOf6zz6bu2rLPSIvOKcvo0kgZV8XuN+5/maZY/b/eQVWtwfsscOE21wuXoGchHU3bIgaMTICRQmbcFTSWROLzC+/t7CXlSfzUHdESM9WHV2rY1Mkx1nsMhgT5f7hb5lPSBhzjnFB7G5oGyVGP8JEHxjx4zo+jZEqA+4ESfzjTvRniFnfLdT8jtogkcmbJioI3eLmtqcTIwzr3DjRbcRehFi99aca+TY/RFuVlrQFqsRI7IF+FS3o1ZbNHLIWSd9nnpmmIaN4/1rt9mWCODMQuDTfCtCQFRMm+Ltrvw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(66946007)(7696005)(966005)(316002)(4326008)(64756008)(110136005)(76116006)(66446008)(55016002)(71200400001)(66476007)(107886003)(66556008)(9686003)(8936002)(15650500001)(5660300002)(52536014)(6506007)(33656002)(2906002)(86362001)(8676002)(83380400001)(186003)(53546011)(478600001)(26005)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aGo7+arMNmyhNwn/TDg21CItLcuzI60Ca4lG07LTwcndA0xLnMRpvyg3BXJvuv9z5O50wLSSUgJIKED5Mqbo1zaY7bOdaxX08e8/fvqFcbDh672etJTgiZLbP2tdFIfbMCekf94ykVByIT3HJ/mrt7FQ7DZJwsPABKDtrcWs7RkVzLetBQ/5ojlgl8NT36UlwEXjf6x/Wbh6560zC2eMI9RvOKj3hGr9+MYmm37RVCfKFnUVEAOx+c84M5oYarVA0fv92czxkgfIgs9xalh2ADtXZWsysBF65n9iEIiDEePsoxPV/QUQIYXPx0UoPUs2pc87Too10M7tAFpTGtimUaLVoVG5OdqIwgInS+Xy8ZHJynV9UWOMnXc8JpTs0BUF7+JsDllNXc/u07MJoXCBur6IGFa8i+ssKf7fxJLLSIaIpJANJW2MGfDbaf3DlTa3sH6Tfih1KjIiyNs/mK20deZ0Ss0pzaQl29uuIWdGkhNfq4qyQssMVyw0PVgBSBFhb01I8ZietFGGUYz35x2NsTdNw8ZRBUX6+Ob2ZLEc7FjsZzu4HTfjXZNNc4pjbkjXE48JzhslpxDPfwAtS0SKxfyMIPQ03NocVgaSoj4c+zw3UXcum/3HMAkEYE0Z/Zge8GTchWCD82WDgZHhxIS87A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccb68a49-c6d0-42a8-edde-08d87a237ef1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 02:53:34.3994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5pHezGZOoVdrCMNU4PqS0mDx7Ee4hCl+swaI+RDQpZl/Jv89aL9u32fJH57gMH03Qr6m1obfGKpu1Vfwx/UR4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2166 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, October 27, 2020 10:43 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > > Subject: [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3027 >=20 > Remove the deprecated MD5 support of Hash2DxeCrypto > driver. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Signed-off-by: Zhichao Gao > --- > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 1 - > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > index d96bc136e2..50a6157bd9 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > @@ -120,7 +120,6 @@ typedef struct { > } EFI_HASH_INFO; >=20 > EFI_HASH_INFO mHashInfo[] =3D { > - {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), > Md5GetContextSize, Md5Init, Md5Update, Md5Final }, > {&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), > Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final }, > {&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), > Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final }, > {&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), > Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > index a0b57f0514..a65943056a 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > @@ -4,7 +4,7 @@ > # This module will use EDKII crypto library to HASH2 protocol. > # > # (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
> -# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -44,7 +44,6 @@ > UefiLib >=20 > [Guids] > - gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUI= D > -- > 2.21.0.windows.1