From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.46219.1606181333365496607 for ; Mon, 23 Nov 2020 17:28:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s4izVEpR; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) IronPort-SDR: DQlpzYAbI03kAeWNbz0McpTpmEZw72WFfUTUywrnsH6hJab3YZuTSexViLGGrjvf3uYJ+UTxay b55ctxPDd63Q== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="158915804" X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="158915804" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 17:28:47 -0800 IronPort-SDR: 1rz0tocMGPYS5qM8DbRi4bnf1JrcFZzM+x/VE+ezZXoHE7Y0YHmvEl1GsiT8VH40aWTe2hmv3k vAUhmbJtbfxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,364,1599548400"; d="scan'208";a="358653029" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 23 Nov 2020 17:28:47 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Nov 2020 17:28:46 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 23 Nov 2020 17:28:46 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 23 Nov 2020 17:28:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8F83v+6zKq2I3t2u1XS6sS6w+Koqi7spvii/Tq27DA/xv6AsJ4Ffqnp+ZdAlzAjl0rzlIRMw7feWGVPkdeyGqnLotN6XaZiE/ohOCLd0RIMLLKc9gFXKbl2KoAQjnithekligdUtY3J8OlGCG0ZT7KK062QwzpxCXt6ep4uT7/q+coeYoexcubGjECIHkzyuu2ohsS42fcGVSLJx7AXgev17eQEiwoPhQ+X+1IozWOtbfEDCXBhhXKybg3rCD5XPF/IVJPSKuQAMdRqmSwuXahCnBixXOJczQPJQBI1Bm+gmsKtSpu/tuKrYEztKkQp+ZcmlSoMxREBhjy9l8SBcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTlNmgm4wgzYbwIqaAYApi9CRdYzz+Haos9U91R/t/4=; b=T23vtxml6oJzqjliDmNy37smPWWOmrzFYS/a3/VGNK7CLktrVFcM5TxjTX/AobXnufJrm+2XHrfCXJLWbpQUBjYkXDa448ZqM8HbYknXQR8gJLxkMZ7wC9f1MA6DjYf0REbamZmDjyke+dNChVAb6iAGbFC4JzKz7BxZjJBFkgT13dX45Nlcy16DrOalER10irLaGHr3XG3BIYwjDYWZaYsISKkgGpRhWbYHRb0A+a3Rl0jRL8bADzTZxTLFkKX0JxZH1T2cAkki99FcntAKbQygFXvP0uIncO6+428a9cP+Z5I09vu0pq3bzK/Efg/BP3RzcnAhreUnBVxSzvcStA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QTlNmgm4wgzYbwIqaAYApi9CRdYzz+Haos9U91R/t/4=; b=s4izVEpR1FbjRMS4f+h/8EZeLTMHxk8QDsO05GCS8sNWQN/JJIxLhPA9Wu+h1dEEyqbpFz6A+A1Hk/u3FvWy+l+7NAecOB7aUBpmf6iyw8tRWMAgJC4SNSZyj13ZJIFGF8fOsytp5ycYuokM/N3UUEjYZ2EjZZnzvh0/cairDmA= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR11MB1286.namprd11.prod.outlook.com (2603:10b6:903:2e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Tue, 24 Nov 2020 01:28:45 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::a188:2994:6c14:aad7]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::a188:2994:6c14:aad7%12]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 01:28:45 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" CC: "Wang, Jian J" , "Mistry, Nishant C" Subject: Re: [edk2-devel] [PATCH 1/1] Revert "SecurityPkg: Add RPMC Index to the RpmcLib" Thread-Topic: [edk2-devel] [PATCH 1/1] Revert "SecurityPkg: Add RPMC Index to the RpmcLib" Thread-Index: AQHWwgBbws6RnnDZw02dKvJzZtukH6nWfi7A Date: Tue, 24 Nov 2020 01:28:45 +0000 Message-ID: References: <20201124012231.1869-1-gaoliming@byosoft.com.cn> In-Reply-To: <20201124012231.1869-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.80.124.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49e38637-0263-468a-4472-08d89018495b x-ms-traffictypediagnostic: CY4PR11MB1286: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:497; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IVJvbtHJzU6buIVnZcGoVLJyfF4AIXFeDQZua7H/SQI0dMQr0QPZIi8j1hZ3frdOZCL6nX9ufVNM+8aL1avAk9iRSq0r0kYIvZgrZxBAYBrd1nCuvTb2W8iqXLKGhgbcffk2NGIusf8Lp9P9WrBzVBdElLx8yXP1g35gYyEvHjb9x9U/cX2QdJsginzr1bHplDjZBHaZN9CMGjK8B4wlv9YS8hJfNz3bFHmh5APBvTtte9swFf7YzOjZTEEqFJqOcSfnMsqteaIHRH75ycCNd1GPNeCYxGMSyxcLa44jV0RXQSMutGaykk3YjrXf1UrhdcM37+y97F8LW3qeCDjEHC7D5XzB650cUGsMbmZWj3natOcAov1qQoo1UaOwsM18IBeHvF+nk+NYoGTXX08eFg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(52536014)(316002)(54906003)(6506007)(83380400001)(7696005)(53546011)(110136005)(2906002)(186003)(26005)(107886003)(55016002)(8676002)(71200400001)(9686003)(15650500001)(76116006)(66946007)(64756008)(478600001)(966005)(86362001)(8936002)(66556008)(66446008)(66476007)(4326008)(5660300002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Rc0h2no3YEzBfZkwERU7gLA8XMrnu0bm/aca2EEtz6xc15qI3Xwqa18ue2RNtq+jF9MA2GQdKy/cNi07ud4pK0cYrECxW7Bsq4CTiruZH7HapwbTq4caROyrYsAd1zAPicF1MZU/m5T+x330IRqcMDzW1izX9fiprrHOVEcDjoJSyS2+qQXYs5cXGEXw4FgdAvOZ3Q4Em03GT9ovTIHUI8ElBnghOuCM72ShXC3c/A9BgHCddEQSlvs0UOERITZ4m9wzZLpP0ZZMoJFdrkAw9BASsP4s3wmcq//5TeE6xUMuO5uL2oeFOD5oWEanjc8r3/NStluKj9u3qbjygEuyfrIKk6/KxxpROTgjy23YqJLzSZ5b/+TejK59J3oTLSlHzXHpU2xDNb8XEPwLkCP3lTLzGwDyN57p1tarTVcMs3n4pW62ZM8+VM872RISn+Woz2i7bTZ3z3jtiApai8/Iawo66UdvrB6mDMowCFaziKn8wfDoch7t0I/Qs6eI7bMHGG5zXjRskmqvu0gJLzqsY60/widD+QnZNiNVKoffiM6NSgQj7FugrTebguzpXie2eQdB61EQKiK5tt7QYm7XaKq0l0VzLnEs/VV2z+KAj9uigA7UwEOqzU6DWo5IgEWf8ggTLfu+sels0f6JeGCiKG1kXhkS7QurK1sSiq2X46o4nwzK+HLld6k5KCvoMn3a7FGMjnK2Dm1xo094dGWOLK59bOVqXemM50srbr4osS2C+8yZz3N/Knav1k8iaX+szymN0lYZrVM3nNAh+2jv2ZQPl78eLk/TZePOe79sgscd7emlAb6Y+Q9NWv/22yCLZ8jASvJQhJCBnGH56ew29tjzB/by6sNrct8aGuULaVL5HCEKmIa/WmqqImG0XX4JfIziRRRPQ6gNL7h90ngmBA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49e38637-0263-468a-4472-08d89018495b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 01:28:45.1380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +nfCcWVxUoLBk+nj/DlNX8n4jw1OiJhzNiyb++pdPneDAj9+km84oVnfC42A6Xo5zStK49d69+rLp5GujSI37A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1286 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao Reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Tuesday, November 24, 2020 9:23 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Mistry, Nishant C > Subject: [edk2-devel] [PATCH 1/1] Revert "SecurityPkg: Add RPMC Index to > the RpmcLib" >=20 > This reverts commit 6c8dd15c4ae42501438a525ec41299f365f223cb. >=20 > Based on the discussion https://edk2.groups.io/g/devel/message/67764, > this change is regarded as the feature request. But, it doesn't pass > reviewed before 202011 stable tag soft feature freeze. So, it should > not be merged into 202011 stable tag. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Nishant C Mistry > Signed-off-by: Liming Gao > --- > This patch targets for 202011 stable tag. >=20 > SecurityPkg/Include/Library/RpmcLib.h | 6 +----- > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +----- > 2 files changed, 2 insertions(+), 10 deletions(-) >=20 > diff --git a/SecurityPkg/Include/Library/RpmcLib.h > b/SecurityPkg/Include/Library/RpmcLib.h > index 3c15bce1ce85..5882bfae2f24 100644 > --- a/SecurityPkg/Include/Library/RpmcLib.h > +++ b/SecurityPkg/Include/Library/RpmcLib.h > @@ -14,7 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > /** > Requests the monotonic counter from the designated RPMC counter. >=20 > - @param[in] CounterIndex The RPMC index > @param[out] CounterValue A pointer to a buffer to store = the RPMC > value. >=20 > @retval EFI_SUCCESS The operation completed success= fully. > @@ -24,15 +23,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > RequestMonotonicCounter ( > - IN UINT8 CounterIndex, > OUT UINT32 *CounterValue > ); >=20 > /** > Increments the monotonic counter in the SPI flash device by 1. >=20 > - @param[in] CounterIndex The RPMC index > - > @retval EFI_SUCCESS The operation completed success= fully. > @retval EFI_DEVICE_ERROR A device error occurred while > attempting to update the counter. > @retval EFI_UNSUPPORTED The operation is un-supported. > @@ -40,7 +36,7 @@ RequestMonotonicCounter ( > EFI_STATUS > EFIAPI > IncrementMonotonicCounter ( > - IN UINT8 CounterIndex > + VOID > ); >=20 > #endif > diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > index 697e493a7cea..e1dd09eb10a0 100644 > --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > @@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > /** > Requests the monotonic counter from the designated RPMC counter. >=20 > - @param[in] CounterIndex The RPMC index > @param[out] CounterValue A pointer to a buffer to store = the RPMC > value. >=20 > @retval EFI_SUCCESS The operation completed success= fully. > @@ -22,7 +21,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > RequestMonotonicCounter ( > - IN UINT8 CounterIndex, > OUT UINT32 *CounterValue > ) > { > @@ -33,8 +31,6 @@ RequestMonotonicCounter ( > /** > Increments the monotonic counter in the SPI flash device by 1. >=20 > - @param[in] CounterIndex The RPMC index > - > @retval EFI_SUCCESS The operation completed success= fully. > @retval EFI_DEVICE_ERROR A device error occurred while > attempting to update the counter. > @retval EFI_UNSUPPORTED The operation is un-supported. > @@ -42,7 +38,7 @@ RequestMonotonicCounter ( > EFI_STATUS > EFIAPI > IncrementMonotonicCounter ( > - IN UINT8 CounterIndex > + VOID > ) > { > ASSERT (FALSE); > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20