From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.1181.1608083732183495760 for ; Tue, 15 Dec 2020 17:55:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XcwU2WZ6; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 4AiagvRLUsMyLU7Ep2O9eEj07HiL4dvcSbkF63HnjdrtJ461omJbFuDwwCZgmwEHz3kQh728vE yJlmkSy1/2QQ== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="175092511" X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="175092511" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 17:55:31 -0800 IronPort-SDR: bDHD77XOuy67JczrybFDzrqCjMy8mtVOt59Gufi8fSNDQwhWZX66JbXPihFWA2N/CurTcaGcOS cTLbT62TeYIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="451525356" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 15 Dec 2020 17:55:30 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Dec 2020 17:55:29 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 15 Dec 2020 17:55:29 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 15 Dec 2020 17:55:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SASTIu7YbJzLmbFKZHWswJ4VKUvTJ/wb4SYdPB9856yaK/U5Jif3ZLqtYr+QhTdhoLd1ZyRJU6GAxXTeBePYAjOsLzbzQnsPq/YQviei48EWm1ET/V9AKTVRNioofx+knDOGg3qOI/08BgXksNo0+rK4pfkxrzLse3oUfePbCnvckFHNUjqVS9xZgPKLZsMWvpLfW9NxJUrvxbTm8rt7gBQdtefkLpumi7ilXR82so03o8q8S3el9ZxKQTCwZ+UVCDgbxpKEX++wcqiyyHpsvfjD3Kl7B43bocVvCkidSKRtlNXK5AM+hlNBW3OoVTh28nNdvlW+zdaXanZnG9QYtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HlHTdGILMRx+hMkaT2DQRafyzCyephAHx5xZzt7s9fo=; b=Bg4swmv6gelB03P0seajJFQjPQLmXBO+2ME6Kd7cJkpMnmf4jYAoNDJlhMGd4miLplksJ5cAZQojpQ+DEAcOJg5JwhvVtz1mpuXew+02YOjaFcHQVAYFzu4E4zsdF9wjoxyRsZFfkTKUFfz/rioA23R112PSES6DAvUtlKW0/IBpZ1g3EnFQCqJsereTcPVTCDtCDiwW3d+891cGEWMj5MFcSS/tAziWQek083SgiB49sBWkWrwaHi9Gc7cOG7LcS8DIonGvKvHppwCGfc3q21J5pVSNcGLtwmDjoq5an1uu4tDb4HQEZu7lDYmkIKKVCECKUAS9Kk6UAxrdQNm+FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HlHTdGILMRx+hMkaT2DQRafyzCyephAHx5xZzt7s9fo=; b=XcwU2WZ6msxIkXamS0vDTlc3Eonfe51IgbSMcEBc5PEIXEiY0W6Z1N6pvzqKg/xME6CTPoyWnFzLKgsE3peUlTalv/qB/SA7zuL1ZS0KcXyt9rHmG8jTsjtPGEVmFh//EqspH5NQiCOLcsan8MK09FC2Q21Ck5x/A3Ryfmk/0LQ= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR1101MB2200.namprd11.prod.outlook.com (2603:10b6:910:19::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Wed, 16 Dec 2020 01:55:26 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17%12]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 01:55:26 +0000 From: "Yao, Jiewen" To: James Bottomley , "devel@edk2.groups.io" CC: "dovmurik@linux.vnet.ibm.com" , "Dov.Murik1@il.ibm.com" , "ashish.kalra@amd.com" , "brijesh.singh@amd.com" , "tobin@ibm.com" , "david.kaplan@amd.com" , "jon.grimm@amd.com" , "thomas.lendacky@amd.com" , "frankeh@us.ibm.com" , "Dr . David Alan Gilbert" , Laszlo Ersek , "Justen, Jordan L" , Ard Biesheuvel Subject: Re: [PATCH 0/2] Update SevSecret API to work for TDX Thread-Topic: [PATCH 0/2] Update SevSecret API to work for TDX Thread-Index: AQHW00yzjrTrJLc+g0qVLPJuoe+5f6n49ilw Date: Wed, 16 Dec 2020 01:55:26 +0000 Message-ID: References: <20201216014146.2229-1-jejb@linux.ibm.com> In-Reply-To: <20201216014146.2229-1-jejb@linux.ibm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: linux.ibm.com; dkim=none (message not signed) header.d=none;linux.ibm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 786e6c4a-f6dc-4488-d516-08d8a165a8a5 x-ms-traffictypediagnostic: CY4PR1101MB2200: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GG3P7xO3t2eM0PVm0jSBKFcKSVFiwExvEcNUdfnuQ14UmdsJld3Vp1tcaqo2HxwVQu9xgpVDfRXEf1UT+QPqeIlEzVc5pNG7u/PIS328FXBas1lB0QZr779GKF/AsPAaYApY33qFXEaiiFAyRPaMtvyPgfD+v+TErZuR+I704tBWY3KhfE4J3fiO3s6sJRNMgnadUXPL81cyz6Qkv5cxcc4OGMolacpa8X/s7RSIidYO1ltqJEAf7fnpVE0E8HqogTd/3QAJl16YABbjkK1TvXAje+0ezlA0E8LJhsdIVX3EBilPriBB6tzs1sKloouAJOWwm+3WGegOo+/IZ6g+qQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(86362001)(83380400001)(316002)(55016002)(66476007)(54906003)(9686003)(64756008)(66946007)(5660300002)(4326008)(110136005)(33656002)(6506007)(8676002)(186003)(76116006)(15650500001)(8936002)(52536014)(53546011)(26005)(7416002)(478600001)(71200400001)(7696005)(66446008)(2906002)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?cTJQGixs0hM2cuHaS+UkEEWMUFWg5RcNEOTBg8oczBpQ3OCjxVxU9LtzcWdX?= =?us-ascii?Q?D0zmGdvB0BBCp7/rBeJOLEB8+b9twDtv5WKlgWG9wBk82kQP7WUrsR0fLAZg?= =?us-ascii?Q?q1A5jW3rlCFyLD1Maiax5rDl5K9c7JYOVavrS/pJBcoyPtIcz5K4OiSY82Uf?= =?us-ascii?Q?62D1A3KNMW9RmMVjKFR6jkjABg5vNWGJPPYq25hw9CMGgclFqn/QR4PtE6zn?= =?us-ascii?Q?yyl2y2kpCXJuXs9KVqLtbOIcrACGZzxF74kWA1MEn0Af+aqmA8HDafAtc5Db?= =?us-ascii?Q?i7+pQCxTZj0q046F4KVKTyEj5qDuXxEMmQIYqb+c9jffgHCrVCnBdVNIJ85C?= =?us-ascii?Q?n1KxiVGPbpURxqd7jfqIGc3CuVEl/dV2UNNqEQoZkZbCugbRqMd3CVX8xKFX?= =?us-ascii?Q?n69SynxDTggJ5rHjvb0aMpdvbDoB5e5UYZluJ4jJcN10n3pzbef0mjBJTsdh?= =?us-ascii?Q?efA4LJQjB6y094QUpabEpfbI/52Opaxztl/PNaSxwUypEaT8pbLYKJ6bgyS/?= =?us-ascii?Q?ImHORav5ftSKvSsY0O808YBbgd3h1XXIX7w+1ObTD9WGHeOQRY8RmqpNatH2?= =?us-ascii?Q?u2LlMoW4YRevuoTGmo0ufihxn1jCHw6H2Y+CxU/4+7UzLSt7YKPCdbFIElaW?= =?us-ascii?Q?CeFn41rjBKR6BOU/MToV+b9p6fncejJ57z5tPA6N9wXogyy8RekqY0pjPiMy?= =?us-ascii?Q?ZT53zbcZU+VDMSMRjRVksGSwJyihlsdl4EOyK+Ktf4t0JlcJ2sQB11y+G6eF?= =?us-ascii?Q?lABHXe7K9ZvYdcvmsMLZAFBags3UfrQSLiVQrDsY8+ZjHqvnHt6oLO3Z+Rw6?= =?us-ascii?Q?YFQczr6vXuXkq/g+0kn9GDGHDZ9SUJvgKVkVRye7TX9D8hAPJxJ0b31C2s+y?= =?us-ascii?Q?rgklxo89vPsRu2+VI6/SM9ggnchlmNz63RRxOHl00EhcLzyUtgB3vGZhjE/Z?= =?us-ascii?Q?H/fxqtoI1yaX6gAjeOpl4DPkUz5Gv6Nt4aQlpC1weVrQ70sIp+rPGajNhB1N?= =?us-ascii?Q?blvD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 786e6c4a-f6dc-4488-d516-08d8a165a8a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2020 01:55:26.5244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MC4kAasxXveE7VfhySwL1aEFICeWek68yakDHUvCr4urhsOG/ns7gUouRHEmJtptkO7uM2NDqMWwmbdct1qQtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2200 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series: Reviewed-by: Jiewen Yao > -----Original Message----- > From: James Bottomley > Sent: Wednesday, December 16, 2020 9:42 AM > To: devel@edk2.groups.io > Cc: dovmurik@linux.vnet.ibm.com; Dov.Murik1@il.ibm.com; > ashish.kalra@amd.com; brijesh.singh@amd.com; tobin@ibm.com; > david.kaplan@amd.com; jon.grimm@amd.com; thomas.lendacky@amd.com; > jejb@linux.ibm.com; frankeh@us.ibm.com; Dr . David Alan Gilbert > ; Laszlo Ersek ; Justen, Jordan L > ; Ard Biesheuvel ; > Yao, Jiewen > Subject: [PATCH 0/2] Update SevSecret API to work for TDX >=20 > This patch series changes the EFI configuration table information > which is queried by the bootloader to make it more compatible with > Intel TDX. The first patch changes the ABI to make the table contain > two 64 bit integers instead of two 32 bit ones. The second patch is a > cosmetic one to change the names of the GUIDs and tables to have a > confidential computing prefix instead of a SEV Launch one. >=20 > The first patch *must* be applied before the next stable tag to avoid > ABI breakage. The second is purely cosmetic and doesn't change the > code output. >=20 > Ultimately there will still need to be a TDX collector for the secret, > which would feed the value into the SecretDxe, but these changes > should ensure that no further changes would be required by the secret > consumers. >=20 > James >=20 > --- >=20 > James Bottomley (2): > OvmfPkg: Change SEV Launch Secret API to be UINT64 for base and size > OvmfPkg/AmdSev/SecretDxe: make secret location naming generic >=20 > OvmfPkg/OvmfPkg.dec | 2 +- > OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf | 2 +- > ...aunchSecret.h =3D> ConfidentialComputingSecret.h} | 14 +++++++------- > OvmfPkg/AmdSev/SecretDxe/SecretDxe.c | 6 +++--- > 4 files changed, 12 insertions(+), 12 deletions(-) > rename OvmfPkg/Include/Guid/{SevLaunchSecret.h =3D> > ConfidentialComputingSecret.h} (65%) >=20 > -- > 2.26.2