From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.4236.1607553067549629414 for ; Wed, 09 Dec 2020 14:31:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=k9BeRV4Y; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 69I7OU6ab3n5DdPvjDKfISwjOWmcwREmHhzHeK/8h6+zeZuPa6O5WTmWAe595IqKje0jTsm99w QqOJojn672Lw== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="174305786" X-IronPort-AV: E=Sophos;i="5.78,407,1599548400"; d="scan'208";a="174305786" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 14:31:06 -0800 IronPort-SDR: 8cwNnAcLkKvjnMAKfKr8BxHG3cDp+T+TpSxYgBEOMTmU0jjcsfuxdSvNzHRY+flw1fKZ/Fi4Us zsaRGWlAEfRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,407,1599548400"; d="scan'208";a="364334843" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 09 Dec 2020 14:31:06 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 14:31:06 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 14:31:06 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 14:31:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXAlfztcWtlWckDf0YtKWAISOxwY1Z+rFXh0p2QvKrS9hYr9RkOt21wdlxslot/IxDkVhJOZnqo5qE23t5rE0xDP3mUBQRqA2ggEvyoSz1TmQhc/L1vZJy4FJDW831YPwKOo9EhZ5SB1HfBawcpWO7vOyJnhq7t3rVMIYY+aA9WCDEH8+51FYwgeW9qTRCFGJxO/fBhDt2urQDBx/dTQ3u4B3fnupZblcz70jYLD4Q1n5LlTpuPvWQnWWUh0Xhd6Z1VFkE/LD9Z9vHyJ0O3cF++y4qI1uOWYpKxscI8jImv3wNMEdhhqqZuu0rTrOZQ6AIc3loBHwDew/d9SutFxGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uCTTAQJtWJu0dRlz6N7Zjm/NGRTORkPZoaiKLn7ucMY=; b=lWREpVGCqVUl3Kv3WQBK6zwGeaq+S8FBOB3R+2F5RfGanoR7C1brUhMLxgZFufqzHK9jIELf/tMAsB7QkKgw5WQkgiFx3cYLvIBpVvsG5ReXMLcld5Th928J6jf63hVCQNq4zc54nfc+yBKvVokQ60VkI6ZDitFu9u+O/0n6LrOTWEdMOJmXugqyV0vf1hF3itfU2LbLhKZTnBUeNnClTnY2ZtPpxeBWWwNtCXTYu72Br1yxCXIdb/vJZJ0HdNLul9BYaBYvfeo5tQi3p7Xl6TLK6g1F70Vofs02dXV2SnR/o5Q46VTPfXbZPGlKH3La9VAfgkXwGuVmxxP6iZzggw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uCTTAQJtWJu0dRlz6N7Zjm/NGRTORkPZoaiKLn7ucMY=; b=k9BeRV4YQ53DMEAVBPz1FauvBghvYa7JLu4CvoBYKgscdJI5fYHHoWx+diRffq+kkGc4je1URCTpLxxxze0PsUdHPgmV5OMhdrsjyUJMZaeOhNH/DyyTcu+cKPDrlWE1UcjXG2LZrd0q/EjSXI0GKwGSdCH88qg7LpwlV8oZ0h8= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR11MB1639.namprd11.prod.outlook.com (2603:10b6:910:f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 22:31:04 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17%12]) with mapi id 15.20.3632.021; Wed, 9 Dec 2020 22:31:04 +0000 From: "Yao, Jiewen" To: Sami Mujawar , "devel@edk2.groups.io" CC: "ard.biesheuvel@arm.com" , "lersek@redhat.com" , "thomas.abraham@arm.com" , "Sughosh.Ganu@arm.com" , "Matteo.Carlini@arm.com" , "Ben.Adderson@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg Thread-Topic: [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg Thread-Index: AQHWzlvVc3j2UJrlCkiW5hE99gR7I6nvWL2w Date: Wed, 9 Dec 2020 22:31:03 +0000 Message-ID: References: <20201209184710.20912-1-sami.mujawar@arm.com> In-Reply-To: <20201209184710.20912-1-sami.mujawar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cca4e966-6f9e-4cba-7cdd-08d89c921d2c x-ms-traffictypediagnostic: CY4PR11MB1639: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rJ4ESIKFXuVK3kDC1ShsUB33R/bBMcnDYSomVrM4zdXKa88vy0sh9/VdXqTsvdeaNA2i4RWaMuBAsRovdDraBvSPNfqxTlsQcrFp2afEeWkgNY7gQbDaFhMPTQCVtH4f9vB1hriukvLZ2qexwk96sXkgSO+UhvZ+oazw76c6f7b29y1Jb6eNJUdhvmPy1vYi3rhMj0u1sS/PD5nzYx2HshRalcw5b93sUGAKOz+G6M0Ayk5UKcBmHTnYV04i7zfDDNhOFXc1BUJRM2onj+0Y6m2miQYzZr14Joo9ID07nT7TKnG640RsyHutXzBz3pCfmqZV4v19FvxFlh7TaeZJV6TCd8lu5nv2YW29nI/mZ/osHQ1+brPE/VA8NUiIb8E4hQ2UH0nblFjZOZK8RChaZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(376002)(136003)(346002)(366004)(508600001)(83380400001)(8676002)(110136005)(86362001)(26005)(33656002)(5660300002)(54906003)(4326008)(66446008)(71200400001)(64756008)(966005)(9686003)(8936002)(6506007)(186003)(7696005)(52536014)(55016002)(53546011)(66946007)(76116006)(66476007)(2906002)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2YPP8Pd2YzDTtNA3B03KLO4bgj0DZA4spgHWOoTh0tjU41Hb8vnxFkkckxxM?= =?us-ascii?Q?XAu2QEwLi2UNB6bpA8fpEaZXUvq9XtMbIhjCFRV2UWKwjdICcV3jX/FMVe+3?= =?us-ascii?Q?usBzJtQhtM/DKcrCkYZpxZFxN1Ntnti2bxFMipoS1QgzIsFriUyRunnPEnRh?= =?us-ascii?Q?kOxjXLz7dTs6IQ3adaX7OR9zXMWsAqhm7QK2rnhu4NcOD5JOA52M+bMAqKMA?= =?us-ascii?Q?iE00FgGooP8mx8EDQHMqK93BdzlkFcLULnP1REidsKlUuzxj6UZUu1b9AlXd?= =?us-ascii?Q?9iL9CFGW60CLgKDKGixJl7eHez40ui8p5vuJ/qJSLCfScPTEiZevcQ4ytanz?= =?us-ascii?Q?2E6ob/k2JBGGg/v/aJKaKv4JlapN5v0FmiCmYqsVogKy8UaqzincofyMgBZ4?= =?us-ascii?Q?CcYnTPT+TEBqbKRRyp7D4DfbW1W8EVxr6qxFj7rg4lHIrAdCPMA8V2altwbY?= =?us-ascii?Q?e9RWYVIG1UTS75/M6NpJ2H/pgFIRQEk5Xf6riIFYbNP29YU4NpapO+RQcEwq?= =?us-ascii?Q?ylF2tbWt2bYAoAmVuK8VrLvwW2geNO4i4YNlyYNHDOcH9DZmGyy6OWaCdIqZ?= =?us-ascii?Q?wYlQqAxxvS0K2kvDGWj77iXTolRA2pTO2f76YPAqyGOjdwlH2XLQCrSjVcFI?= =?us-ascii?Q?jUm/GCKtfGKrY+yxaCR9OucunjT2309d4klBm7ujZsMOP835zbV2OzEMKqrl?= =?us-ascii?Q?jwozDm3swlJNppy5cYiUhd6aSoPFEk7sFYulw7Byq0smvNQ6LyiOLNKCNjn2?= =?us-ascii?Q?yBsnm88t1n9sptNFtthfwHxMnRAgpag+2MP3EUyUh7jHWeyEE9PJbK7aZ3U9?= =?us-ascii?Q?tfz66RVUQuDQjjrtHTUZ1LCWCIarotJYwbWER/t/nqMafjeFb18vJ6mq/esl?= =?us-ascii?Q?qBjwQeLWcZmmrEWIEJJbfyBc5sh8Z4iVXNdjIk9gjSPgMbYHtp20annvKZ0v?= =?us-ascii?Q?On7yB76oHm/teMz+CCrShFD3X9+OZ7fK5Ydzv+lWhKoMoQRjsyo5clzDz9Z1?= =?us-ascii?Q?PjPr?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cca4e966-6f9e-4cba-7cdd-08d89c921d2c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 22:31:04.0228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UJJXHyCEUG5YV1Zs1XOhB4FWnGuuRvdXxW7qwgX4bHnZ17ddiWGrYqUtjSphxFXLKTQe05q09rHYOG8+85PVqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1639 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao > -----Original Message----- > From: Sami Mujawar > Sent: Thursday, December 10, 2020 2:47 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; ard.biesheuvel@arm.com; Yao, > Jiewen ; lersek@redhat.com; > thomas.abraham@arm.com; Sughosh.Ganu@arm.com; > Matteo.Carlini@arm.com; Ben.Adderson@arm.com; nd@arm.com > Subject: [PATCH v1 00/25] Enable Core CI support for StandaloneMmPkg >=20 > The EDKII Core CI runs the ECC tool that checks for good coding > practices and the coding standard. This patch series fixes the > ECC errors reported in the StandaloneMmPkg and enables support > for EDKII Core CI. >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v1 >=20 > Sami Mujawar (25): > StandaloneMmPkg: Add library header files to DEC > StandaloneMmPkg: Add library files to DSC > StandaloneMmPkg: Fix spell check reported errors > StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher > StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management > StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 4002 in FwVol helper > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore > StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib > StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core > StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib > StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu > StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint > StandaloneMmPkg: Add EDK2 Core CI support > .azurepipelines: Add StandaloneMmPkg to CI matrix > .pytool: CI Settings to support StandaloneMmPkg >=20 > .azurepipelines/templates/pr-gate-build-job.yml > | 2 +- > .pytool/CISettings.py = | 1 + > .pytool/Readme.md = | 2 +- > StandaloneMmPkg/Core/Dependency.c > | 6 +- > StandaloneMmPkg/Core/Dispatcher.c > | 49 ++++++----- > StandaloneMmPkg/Core/FwVol.c > | 36 +++++---- > StandaloneMmPkg/Core/Locate.c > | 6 +- > StandaloneMmPkg/Core/Mmi.c = | > 4 +- > StandaloneMmPkg/Core/Pool.c = | > 6 +- > StandaloneMmPkg/Core/StandaloneMmCore.c > | 37 ++++++--- > StandaloneMmPkg/Core/StandaloneMmCore.h > | 12 +-- > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c > | 56 ++++++++++--- >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu. > c | 34 ++++++-- >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu. > h | 31 ++++++- >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu. > inf | 9 +-- > StandaloneMmPkg/Include/Guid/MmCoreData.h > | 6 +- >=20 > StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint. > h | 47 ++++++----- > StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > | 4 +- > StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h > | 6 +- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateH > obList.c | 6 +- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi > ssions.c | 53 +++++++++++- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalo > neMmCoreEntryPoint.c | 32 +++++--- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal > oneMmCoreMemoryAllocationLib.c | 6 +- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Standal > oneMmCoreMemoryAllocationLib.inf | 4 +- > StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c > | 10 +-- >=20 > StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc > y.c | 4 +- >=20 > StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependenc > y.inf | 4 +- > StandaloneMmPkg/StandaloneMmPkg.ci.yaml > | 85 ++++++++++++++++++++ > StandaloneMmPkg/StandaloneMmPkg.dec > | 20 ++++- > StandaloneMmPkg/StandaloneMmPkg.dsc > | 15 +++- > 30 files changed, 439 insertions(+), 154 deletions(-) > create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'