From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.5745.1596357411541455251 for ; Sun, 02 Aug 2020 01:36:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=b+90GA10; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 4rNGysU/9oY1/+qgfZxM8Vznt2sdHvRcTdi9zBNI5920NgP+U8ySQsk+sgwIEu40NLw7fKln49 a+2Q//T9cHRQ== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="139941774" X-IronPort-AV: E=Sophos;i="5.75,425,1589266800"; d="scan'208";a="139941774" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 01:36:50 -0700 IronPort-SDR: nvs25G9mH2lZg+DTRwfz8ZQOifPTk605qsdSdFhyED+rwudXRCPwgesIgA3ZKtS7DrCS1W0db7 F8c3n+6SZCQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,425,1589266800"; d="scan'208";a="314321187" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 02 Aug 2020 01:36:49 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 2 Aug 2020 01:36:49 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 2 Aug 2020 01:36:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 2 Aug 2020 01:36:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqT/HiD7aqEx2TpEnz+2zu92FhvxuSNPIu93MQpyCBaZ5lj6EY+UapNO3AUVAmXWZHP3ITm4EGZaQUOk2iIQJbiQlKGVw1mREOD6YCU6pkFNlakPbNEEO0OcS1T3w/qp4FjWrLB4qxb2dJMu675ip1bdKnsvXqLXR1PLvvkCDKHlH6FX1QwAjqyHqRU8bDexszcFYR0uL4U/ujJUcCXshB/FGDLpnyCJeq0WG1eldt+OiZPRiMloLD2/7A33Qn8NQqXDkKSQGY83bakTnZBKvwZJaZ/o5Z+DCiFkGXj+wWBjKLI8yJfsOsIZAhTkD8w8brYBu0C6E5wdrX6EJahIbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzCB93yMcAw/m/f1li4OpLrx93LIxGcUvFQbOQieolc=; b=gWOoWglUqTLBWcP9REUQqjYrZdyKCmweHbpnAo+tyj6iIU/xvYCOtv2FKffxgJGiTLcD4yGaswoB9tMYE6RNbcyeX8AVh45VVYaMqJPhlDJkILGoNt+TU9gD0CcTY9UjYO7Zm07g8Z6Gw3/PaWTLMTT6mL5pxyYqlHJUlhLGDp6xJI5dRrRjceiUx+1ltPbzsi8vDHUQCpW1sJXJ6VGs94bYwxCL1cIIYe02HXrbzyeBoDbaHjrcDPxQoF2PTIsfXA5bgl6go2t6p7ZAb6lohQ8bmf2pRBsJEQOQaPQ91D86rgQLO7Qp6B1+ZDYLvhR2VSHCN9g6BcZgA2jlo4K3/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzCB93yMcAw/m/f1li4OpLrx93LIxGcUvFQbOQieolc=; b=b+90GA10govET8kMsdH/YXnD7EcWbdTLxqA0BF6e4ryDgbbm9mnL049Tv4xIEfWSmHRpBDUkIL6/MnadYK1JNhB+VImPzFL0Apcp6eT2RjHXYDZrRb86swrOTffX70sM6DBIWVz50bkKfiHOUT+yJy+8+1pQcx2Xf2R2oxS5BVI= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR11MB1478.namprd11.prod.outlook.com (2603:10b6:910:8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.19; Sun, 2 Aug 2020 08:36:47 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8cfa:f914:1ef2:9bbf]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8cfa:f914:1ef2:9bbf%7]) with mapi id 15.20.3239.021; Sun, 2 Aug 2020 08:36:47 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to TpmMeasurmentLib. Thread-Topic: [PATCH 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to TpmMeasurmentLib. Thread-Index: AQHWZxhD41uXDCPZ8EqG9+iaggng/akkgZKQ Date: Sun, 2 Aug 2020 08:36:46 +0000 Message-ID: References: <20200731085437.16070-1-qi1.zhang@intel.com> <20200731085437.16070-2-qi1.zhang@intel.com> In-Reply-To: <20200731085437.16070-2-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjZmODEyYjUtYjNhZC00Zjg0LWE4NzgtMTJjMTFkYzUyMjJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTmhoVEkrQXd4M1Z2NzhqQ1lSTGxTVEhnYzJEVkVJdU1rVVwvQXlvblFXTE9abk0rWnJaS2JuYmZPK2F6TmxLYUMifQ== x-ctpclassification: CTP_NT dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7755a823-8f91-4e63-987e-08d836bf319c x-ms-traffictypediagnostic: CY4PR11MB1478: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FljZNx0qD2HWg3/58Ojkp0twg7bp6pbydsLXQ9pG2v9b/0kNwHzRRaukHkLIVal2ekho8H0kIBYdy6b27mEZoqnywJeH33HonJO9sSoOpU6EEXIf4iQtqRQUUMhXWKzu0lXjYCToeSV0fKYpsmG3RcCWGhuzGNB+cnSxxiBbepFe+FcybtztBLNV1jFnQE+9aV4Jt4glTtDYJkZH3FGQVWF5/bhRyPJqhdN8QYe/rKSnAQlfzpVgdeC9+44wUbXZylZ+UqixWoRZ05jI1el9m8aAQDXai1Crcj87n7kkqJ9VXOV1cXpnjaIY/Icj3c898un1yICjoqO3+Ogm5JfSa4hQAKPplM0bhpzQ5d0QNO5+9OSYy9TfIosXjMcWgNlPeaNLb6GkqU4e1nIOZDBb5Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(66556008)(33656002)(4326008)(52536014)(66946007)(55016002)(8676002)(66446008)(71200400001)(107886003)(76116006)(2906002)(8936002)(64756008)(9686003)(66476007)(26005)(5660300002)(54906003)(83380400001)(110136005)(86362001)(7696005)(478600001)(966005)(316002)(186003)(53546011)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1+71m/wERbh9s6cJFio5QNr5x0cE1nS9K1IQaCwa3G0D8vBWuYjvRX+7TJR2L68Ex2W/ZUxor23T2RSlnA2HooITvx1lCc4kXRVYRfYAnZ+i6hrvxRERpYCN5LxEDwE3juBzjdsGUrXNHq5OmLlCa9vTd6i56f9YM0CTefCF1PaQj0B2LAxJKiz13MilAmGPwciVs5rJCT5AJBzPgmDD1BD+a4uhQj9bfC4n9rQdHR4pxYpWAxFcxc/VCcEM1Gk/v3dMaJ4/IBWhghAzjiUNUTfFeuyuVqSKUFdK3b+kOQ+BAHn7GEIdyX59dLOza+2gKpbssPzjxZKgr14CkFbD7Y8omnd0dlb1cfxCxdIf/e+ZlfY6ttuXLoyIcHwW2RuIfN0uAt1HgRIKUYTbhw3nSk0Rdk8OzLJwXQT5fi5F0d76vYT/91Sp1cIj6noMKdh7vo0hS7HuOkGL5uv4seiWI0OOlhqWg7eB7j+rNVsU1OqOqUa/dGiGZavGwjiPH3wjRSYjhejZTQT5my3+nHEtcZ80d91Nh16S8dVerxwYYJ4fPmfrZ9v+xdE4nlkqcpPP79w7neknTm6MQy1ayNMkCc9lSOFKnG67puXeJPKwf/kGU5u2BrE6JohfFjJwV8XEsnSKKJpNmOWShHjUxyEiFg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7755a823-8f91-4e63-987e-08d836bf319c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2020 08:36:46.8736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 61HvJKEtJWbaJPoZsNO7F7vIs3bMPXk2xG/WnanynrsDG2vhJU4GFMLs3E222ca4/2D7hmjOvlm8PKKqwC/L6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1478 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Qi The PEI FV does not have CfgRegion concept. We should remove MeasureFirmwareBlobWithCfg(). > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, July 31, 2020 4:54 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Wu, Hao A ; Zhang, Qi1 > Subject: [PATCH 1/9] MdeModulePkg/TpmMeasurementLib: Add new API to > TpmMeasurmentLib. >=20 > From: Jiewen Yao >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2376 >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Qi Zhang > Signed-off-by: Jiewen Yao > --- > .../Include/Library/TpmMeasurementLib.h | 71 ++++++++++++++++++- > 1 file changed, 70 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Include/Library/TpmMeasurementLib.h > b/MdeModulePkg/Include/Library/TpmMeasurementLib.h > index ddf6723f03..cd4d175918 100644 > --- a/MdeModulePkg/Include/Library/TpmMeasurementLib.h > +++ b/MdeModulePkg/Include/Library/TpmMeasurementLib.h > @@ -1,7 +1,7 @@ > /** @file >=20 > This library is used by other modules to measure data to TPM. >=20 >=20 >=20 > -Copyright (c) 2012, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2012 - 2020, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -35,4 +35,73 @@ TpmMeasureAndLogData ( > IN UINT64 HashDataLen >=20 > ); >=20 >=20 >=20 > +/** >=20 > + Mesure a FirmwareBlob. >=20 > + >=20 > + @param[in] PcrIndex PCR Index. >=20 > + @param[in] Descrption Description for this FirmwareBlob. >=20 > + @param[in] FirmwareBlobBase Base address of this FirmwareBlob. >=20 > + @param[in] FirmwareBlobLength Size in bytes of this FirmwareBlob= . >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +*/ >=20 > +EFI_STATUS >=20 > +EFIAPI >=20 > +MeasureFirmwareBlob ( >=20 > + IN UINT32 PcrIndex, >=20 > + IN CHAR8 *Description OPTIONAL, >=20 > + IN EFI_PHYSICAL_ADDRESS FirmwareBlobBase, >=20 > + IN UINT64 FirmwareBlobLength >=20 > + ); >=20 > + >=20 > +/** >=20 > + Mesure a FirmwareBlob in separation mode of FV binary and configuratio= n. >=20 > + >=20 > + @param[in] Descrption Description for this FirmwareBlob. >=20 > + @param[in] FirmwareBlobBase Base address of this FirmwareBlob. >=20 > + @param[in] FirmwareBlobLength Size in bytes of this FirmwareBlob= . >=20 > + @param[in] CfgRegionOffset Configuration region offset in byt= es. >=20 > + @param[in] CfgRegionSize Configuration region in bytes. >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +*/ >=20 > +EFI_STATUS >=20 > +EFIAPI >=20 > +MeasureFirmwareBlobWithCfg ( >=20 > + IN CHAR8 *Description OPTIONAL, >=20 > + IN EFI_PHYSICAL_ADDRESS FirmwareBlobBase, >=20 > + IN UINT64 FirmwareBlobLength, >=20 > + IN UINT32 CfgRegionOffset, >=20 > + IN UINT32 CfgRegionSize >=20 > + ); >=20 > +/** >=20 > + Mesure a HandoffTable. >=20 > + >=20 > + @param[in] PcrIndex PcrIndex of the measurment. >=20 > + @param[in] Descrption Description for this HandoffTable. >=20 > + @param[in] TableGuid GUID of this HandoffTable. >=20 > + @param[in] TableAddress Base address of this HandoffTable. >=20 > + @param[in] TableLength Size in bytes of this HandoffTable= . >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +*/ >=20 > +EFI_STATUS >=20 > +EFIAPI >=20 > +MeasureHandoffTable ( >=20 > + IN UINT32 PcrIndex, >=20 > + IN CHAR8 *Description OPTIONAL, >=20 > + IN EFI_GUID *TableGuid, >=20 > + IN VOID *TableAddress, >=20 > + IN UINTN TableLength >=20 > + ); >=20 > + >=20 > #endif >=20 > -- > 2.26.2.windows.1